Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast Multipole Method #29

Merged
merged 22 commits into from
Oct 28, 2020
Merged

Fast Multipole Method #29

merged 22 commits into from
Oct 28, 2020

Conversation

maxscheurer
Copy link
Owner

@maxscheurer maxscheurer commented Jul 14, 2020

  • use previous ind. moments vector as guess (also for CG+FMM)
  • field computation for monopoles, dipoles, quadrupoles
  • cleanup (silence some outputs...)
  • recursion tests
  • decision on default values for theta and exp_order

Repository owner deleted a comment from lgtm-com bot Jul 14, 2020
@lgtm-com
Copy link

lgtm-com bot commented Jul 15, 2020

This pull request introduces 6 alerts and fixes 2 when merging 1859ffd into 01020be - view on LGTM.com

new alerts:

  • 4 for Unused import
  • 1 for Comparison result is always the same
  • 1 for Variable defined multiple times

fixed alerts:

  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
  • 1 for Non-virtual destructor in base class

@maxscheurer maxscheurer added the enhancement New feature or request label Jul 15, 2020
@lgtm-com
Copy link

lgtm-com bot commented Jul 22, 2020

This pull request introduces 5 alerts and fixes 2 when merging 3e6c8eb into 01020be - view on LGTM.com

new alerts:

  • 4 for Unused import
  • 1 for Comparison result is always the same

fixed alerts:

  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
  • 1 for Non-virtual destructor in base class

@lgtm-com
Copy link

lgtm-com bot commented Aug 18, 2020

This pull request introduces 5 alerts and fixes 2 when merging 3e1f996 into 01020be - view on LGTM.com

new alerts:

  • 4 for Unused import
  • 1 for Comparison result is always the same

fixed alerts:

  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
  • 1 for Non-virtual destructor in base class

@lgtm-com
Copy link

lgtm-com bot commented Sep 1, 2020

This pull request introduces 5 alerts and fixes 2 when merging 4048164 into 01020be - view on LGTM.com

new alerts:

  • 4 for Unused import
  • 1 for Comparison result is always the same

fixed alerts:

  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
  • 1 for Non-virtual destructor in base class

@lgtm-com
Copy link

lgtm-com bot commented Sep 9, 2020

This pull request introduces 5 alerts and fixes 2 when merging 19e1969 into 01020be - view on LGTM.com

new alerts:

  • 4 for Unused import
  • 1 for Comparison result is always the same

fixed alerts:

  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
  • 1 for Non-virtual destructor in base class

@lgtm-com
Copy link

lgtm-com bot commented Sep 10, 2020

This pull request introduces 6 alerts and fixes 2 when merging 13da6a9 into 01020be - view on LGTM.com

new alerts:

  • 5 for Unused import
  • 1 for Comparison result is always the same

fixed alerts:

  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
  • 1 for Non-virtual destructor in base class

@lgtm-com
Copy link

lgtm-com bot commented Oct 27, 2020

This pull request introduces 6 alerts and fixes 2 when merging 87ffeb2 into 01020be - view on LGTM.com

new alerts:

  • 5 for Unused import
  • 1 for Comparison result is always the same

fixed alerts:

  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
  • 1 for Non-virtual destructor in base class

@lgtm-com
Copy link

lgtm-com bot commented Oct 28, 2020

This pull request introduces 6 alerts and fixes 2 when merging 09f7b8c into 01020be - view on LGTM.com

new alerts:

  • 5 for Unused import
  • 1 for Comparison result is always the same

fixed alerts:

  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
  • 1 for Non-virtual destructor in base class

@lgtm-com
Copy link

lgtm-com bot commented Oct 28, 2020

This pull request introduces 1 alert and fixes 3 when merging 159e946 into 01020be - view on LGTM.com

new alerts:

  • 1 for Comparison result is always the same

fixed alerts:

  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
  • 1 for Non-virtual destructor in base class
  • 1 for Implicit string concatenation in a list

@lgtm-com
Copy link

lgtm-com bot commented Oct 28, 2020

This pull request fixes 3 alerts when merging 04b6db3 into 01020be - view on LGTM.com

fixed alerts:

  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
  • 1 for Non-virtual destructor in base class
  • 1 for Implicit string concatenation in a list

@maxscheurer maxscheurer merged commit a968ac4 into master Oct 28, 2020
@maxscheurer maxscheurer deleted the fmmgen branch October 28, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant