fix: always set header horizontal padding #81
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When use with
Header.Default
, ItWhen using
OptionView
orStateView
and setting theHeader
, there is a problem when handling the header spacing, which causes the header to be too close to the left border, as shown below:Related codes:
sheets-compose-dialogs/option/src/main/java/com/maxkeppeler/sheets/option/OptionView.kt
Lines 74 to 75 in 02195fa
sheets-compose-dialogs/core/src/main/java/com/maxkeppeker/sheets/core/views/base/FrameBase.kt
Lines 95 to 100 in 02195fa
Therefore, a fixed spacing is forced to be set for the header processing part in
FrameBase
to resolve this problem.Follow-up solution: You can try to expose the content spacing setting in the header. Like the following: