(Clock) Update and improve clock tests

maxkeppeler · Apr 19, 2023 · d8e374a · d8e374a
1 parent 5c420c5
commit d8e374a
Showing 1 changed file with 267 additions and 13 deletions.
diff --git a/clock/src/androidTest/java/com/maxkeppeler/sheets/clock/functional/ClockViewTests.kt b/clock/src/androidTest/java/com/maxkeppeler/sheets/clock/functional/ClockViewTests.kt
@@ -19,6 +19,7 @@ package com.maxkeppeler.sheets.clock.functional
 
 import androidx.compose.material3.ExperimentalMaterial3Api
 import androidx.compose.ui.test.assertIsEnabled
+import androidx.compose.ui.test.assertIsNotEnabled
 import androidx.compose.ui.test.junit4.createComposeRule
 import androidx.compose.ui.test.performClick
 import androidx.test.ext.junit.runners.AndroidJUnit4
@@ -45,7 +46,7 @@ class ClockViewTests {
  val rule = createComposeRule()
 
  @Test
- fun clockView24HourFormatSelectionSuccess() {
+ fun clockView_12HourFormat_amSelection_success() {
  val testTime = LocalTime.of(10, 30)
  var selectedTime: LocalTime? = null
  rule.setContentAndWaitForIdle {
@@ -54,7 +55,7 @@ class ClockViewTests {
  selection = ClockSelection.HoursMinutes { hours, minutes ->
  selectedTime = LocalTime.of(hours, minutes)
  },
- config = ClockConfig(is24HourFormat = true)
+ config = ClockConfig(is24HourFormat = false)
  )
  }
  listOf(1, 0, 3, 0).forEach {
@@ -63,13 +64,17 @@ class ClockViewTests {
  delay(Constants.DEBOUNCE_KEY_CLICK_DURATION)
  }
  }
+ runBlocking {
+ rule.onNodeWithTags(TestTags.CLOCK_12_HOUR_FORMAT, 0).performClick()
+ delay(Constants.DEBOUNCE_KEY_CLICK_DURATION)
+ }
  rule.onPositiveButton().performClick()
  assert(selectedTime == testTime)
  }
 
  @Test
- fun clockView12HourFormatAmSelectionSuccess() {
- val testTime = LocalTime.of(10, 30)
+ fun clockView_12HourFormat_pmSelection_success() {
+ val testTime = LocalTime.of(20, 30)
  var selectedTime: LocalTime? = null
  rule.setContentAndWaitForIdle {
  ClockView(
@@ -80,55 +85,304 @@ class ClockViewTests {
  config = ClockConfig(is24HourFormat = false)
  )
  }
- listOf(1, 0, 3, 0).forEach {
+ listOf(0, 8, 3, 0).forEach {
  runBlocking {
  rule.onNodeWithTags(TestTags.KEYBOARD_KEY, it).performClick()
  delay(Constants.DEBOUNCE_KEY_CLICK_DURATION)
  }
  }
+ runBlocking {
+ rule.onNodeWithTags(TestTags.CLOCK_12_HOUR_FORMAT, 1).performClick()
+ delay(Constants.DEBOUNCE_KEY_CLICK_DURATION)
+ }
+ rule.onPositiveButton().performClick()
+ assert(selectedTime == testTime)
+ }
+
+ @Test
+ fun clockView_12HourFormat_selectionAlwaysValid() {
+ rule.setContentAndWaitForIdle {
+ ClockView(
+ useCaseState = UseCaseState(visible = true),
+ selection = ClockSelection.HoursMinutes { _, _ -> },
+ )
+ }
+ rule.onPositiveButton().assertIsEnabled()
+ }
+
+ @Test
+ fun clockView_12HourFormat_boundaries_within() {
+ val testTime = LocalTime.of(10, 30)
+ var selectedTime: LocalTime? = null
+ rule.setContentAndWaitForIdle {
+ ClockView(
+ useCaseState = UseCaseState(visible = true),
+ selection = ClockSelection.HoursMinutes { hours, minutes ->
+ selectedTime = LocalTime.of(hours, minutes)
+ },
+ config = ClockConfig(
+ boundary = LocalTime.of(9, 0)..LocalTime.of(11, 0),
+ is24HourFormat = false
+ )
+ )
+ }
  runBlocking {
  rule.onNodeWithTags(TestTags.CLOCK_12_HOUR_FORMAT, 0).performClick()
  delay(Constants.DEBOUNCE_KEY_CLICK_DURATION)
+ listOf(1, 0, 3, 0).forEach {
+ rule.onNodeWithTags(TestTags.KEYBOARD_KEY, it).performClick()
+ delay(Constants.DEBOUNCE_KEY_CLICK_DURATION)
+ }
  }
+ rule.onPositiveButton().assertIsEnabled()
  rule.onPositiveButton().performClick()
  assert(selectedTime == testTime)
  }
 
  @Test
- fun clockView12HourFormatPmSelectionSuccess() {
- val testTime = LocalTime.of(20, 30)
+ fun clockView_12HourFormat_boundaries_outside() {
+ rule.setContentAndWaitForIdle {
+ ClockView(
+ useCaseState = UseCaseState(visible = true),
+ selection = ClockSelection.HoursMinutes { hours, minutes -> },
+ config = ClockConfig(
+ boundary = LocalTime.of(1, 0)..LocalTime.of(11, 0),
+ is24HourFormat = false
+ )
+ )
+ }
+
+ runBlocking {
+ listOf(1, 2, 0, 0).forEach {
+ rule.onNodeWithTags(TestTags.KEYBOARD_KEY, it).performClick()
+ delay(Constants.DEBOUNCE_KEY_CLICK_DURATION)
+ }
+ rule.onNodeWithTags(TestTags.CLOCK_12_HOUR_FORMAT, 0).performClick()
+ delay(Constants.DEBOUNCE_KEY_CLICK_DURATION)
+ }
+ rule.onPositiveButton().assertIsNotEnabled()
+ }
+
+ @Test
+ fun clockView_12HourFormat_defaultTime_setCorrectly() {
+ val defaultTime = LocalTime.of(10, 30)
  var selectedTime: LocalTime? = null
  rule.setContentAndWaitForIdle {
  ClockView(
  useCaseState = UseCaseState(visible = true),
  selection = ClockSelection.HoursMinutes { hours, minutes ->
  selectedTime = LocalTime.of(hours, minutes)
  },
- config = ClockConfig(is24HourFormat = false)
+ config = ClockConfig(
+ defaultTime = defaultTime,
+ is24HourFormat = false
+ )
  )
  }
- listOf(0, 8, 3, 0).forEach {
+ rule.onPositiveButton().performClick()
+ assert(selectedTime == defaultTime)
+ }
+
+ @Test
+ fun clockView_12HourFormat_defaultTime_notInBoundary_throwsException() {
+ val defaultTime = LocalTime.of(10, 30)
+ val boundary = LocalTime.of(11, 0)..LocalTime.of(12, 0)
+ val result = runCatching {
+ rule.setContentAndWaitForIdle {
+ ClockView(
+ useCaseState = UseCaseState(visible = true),
+ selection = ClockSelection.HoursMinutes { _, _ -> },
+ config = ClockConfig(
+ defaultTime = defaultTime,
+ boundary = boundary,
+ is24HourFormat = false
+ )
+ )
+ }
+ }
+ assert(result.isFailure)
+ }
+
+ @Test
+ fun clockView_12HourFormat_boundary_inverted_throwsException() {
+ val result = runCatching {
+ rule.setContentAndWaitForIdle {
+ ClockView(
+ useCaseState = UseCaseState(visible = true),
+ selection = ClockSelection.HoursMinutes { _, _ -> },
+ config = ClockConfig(
+ boundary = LocalTime.of(10, 0)..LocalTime.of(5, 0),
+ is24HourFormat = false
+ ),
+ )
+ }
+ }
+ assert(result.isFailure)
+ }
+
+ @Test
+ fun clockView_12HourFormat_boundary_startBoundaryInclusive() {
+ rule.setContentAndWaitForIdle {
+ ClockView(
+ useCaseState = UseCaseState(visible = true),
+ selection = ClockSelection.HoursMinutes { hours, minutes ->
+ },
+ config = ClockConfig(
+ boundary = LocalTime.of(5, 30)..LocalTime.of(6, 0),
+ is24HourFormat = false
+ ),
+ )
+ }
+ listOf(5, 3, 0).forEach {
+ runBlocking {
+ rule.onNodeWithTags(TestTags.KEYBOARD_KEY, it).performClick()
+ delay(Constants.DEBOUNCE_KEY_CLICK_DURATION)
+ }
+ runBlocking {
+ rule.onNodeWithTags(TestTags.CLOCK_12_HOUR_FORMAT, 0).performClick()
+ delay(Constants.DEBOUNCE_KEY_CLICK_DURATION)
+ }
+ }
+ rule.onPositiveButton().assertIsEnabled()
+ }
+
+ @Test
+ fun clockView_12HourFormat_boundary_endBoundaryInclusive() {
+ rule.setContentAndWaitForIdle {
+ ClockView(
+ useCaseState = UseCaseState(visible = true),
+ selection = ClockSelection.HoursMinutes { hours, minutes ->
+ },
+ config = ClockConfig(
+ boundary = LocalTime.of(5, 30)..LocalTime.of(6, 0),
+ is24HourFormat = false
+ ),
+ )
+ }
+ listOf(6, 0, 0).forEach {
  runBlocking {
  rule.onNodeWithTags(TestTags.KEYBOARD_KEY, it).performClick()
  delay(Constants.DEBOUNCE_KEY_CLICK_DURATION)
  }
  }
  runBlocking {
- rule.onNodeWithTags(TestTags.CLOCK_12_HOUR_FORMAT, 1).performClick()
+ rule.onNodeWithTags(TestTags.CLOCK_12_HOUR_FORMAT, 0).performClick()
  delay(Constants.DEBOUNCE_KEY_CLICK_DURATION)
  }
+ rule.onPositiveButton().assertIsEnabled()
+ }
+
+ @Test
+ fun clockView_24HourFormat_selection_success() {
+ val testTime = LocalTime.of(10, 30)
+ var selectedTime: LocalTime? = null
+ rule.setContentAndWaitForIdle {
+ ClockView(
+ useCaseState = UseCaseState(visible = true),
+ selection = ClockSelection.HoursMinutes { hours, minutes ->
+ selectedTime = LocalTime.of(hours, minutes)
+ },
+ config = ClockConfig(is24HourFormat = true)
+ )
+ }
+ listOf(1, 0, 3, 0).forEach {
+ runBlocking {
+ rule.onNodeWithTags(TestTags.KEYBOARD_KEY, it).performClick()
+ delay(Constants.DEBOUNCE_KEY_CLICK_DURATION)
+ }
+ }
  rule.onPositiveButton().performClick()
  assert(selectedTime == testTime)
  }
 
  @Test
- fun clockViewSelectionAlwaysValid() {
+ fun clockView_24HourFormat_unsupportedConfigurations_throwsException() {
+ val result = runCatching {
+ rule.setContentAndWaitForIdle {
+ ClockView(
+ useCaseState = UseCaseState(visible = true),
+ selection = ClockSelection.HoursMinutes { _, _ -> },
+ config = ClockConfig(
+ defaultTime = LocalTime.of(4, 0),
+ boundary = LocalTime.of(5, 0)..LocalTime.of(10, 0),
+ is24HourFormat = true,
+ ),
+ )
+ }
+ }
+ assert(result.isFailure)
+ }
+
+ @Test
+ fun clockView_24HourFormat_boundaries_within() {
+ val testTime = LocalTime.of(10, 30)
+ var selectedTime: LocalTime? = null
  rule.setContentAndWaitForIdle {
  ClockView(
  useCaseState = UseCaseState(visible = true),
- selection = ClockSelection.HoursMinutes { _, _ -> },
+ selection = ClockSelection.HoursMinutes { hours, minutes ->
+ selectedTime = LocalTime.of(hours, minutes)
+ },
+ config = ClockConfig(
+ boundary = LocalTime.of(9, 0)..LocalTime.of(11, 0),
+ is24HourFormat = true
+ )
  )
  }
+ listOf(1, 0, 3, 0).forEach {
+ runBlocking {
+ rule.onNodeWithTags(TestTags.KEYBOARD_KEY, it).performClick()
+ delay(Constants.DEBOUNCE_KEY_CLICK_DURATION)
+ }
+ }
  rule.onPositiveButton().assertIsEnabled()
+ rule.onPositiveButton().performClick()
+ assert(selectedTime == testTime)
+ }
+
+ @Test
+ fun clockView_24HourFormat_boundary_singleValue() {
+ val testTime = LocalTime.of(8, 0)
+ var selectedTime: LocalTime? = null
+ rule.setContentAndWaitForIdle {
+ ClockView(
+ useCaseState = UseCaseState(visible = true),
+ selection = ClockSelection.HoursMinutes { hours, minutes ->
+ selectedTime = LocalTime.of(hours, minutes)
+ },
+ config = ClockConfig(
+ is24HourFormat = true,
+ boundary = LocalTime.of(8, 0)..LocalTime.of(8, 0),
+ ),
+ )
+ }
+ listOf(8, 0).forEach {
+ runBlocking {
+ rule.onNodeWithTags(TestTags.KEYBOARD_KEY, it).performClick()
+ delay(Constants.DEBOUNCE_KEY_CLICK_DURATION)
+ }
+ }
+ rule.onPositiveButton().performClick()
+ assert(selectedTime == testTime)
+ }
+
+ @Test
+ fun clockView_24HourFormat_boundary_correctlyLimitsSelection() {
+ val boundary = LocalTime.of(11, 0)..LocalTime.of(12, 0)
+ rule.setContentAndWaitForIdle {
+ ClockView(
+ useCaseState = UseCaseState(visible = true),
+ selection = ClockSelection.HoursMinutes { hours, minutes ->
+ },
+ config = ClockConfig(boundary = boundary, is24HourFormat = true)
+ )
+ }
+ listOf(1, 0, 0, 0).forEach {
+ runBlocking {
+ rule.onNodeWithTags(TestTags.KEYBOARD_KEY, it).performClick()
+ delay(Constants.DEBOUNCE_KEY_CLICK_DURATION)
+ }
+ }
+ rule.onPositiveButton().assertIsNotEnabled()
  }
-}
+}