Use string res

maxkeppeler · Jan 23, 2023 · 4054735 · 4054735
1 parent 61e9f66
commit 4054735
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 7 deletions.
diff --git a/clock/src/main/java/com/maxkeppeler/sheets/clock/ClockView.kt b/clock/src/main/java/com/maxkeppeler/sheets/clock/ClockView.kt
@@ -71,7 +71,6 @@ fun ClockView(
  onGroupClick = clockState::onValueGroupClick,
  onAm = clockState::onChange12HourFormatValue,
  )
-
  KeyboardComponent(
  modifier = Modifier.weight(1f, false),
  config = config,

diff --git a/clock/src/main/java/com/maxkeppeler/sheets/clock/views/TimeValueComponent.kt b/clock/src/main/java/com/maxkeppeler/sheets/clock/views/TimeValueComponent.kt
@@ -147,7 +147,11 @@ internal fun LandscapeTimeValueComponent(
  verticalArrangement = verticalArrangement,
  ) {
 
- val labels = listOf("Hours", "Minutes", "Seconds")
+ val labelRes = listOf(
+ R.string.scd_clock_dialog_hours,
+ R.string.scd_clock_dialog_minutes,
+ R.string.scd_clock_dialog_seconds,
+ )
 
  Column(
  modifier = Modifier
@@ -188,11 +192,10 @@ internal fun LandscapeTimeValueComponent(
  Spacer(modifier = Modifier.width(dimensionResource(RC.dimen.scd_small_150)))
 
  Text(
- text = labels[currentGroupIndex],
+ text = stringResource(labelRes[currentGroupIndex]),
  style = MaterialTheme.typography.labelSmall,
  )
 
-
  }
  }
  }

diff --git a/clock/src/main/res/values-de-rDE/strings.xml b/clock/src/main/res/values-de-rDE/strings.xml
@@ -10,4 +10,8 @@
  <string name="scd_clock_dialog_next_value" translatable="true">Nächster Wert</string>
  <string name="scd_clock_dialog_previous_value" translatable="true">Letzter Wert</string>
 
+ <string name="scd_clock_dialog_hours">Stunden</string>
+ <string name="scd_clock_dialog_minutes">Minuten</string>
+ <string name="scd_clock_dialog_seconds">Sekunden</string>
+
 </resources>
diff --git a/clock/src/main/res/values/strings.xml b/clock/src/main/res/values/strings.xml
@@ -10,5 +10,7 @@
  <string name="scd_clock_dialog_pm" translatable="true">PM</string>
  <string name="scd_clock_dialog_next_value" translatable="true">Next value</string>
  <string name="scd_clock_dialog_previous_value" translatable="true">Previous value</string>
-
+ <string name="scd_clock_dialog_hours">Hours</string>
+ <string name="scd_clock_dialog_minutes">Minutes</string>
+ <string name="scd_clock_dialog_seconds">Seconds</string>
 </resources>
diff --git a/core/src/main/java/com/maxkeppeker/sheets/core/views/base/FrameBase.kt b/core/src/main/java/com/maxkeppeker/sheets/core/views/base/FrameBase.kt
@@ -55,8 +55,6 @@ fun FrameBase(
  val layoutDirection = LocalLayoutDirection.current
  val configuration = LocalConfiguration.current
 
-
-
  Column(
  modifier = Modifier.wrapContentHeight()
  ) {