Update environment variable naming convention #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change
In this PR, there is a breaking change because the original solution doesn't work in real environment.
In bash, it is not possible to use "-" as environment name, so the new rules are
-will turn into_ex:
plan-name-with-dashthe env will be
PLAN_NAME_WITH_DASH__SECTION_PROPERTYSpecial Note
The secret needs to be in the config with a placeholder
eg:
Viper has a issue to handle this spf13/viper#761
It can handle it in version 1.8.1 but it also introduce another issue.
so we stick with version 1.6.0 and see what to do next.