Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple content per slides. #1

Merged
merged 3 commits into from
Nov 28, 2011
Merged

Multiple content per slides. #1

merged 3 commits into from
Nov 28, 2011

Conversation

DjebbZ
Copy link
Contributor

@DjebbZ DjebbZ commented Sep 8, 2011

Hello max-power,

As we're using your plugin to create a slide in a mobile app, we're in the need of showing multiple content per slide. Instead of doing this stuff locally, I wanted to share it with you (open-source spirit :)

Basically the changes are the following :
I added an option to the plugin, visible_slides, that defaults to one so the behavior of the swipeslide plugin doesn't change and doesn't break the api. When visible_slides > 1, each slide displays "visible_slides" number of slide in each "screen". I updated the code so that the navigation links leads to each "screen" instead of each slide. I changed some calculations to match this change. And I added some comments, as they helped me understand the code.
I also added a basic new demo file, multi.html, and resized the sample images for this demo.

Before merging it to the master branch, my changes need to work with a vertical orientation (it doesn't) and with a 3d slider (untested).

I hope you will like the changes, and will merge them. I can volunteer for further work, especially the vertical and 3d stuff. Sorry if the changes are a bit messy.

max-power added a commit that referenced this pull request Nov 28, 2011
Multiple content per slides.
@max-power max-power merged commit ff6aa5b into max-power:master Nov 28, 2011
@max-power
Copy link
Owner

Thanks a lot. Awesome work - especially the documentation.
And excuse the late reply.

@DjebbZ
Copy link
Contributor Author

DjebbZ commented Nov 28, 2011

Happy it has been useful :) Very happy about the fact you liked the documentation :) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants