Skip to content

Commit

Permalink
more expression error in step explanation
Browse files Browse the repository at this point in the history
  • Loading branch information
zephyrz73 committed Aug 31, 2020
1 parent c331d7c commit 0c1161e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ jobs:
- name: Preview infrastructure
if: ${{ github.event_name == 'pull_request' }}
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
AWS_SESSION_TOKEN: ${{ secrets.AWS_SESSION_TOKEN }}
PULUMI_STACK: ${{ secrets.PULUMI_STACK}}
PULUMI_ACCESS_TOKEN: ${{ secrets.PULUMI_ACCESS_TOKEN }}
run:
Expand All @@ -40,9 +37,6 @@ jobs:
- name: Deploy infrastructure
if: ${{ github.event_name == 'push' }}
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
AWS_SESSION_TOKEN: ${{ secrets.AWS_SESSION_TOKEN }}
PULUMI_STACK: ${{ secrets.PULUMI_STACK}}
PULUMI_ACCESS_TOKEN: ${{ secrets.PULUMI_ACCESS_TOKEN }}
run: pulumi up --yes --cwd infrastructure -s "${{ secrets.PULUMI_STACK }}"
Expand Down
6 changes: 3 additions & 3 deletions aws-ts-netlify-cms-and-oauth/cms/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Special thanks to the template provided by [@talves](https://github.com/ADARTA/n

The infrastructure folder contain Pulumi code of deploying this CMS app onto the AWS S3, speeding up using AWS CloudFront, and certificate creation using AWS Certificate Manager. The general idea is deploy the CMS application as a static website onto the AWS. We already have a [Pulumi's static website creation example](https://github.com/pulumi/examples/tree/master/aws-ts-static-website) with explanation provided.

The infrastructure takes three argument: pathToWebsiteContents,targetDomain, certificateArn.
The infrastructure requires three stack configuration properties: `pathToWebsiteContents`, `targetDomain`, `certificateArn`.
- pathToWebsiteContents
- The path to the builded content of this React Website app.
- Run a yarn build will create a build folder which contains the builded file and we should pass the directory of the build folder to this variable.
Expand Down Expand Up @@ -138,8 +138,8 @@ $ pulumi up
- create a new branch at docs repo
- open a pull request
- make initial commit to the branch
- add tag to the commit says "drafts"
- produce a card at the drafts column on the editorial workflow page (mentioned in 5. 6.)
- Add tag to the PR that indicates that it is a "draft"
- Adds a card in the drafts column on the editorial workflow page (more on the workflow UI below)

5. Click the Back button to go back to the collections page and clicking the **Workflow** button would bring out the editorial workflow

Expand Down

0 comments on commit 0c1161e

Please sign in to comment.