-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why do you not use json output for sat devices? #25
Labels
enhancement
New feature or request
Milestone
Comments
PRs are welcome! |
ngosang
added a commit
to ngosang/prometheus-smartctl
that referenced
this issue
Jul 29, 2022
ngosang
added a commit
to ngosang/prometheus-smartctl
that referenced
this issue
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
for all but sat devices you use "json" output like this:
prometheus-smartctl/smartprom.py
Line 92 in 3fbd7bb
Why dont you use it for sat? Would that be an improvement?
prometheus-smartctl/smartprom.py
Line 61 in 3fbd7bb
The text was updated successfully, but these errors were encountered: