Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3 updates; don't automatically configure logging #42

Merged
merged 1 commit into from
Feb 20, 2022
Merged

Python 3 updates; don't automatically configure logging #42

merged 1 commit into from
Feb 20, 2022

Conversation

dean-shaff
Copy link

Two small updates:

  • Don't inherit from object in classes; this is unnecessary in Python3
  • Don't automatically configure logging. Configuring logging inside a library leads to unexpected results when end users try to configure logging on their own.

@mattpodolak mattpodolak self-requested a review February 20, 2022 17:10
mattpodolak
mattpodolak approved these changes Feb 20, 2022
View reviewed changes
Copy link
Owner

@mattpodolak mattpodolak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! thanks @dean-shaff

@mattpodolak mattpodolak merged commit 055f6f3 into mattpodolak:master Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattpodolak mattpodolak mattpodolak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dean-shaff @mattpodolak