Support macOS's Terminal.app #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks Good. I don't have mac but probably it seems working fine. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
macOS's Terminal.app doesn't support true color and longcat -pixterm shows broken cat:
Fix
Terminal.app sets the environment variable TERM_PROGRAM to "Apple_Terminal".
Use 8bit (256) color escape sequence in such case.
Limitation
If the user force to use same logic on iTerm2 (alternative for macOS bundled Terminal.app) with Solarized theme shows a slightly broken cat:
I think this is caused by the theme changes color palette. The Default behavior on iTerm2 is kept intact on this fix.