Support theme and image directory #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattn
reviewed
Sep 15, 2019
mattn
reviewed
Sep 16, 2019
main.go
Outdated
| func loadImage(fs http.FileSystem, n string) (image.Image, error) { | ||
| f, err := fs.Open(n) | ||
| if err != nil { | ||
| log.Fatal(err) | ||
| log.Fatal(fmt.Errorf("theme file does not open: %s", n)) |
There was a problem hiding this comment.
Thanks. please fix this part too. (Yes, I know this part never passed)
return nil, fmt.Errorf("theme file does not open: %s", n)
There was a problem hiding this comment.
I tried to fix it ( tobynet/longcat@8c8f2c4 )
There was a problem hiding this comment.
I consider necessary for error handlings in loadImage too.
e.g. -t wlongcat (/themes/wlongcat/ may not exist in statik.go)
Before:
$ go run main.go -n 2 -H -t wlongcat
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x鈻堚枅鈻堚枅鈻堚枅鈻堚枅]
goroutine 1 [running]:
main.main()
鈻堚枅鈻堚枅鈻堚枅鈻堚枅鈻堚枅鈻堚枅鈻堚枅鈻堚枅鈻堚枅鈻堚枅鈻堚枅鈻堚枅鈻堚枅鈻堚枅鈻堚枅鈻堚枅鈻堚枅鈻堚枅鈻堚枅鈻堚枅鈻堚枅鈻堚枅longcat/main.go:151 +0x4d5
exit status 2After: (little readable)
$ go run main.go -n 2 -H -t wlongcat
2019/鈻堚枅/鈻堚枅 鈻堚枅鈻堚枅鈻堚枅 theme file does not open: /themes/wlongcat/data01.png
exit status 1
mattn
reviewed
Sep 16, 2019
|
Totally LGTM except I pointed. |
7 tasks
Cosmetic changes?
|
Good to merge for me. Do you have something else to do? |
|
Thank you. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
馃惗馃殏 We need to support more animals like "longdog" and "locomotive", etc.
-toption for themes. (embedded only)-doption for image directory.longcat, the current 馃悎.tacgnol.Example
Comming soon...
The dark-mode is already available. ( tobynet@bc3cc62 )