Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace namedValue with driver.NamedValue to avoid copying exec/query args #1128

Merged
merged 1 commit into from
Feb 11, 2023

Conversation

charlievieth
Copy link
Contributor

This commit replaces the namedValue type with driver.NamedValue this eliminates the need to create copy of the arguments slice in {SQLiteConn,SQLiteStmt}.{QueryContext,ExecContext}.

The driver.NamedValue type was added in 2016 (golang/go@707a833) so there shouldn't be any compatibility issues.

@rittneje
Copy link
Collaborator

rittneje commented Feb 3, 2023

LGTM. (driver.NamedValue was added in Go 1.8 specifically.) @mattn any concerns?

@mattn
Copy link
Owner

mattn commented Feb 3, 2023

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2023

Codecov Report

Base: 46.80% // Head: 46.59% // Decreases project coverage by -0.22% ⚠️

Coverage data is based on head (c1f721e) compared to base (1603038).
Patch coverage: 57.14% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1128      +/-   ##
==========================================
- Coverage   46.80%   46.59%   -0.22%     
==========================================
  Files          12       12              
  Lines        1534     1526       -8     
==========================================
- Hits          718      711       -7     
+ Misses        673      672       -1     
  Partials      143      143              
Impacted Files Coverage Δ
sqlite3.go 52.64% <40.00%> (ø)
sqlite3_go18.go 77.77% <100.00%> (-4.58%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants