fix(week-view): allDayEventsLabelTemplate rendered outside of container #1708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattlewis92
approved these changes
Apr 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1708 +/- ##
=======================================
Coverage 97.49% 97.49%
=======================================
Files 39 39
Lines 678 678
Branches 143 143
=======================================
Hits 661 661
Misses 1 1
Partials 16 16 ☔ View full report in Codecov by Sentry. |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mattlewis92,
Thank you for the fantastic work you've done on the angular-calendar. I appreciate the effort you've put into maintaining it.
I noticed a minor issue. The allDayEventsLabelTemplate was rendered outside the .cal-time-label-column element. I've made a small adjustment to ensure that the template is rendered within the intended div element.
Best regards,
Michael