Improving selectors of Textbox component

[M-ZubairAhmed]

Summary

• Moved makeGetProfilesInChannel & makeAddLastViewAtToProfiles from Textbox to AtMentionProvider - @jwilander
• Created new getAllDmChannels selector
• Improved memoization of makeAddLastViewAtToProfiles selector

Ticket Link

Related Pull Requests

N/A

Release Note

Improved perceived typing performance by moving heavy code around and effective memoization related to the textbox component.

[mm-cloud-bot]

@M-ZubairAhmed: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

[mm-cloud-bot]

@M-ZubairAhmed: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

[jwilander]

Test server with commit 284ac35 https://webapp-perf.test.mattermost.cloud/

[jgilliam17]

@jwilander Tested autocomplete on the test server https://webapp-perf.test.mattermost.cloud/
Mention autocomplete looks good overall tested main channel, rhs, description, edit modal.
When loading avatars there is a bit of slowness, but it doesn't differ that much from what I can see on daily. See video.

autocomplete.mov

[jgilliam17]

/e2e-test

[mattermod]

Triggering e2e testing with options:
<nil>

[mattermod]

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/152363

[jwilander]

Awesome, thanks @jgilliam17. Looks good to me.

[jgilliam17]

Apologies @M-ZubairAhmed I meant to comment, not hit approve
Waiting for E2E report, will approve shortly after I check the report

[jgilliam17]

E2E report looks good, no PR related failures ( master for comparison)

[jwilander]

/cherry-pick release-6.3

[mattermod]

Cherry pick is scheduled.

[mattermod]

Error trying doing the automated Cherry picking. Please do this manually

+++ Updating remotes...
Fetching upstream
Failed to add the RSA host key for IP address '140.82.114.3' to the list of known hosts (/app/.ssh/known_hosts).
From github.com:mattermost/mattermost-webapp
   074560361..762b8581c  MM-36190_permalink-nested-previews -> upstream/MM-36190_permalink-nested-previews
   0622ce200..17d45b574  MM-36442-more-actions-restructure -> upstream/MM-36442-more-actions-restructure
 * [new branch]          MM-40148_introduce-threadsOnly-queryparam -> upstream/MM-40148_introduce-threadsOnly-queryparam
 * [new branch]          MM-40306               -> upstream/MM-40306
   cb65616dc..aabf97fec  MM-40415               -> upstream/MM-40415
 * [new branch]          MM-41671/support-email -> upstream/MM-41671/support-email
 * [new branch]          MM-41710               -> upstream/MM-41710
 * [new branch]          MM-41800               -> upstream/MM-41800
 * [new branch]          MM-41851               -> upstream/MM-41851
 * [new branch]          MM-41955_reduce-user-state-changes -> upstream/MM-41955_reduce-user-state-changes
 * [new branch]          channel-loop-logs      -> upstream/channel-loop-logs
   7d65f671d..81e2d35b9  cloud                  -> upstream/cloud
   61170d826..b265dec54  custom_groups          -> upstream/custom_groups
 * [new branch]          dm-fixes               -> upstream/dm-fixes
 * [new branch]          dm-optimization2       -> upstream/dm-optimization2
   82b3ea959..bc466ef4a  emoji-picker-virtualized -> upstream/emoji-picker-virtualized
   256120225..b39263662  growth-spike/dashboard-view-controller -> upstream/growth-spike/dashboard-view-controller
 * [new branch]          interactive-dialog-password-autocomplete-off -> upstream/interactive-dialog-password-autocomplete-off
   a8a1394bf..33d829a46  master                 -> upstream/master
 * [new branch]          new-signup-screens     -> upstream/new-signup-screens
 * [new branch]          npm-ci-in-makefile     -> upstream/npm-ci-in-makefile
 * [new branch]          perf-quicker-rerender  -> upstream/perf-quicker-rerender
   1bed8412a..ef9d0e473  productivity/MM-29137_post-inline-editing -> upstream/productivity/MM-29137_post-inline-editing
   94a4af59e..c4bc81474  release-6.3            -> upstream/release-6.3
 * [new branch]          single-team-in-products -> upstream/single-team-in-products
 * [new branch]          use-case-onboarding-trigger-e2e -> upstream/use-case-onboarding-trigger-e2e
 * [new branch]          use-case-onboarding-wizard-centering -> upstream/use-case-onboarding-wizard-centering
 * [new tag]             cloud-2022-02-16-1     -> cloud-2022-02-16-1
 * [new tag]             v6.4.0                 -> v6.4.0
Fetching origin
Failed to add the RSA host key for IP address '140.82.114.3' to the list of known hosts (/app/.ssh/known_hosts).
+++ Updating remotes done...
+++ Creating local branch automated-cherry-pick-of-mattermost-webapp-#9831-upstream-release-6.3-1645143035
Switched to a new branch 'automated-cherry-pick-of-mattermost-webapp-#9831-upstream-release-6.3-1645143035'
Branch 'automated-cherry-pick-of-mattermost-webapp-#9831-upstream-release-6.3-1645143035' set up to track remote branch 'release-6.3' from 'upstream'.

+++ About to attempt cherry pick of PR #9831 with merge commit be597b7f7792bd2953606f4a5c4a6caaf677154e.

error: could not apply be597b7f7... Improving selectors of Textbox component (#9831)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

+++ Conflicts detected:

UU packages/mattermost-redux/src/selectors/entities/utils.ts
Aborting.

+++ Aborting in-progress git cherry-pick.

+++ Returning you to the master branch and cleaning up.