MM-42320 Remove excess keyboard listeners from post components

[hmhealey]

Similar to #9707, each post renders a keyboard handler to detect whether or not alt is pressed because that switches the cursor to show that you can click on a post to mark it as unread. This happens once for each post on the screen which can add a bit of processing time when a user is typing a message.

By only registering those handlers when the user hovers over a post, we ensure that we only have one registered at a time at most which should hopefully speed up typing performance slightly.

Ticket Link

https://mattermost.atlassian.net/browse/MM-41320

Related Pull Requests

#9707

Screenshots

Here's a before and after with log statements added to the listeners.

Before:

before.mov

After:

after.mov

Release Note

Reduce the number of post components listening for keyboard events

[michelengelen]

LGTM ... although I feel like all of these components do basically the same thing and we can probably extract it into one component that is being used anywhere a text input is needed.

WDYT @hmhealey @matthewbirtch ?

PS: this is definitely OOS for this PR, but we should definitely think about it!

[M-ZubairAhmed]

🆗 It looks good to me. Thank you

[hmhealey]

Yeah, that's 100% something I'd like to do. The post components (and post textboxes) have so much duplicated code, but they're not something we've had a chance to get to yet. We do have a goal for the year to refactor some areas of heavy tech debt, and those are both high up for me on that list.

Alternatively, I feel like that could make a good custom hook, but we can't do that either until these components are rewritten to be functional

[jgilliam17]

//update-branch

[jgilliam17]

/e2e-test

[mattermod]

Triggering e2e testing with options:
<nil>

[mattermod]

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/110147

[jgilliam17]

Thanks @M-ZubairAhmed
Tested, looks good to merge.

• Verified cursor turns to a hand pointer when holding alt and hovering over a post. Additionally, when holding alt key while the mouse cursor is not hovering over any post, the cursor is not changing to hand pointer.
• E2E report looks good, no PR related failures.

[mm-cloud-bot]

Test server destroyed

[amyblais]

/cherry-pick release-6.3

[mattermod]

Cherry pick is scheduled.