Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-41159 - Remove free tier cloud final date to subscribe #9689

Merged
merged 4 commits into from
Jan 24, 2022
Merged

MM-41159 - Remove free tier cloud final date to subscribe #9689

merged 4 commits into from
Jan 24, 2022

Conversation

marianunez
Copy link
Member

@marianunez marianunez commented Jan 21, 2022 •
edited
Loading

Summary

Matttermost Cloud workspaces on the legacy free tier plan will be migrated to the new Cloud Freemium coming later this year. This PR removes the message with the date they would be retired which is no longer relevant.

Ticket Link

https://mattermost.atlassian.net/browse/MM-41159

Screenshots

Before

Screen Shot 2022-01-19 at 4 51 20 PM

After

Screen Shot 2022-01-23 at 5 55 24 PM

Release Note

NONE

@marianunez marianunez added the Setup Cloud + CWS Test Server Setup a test server linked to the CWS test portal label Jan 22, 2022
@marianunez marianunez removed the Setup Cloud + CWS Test Server Setup a test server linked to the CWS test portal label Jan 22, 2022
@mm-cloud-bot
Copy link

Test server destroyed

@marianunez marianunez added Setup Cloud + CWS Test Server Setup a test server linked to the CWS test portal and removed Setup Cloud + CWS Test Server Setup a test server linked to the CWS test portal labels Jan 22, 2022
@mm-cloud-bot
Copy link

Test server destroyed

@marianunez marianunez added Setup Cloud + CWS Test Server Setup a test server linked to the CWS test portal 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester and removed 2: Dev Review Requires review by a core commiter labels Jan 22, 2022
pvev
pvev reviewed Jan 24, 2022
View reviewed changes
i18n/en.json Outdated Show resolved Hide resolved
pvev
pvev reviewed Jan 24, 2022
View reviewed changes
i18n/pl.json Outdated Show resolved Hide resolved
pvev
pvev approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@pvev pvev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @marianunez :shipit:

@neallred
Copy link
Contributor

Code changes look good to me. How were the language changes generated? I see inconsistent treatment for the upToXUsers messages. Some of the languages have a change to the text, while others remove the string completely.

stevemudie
stevemudie reviewed Jan 24, 2022
View reviewed changes
Copy link
Contributor

@stevemudie stevemudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good here. I'll wait to see what comes of Nathaniel's concern before I approve it from QA.

@marianunez
Copy link
Member Author

How were the language changes generated? I see inconsistent treatment for the upToXUsers messages. Some of the languages have a change to the text, while others remove the string completely.

Given that the text change was to removing just the final part of the sentence I manually change the language texts and dropped the rest of the sentence but there were some languages I couldn't say for sure where the changes should happen. Officially on any text changes, we should remove the entry in the other languages so they can be re-translated. I'll do that to be consistent on all. Thanks for the call out on that 👍

@neallred
Copy link
Contributor

Officially on any text changes, we should remove the entry in the other languages so they can be re-translated

Ahh, good to know, I didn't realize that!

@marianunez marianunez removed the 2: Dev Review Requires review by a core commiter label Jan 24, 2022
@stevemudie stevemudie added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Jan 24, 2022
@marianunez marianunez added the 4: Reviews Complete All reviewers have approved the pull request label Jan 24, 2022
@marianunez marianunez merged commit 4ed0b69 into master Jan 24, 2022
@marianunez marianunez deleted the remove-date-legacy-cloud-free branch January 24, 2022 20:34
@mm-cloud-bot
Copy link

Test server destroyed

@amyblais amyblais added this to the v6.4.0 milestone Jan 25, 2022
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jan 25, 2022
@neallred neallred removed the Setup Cloud + CWS Test Server Setup a test server linked to the CWS test portal label Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stevemudie stevemudie stevemudie approved these changes

@pvev pvev pvev approved these changes

@jasonblais jasonblais jasonblais approved these changes

@neallred neallred neallred approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation QA Review Done release-note-none
Projects
None yet
Milestone
v6.4.0
Development

Successfully merging this pull request may close these issues.
7 participants
@marianunez @mm-cloud-bot @neallred @stevemudie @pvev @jasonblais @amyblais