Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Add workaround for mmjstool integrity check failing #9617

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

hmhealey
Copy link
Member

@hmhealey hmhealey commented Jan 5, 2022

Copies a workaround for the integrity check issue that we've had people reporting since we upgraded mmjstool

See mattermost/mattermost-plugin-playbooks#868 for more details

Release Note

NONE

@hmhealey hmhealey added the 2: Dev Review Requires review by a core commiter label Jan 5, 2022
@lieut-data
Copy link
Member

Thanks, @hmhealey! I ended up patching the first PR in https://github.com/mattermost/mattermost-plugin-playbooks/pull/940/files as we found the preinstall/postinstall hooks weren't reliable enough for use in this context. Would it make sense to include the changes from that PR as well?

@hmhealey
Copy link
Member Author

hmhealey commented Jan 6, 2022

Yep, I can add those changes to this PR. I forgot how flaky those hooks can be since they used to cause so many problems with mattermost-redux not building before

@lieut-data lieut-data added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Jan 7, 2022
@hmhealey hmhealey merged commit 4d7dc89 into master Jan 10, 2022
@hmhealey hmhealey deleted the hh_integrity-workaround branch January 10, 2022 14:48
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jan 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation release-note-none
Projects
None yet
5 participants