Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Mm 40360 channels save config error #9538

Merged
merged 2 commits into from
Feb 10, 2022
Merged

Mm 40360 channels save config error #9538

merged 2 commits into from
Feb 10, 2022

Conversation

hamzaMM
Copy link
Contributor

@hamzaMM hamzaMM commented Dec 14, 2021 •
edited by hanzei
Loading

Summary

Changing channel permissions with Team edition results in infinite loop

Ticket Link

https://mattermost.atlassian.net/browse/MM-40360)

Release Note

NONE

@hamzaMM hamzaMM added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Dec 14, 2021
@hamzaMM hamzaMM added this to the v6.2.0 milestone Dec 14, 2021
@hamzaMM hamzaMM self-assigned this Dec 14, 2021
@mm-cloud-bot
Copy link

@hamzaMM: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

2 similar comments
@mm-cloud-bot
Copy link

@hamzaMM: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

@mm-cloud-bot
Copy link

@hamzaMM: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

@amyblais amyblais modified the milestones: v6.2.0, v6.3.0 Dec 15, 2021
@amyblais amyblais mentioned this pull request Dec 23, 2021
Closed
@mattermod
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @aspleenic

@amyblais amyblais removed this from the v6.3.0 milestone Jan 10, 2022
@amyblais
Copy link
Member

Assigning to @mkraft as I believe someone would need to take over ownership of this PR from Hamza.

@amyblais amyblais removed the 2: Dev Review Requires review by a core commiter label Feb 10, 2022
@furqanmlk furqanmlk added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Feb 10, 2022
furqanmlk
furqanmlk approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@furqanmlk furqanmlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Working as expected. I have added before and after behaviour

Filmage.2022-02-10_220451.mp4

@furqanmlk furqanmlk removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Feb 10, 2022
@mm-cloud-bot
Copy link

Test server destroyed

@mkraft mkraft merged commit 40ae144 into mattermost:master Feb 10, 2022
@amyblais
Copy link
Member

/cherry-pick release-6.4

@mattermod
Copy link
Contributor

Cherry pick is scheduled.

@mattermost-build mattermost-build mentioned this pull request Feb 10, 2022
Merged
mattermost-build pushed a commit to mattermost-build/mattermost-webapp that referenced this pull request Feb 10, 2022
@hamzaMM @mattermost-build
Mm 40360 channels save config error (mattermost#9538)
5b7faeb 
* fixed error

* matched package-lock.json with master

Co-authored-by: Hamza Kazmi <[email protected]>
(cherry picked from commit 40ae144)
@mattermod mattermod added the CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone label Feb 10, 2022
@amyblais
Copy link
Member

/cherry-pick cloud

@mattermod
Copy link
Contributor

Cherry pick is scheduled.

@mattermost-build mattermost-build mentioned this pull request Feb 10, 2022
Merged
mattermost-build pushed a commit to mattermost-build/mattermost-webapp that referenced this pull request Feb 10, 2022
@hamzaMM @mattermost-build
Mm 40360 channels save config error (mattermost#9538)
5b00145 
* fixed error

* matched package-lock.json with master

Co-authored-by: Hamza Kazmi <[email protected]>
(cherry picked from commit 40ae144)
@amyblais amyblais added this to the v6.4.0 milestone Feb 10, 2022
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation Changelog/Not Needed Does not require a changelog entry and removed Changelog/Done Required changelog entry has been written labels Feb 10, 2022
mattermod pushed a commit that referenced this pull request Feb 10, 2022
@mattermost-build
Mm 40360 channels save config error (#9538) (#9789)
c01ceac 
Automatic Merge
mattermod pushed a commit that referenced this pull request Feb 10, 2022
@mattermost-build
Mm 40360 channels save config error (#9538) (#9790)
7d65f67 
Automatic Merge
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkraft mkraft mkraft approved these changes

@furqanmlk furqanmlk furqanmlk approved these changes

@BenCookie95 BenCookie95 BenCookie95 approved these changes

Assignees

@mkraft mkraft

Labels
Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation Lifecycle/1:stale release-note-none
Projects
None yet
Milestone
v6.4.0
7 participants
@hamzaMM @mm-cloud-bot @mattermod @amyblais @mkraft @furqanmlk @BenCookie95