Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

chore/MM-40271 : Remove fastclick library #9527

Merged
merged 1 commit into from
Dec 13, 2021
Merged

chore/MM-40271 : Remove fastclick library #9527

merged 1 commit into from
Dec 13, 2021

Conversation

M-ZubairAhmed
Copy link
Member

@M-ZubairAhmed M-ZubairAhmed commented Dec 13, 2021

Summary

  • Removed fastclick library from the app

Ticket Link

https://mattermost.atlassian.net/browse/MM-40271

Related Pull Requests

  • Has server changes (please link here)
  • Has mobile changes (please link here)

Screenshots

None

Release Note

NONE

@M-ZubairAhmed M-ZubairAhmed added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Dec 13, 2021
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@M-ZubairAhmed M-ZubairAhmed added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Dec 13, 2021
@mm-cloud-bot mm-cloud-bot removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Dec 13, 2021
@hmhealey hmhealey added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Dec 13, 2021
@M-ZubairAhmed M-ZubairAhmed removed the 2: Dev Review Requires review by a core commiter label Dec 13, 2021
Copy link
Contributor

@jgilliam17 jgilliam17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @M-ZubairAhmed
Tested, looks good to merge.

  • Verified buttons are working as expected in mobile webview; responsive to tap and click, no noticeable delay or lag.
  • E2E report looks good, no PR related failures

@jgilliam17 jgilliam17 added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Dec 13, 2021
@mm-cloud-bot
Copy link

Test server destroyed

@M-ZubairAhmed M-ZubairAhmed merged commit 0ef79f3 into master Dec 13, 2021
@M-ZubairAhmed M-ZubairAhmed deleted the MM-40271 branch December 13, 2021 20:09
@amyblais
Copy link
Member

/cherry-pick release-6.3

@mattermod
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit to mattermost-build/mattermost-webapp that referenced this pull request Dec 21, 2021
@mattermod mattermod added the CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone label Dec 21, 2021
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Dec 21, 2021
@amyblais amyblais added this to the v6.3.0 milestone Dec 21, 2021
mattermod pushed a commit that referenced this pull request Dec 21, 2021
cleferman pushed a commit to cleferman/mattermost-webapp that referenced this pull request Dec 21, 2021
cleferman pushed a commit to cleferman/mattermost-webapp that referenced this pull request Dec 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation release-note-none
Projects
None yet
7 participants