This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-33003 Remove a bunch of unneeded mixins used in the sass code #9364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I attached this to the ticket I had for upgrading or removing compass-mixins. Feel free to make a new ticket instead if you had one you wanted to make |
hmhealey
approved these changes
Nov 15, 2021
deanwhillier
approved these changes
Nov 16, 2021
|
/update-branch |
|
/update-branch |
|
Thanks @jespino
|
jgilliam17
approved these changes
Dec 7, 2021
|
Test server destroyed |
|
/cherry-pick release-6.3 |
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
to mattermost-build/mattermost-webapp
that referenced
this pull request
Dec 21, 2021
…termost#9364) * Removing no longer needed backward compatibility mixins for CSS3 * Removing usage of @border-radius mixin * Removing more unneeded mixins * Removing more unneeded mixins * Removing more unneeded mixins * Removing more unneeded mixins * Fix linter errors * Removing single-transition mixin usage * Fix linter errors * Removing input-placeholder and background-size mixins * Removing more mixins usage * Removing entirely the compass-mixins dependency * Removing compass-mixins imports * applying review suggestions * fix linter problems Co-authored-by: Mattermod <[email protected]> (cherry picked from commit 5c07315)
cleferman
pushed a commit
to cleferman/mattermost-webapp
that referenced
this pull request
Dec 21, 2021
…termost#9364) * Removing no longer needed backward compatibility mixins for CSS3 * Removing usage of @border-radius mixin * Removing more unneeded mixins * Removing more unneeded mixins * Removing more unneeded mixins * Removing more unneeded mixins * Fix linter errors * Removing single-transition mixin usage * Fix linter errors * Removing input-placeholder and background-size mixins * Removing more mixins usage * Removing entirely the compass-mixins dependency * Removing compass-mixins imports * applying review suggestions * fix linter problems Co-authored-by: Mattermod <[email protected]>
mattermod
pushed a commit
that referenced
this pull request
Dec 22, 2021
cleferman
pushed a commit
to cleferman/mattermost-webapp
that referenced
this pull request
Dec 22, 2021
…termost#9364) * Removing no longer needed backward compatibility mixins for CSS3 * Removing usage of @border-radius mixin * Removing more unneeded mixins * Removing more unneeded mixins * Removing more unneeded mixins * Removing more unneeded mixins * Fix linter errors * Removing single-transition mixin usage * Fix linter errors * Removing input-placeholder and background-size mixins * Removing more mixins usage * Removing entirely the compass-mixins dependency * Removing compass-mixins imports * applying review suggestions * fix linter problems Co-authored-by: Mattermod <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A lot of mixins are used for backward CSS3 compatibility, but most of the
browsers already supports most of the CSS3 features, so we are no longer
needing that mixins. The resulting css code is longer without giving us
anything. Also I guess the compile takes a bit more because the need os pass
though the compass mixins.
Also, compass-mixins is unmaintained (not a big deal) so we can get rid of that
dependency if we remove all the mixins used from there.
UPDATE: I already removed all the mixins so I removed the compass-mixins dependency.
Some interesting numbers.
Before the changes, the css generate is 35020 lines (740K aprox) and is taking 1.6 seconds of CPU to execute.
After the changes, the css generated is 33884 lines (700K aprox) and is taking 1.4-1.5 seconds of CPU to execute.
Ticket Link
https://mattermost.atlassian.net/browse/MM-33003
Release Note