This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-39580 Switch misc modals to onExited #9294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmhealey
added
2: Dev Review
hmhealey
commented
Oct 29, 2021
| @@ -462,7 +457,6 @@ class CreateComment extends React.PureComponent<Props, State> { | |||
| } | |||
|
|
|||
| handleNotifyAllConfirmation = () => { | |||
| this.props.closeModal(ModalIdentifiers.NOTIFY_CONFIRM_MODAL); | |||
There was a problem hiding this comment.
This modal is now responsible for closing itself instead of CreateComment and CreatePost having to do it
streamer45
approved these changes
Nov 1, 2021
M-ZubairAhmed
approved these changes
Nov 1, 2021
hmhealey
added
QA Deferred
amyblais
added
Changelog/Not Needed
iOSGeekster
pushed a commit
to iOSGeekster/mattermost-webapp
that referenced
this pull request
Nov 2, 2021
* Switch AppsForm to use onExited * Switch UserSettingsModal to use onExited * Switch RemovedFromChannelModal to use onExited * Switch SubmenuModal to use onExited * Switch InteractiveDialog to use onExited * Switch NotifyConfirmModal and ConfirmModalRedux to onExited * Switch ResetStatusModal to onExited * Switch QuickSwitchModal to onExited * Remove unnecessary closeModal action from DeleteIntegrationLink * Switch AboutBuildModal to onExited * Switch MoreDirectChannels to onExited
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm renaming onHide to onExited so that it mirrors how it's supposed to be used with React-Bootstrap. GenericModal is one of those modals.
There shouldn't be any functional changes here, but there is some extra cleanup since is the last of these PRs.
Ticket Link
https://mattermost.atlassian.net/browse/MM-39580
Related Pull Requests
#9280
#9281
#9282
#9283
#9291
#9292
Release Note