Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-9771] Cursor focus doesn't return to comment box on the RHS after editing a message on the RHS by removing all of the text in the comment #925

Merged
merged 1 commit into from
Mar 13, 2018
Merged

[MM-9771] Cursor focus doesn't return to comment box on the RHS after editing a message on the RHS by removing all of the text in the comment #925

merged 1 commit into from
Mar 13, 2018

Conversation

letsila
Copy link
Contributor

@letsila letsila commented Mar 10, 2018 •
edited
Loading

Summary

Fixes #8429

Ticket Link

Jira ticket

Checklist

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit and component tests passed
  • Added or updated unit tests (required for all new features)

@letsila letsila changed the title Fixes cursor focus (#8429) Cursor focus doesn't return to comment box on the RHS after editing a message on the RHS by removing all of the text in the comment (#8429) Mar 10, 2018
@letsila letsila changed the title Cursor focus doesn't return to comment box on the RHS after editing a message on the RHS by removing all of the text in the comment (#8429) MM-9771 Cursor focus doesn't return to comment box on the RHS after editing a message on the RHS by removing all of the text in the comment Mar 10, 2018
@letsila letsila changed the title MM-9771 Cursor focus doesn't return to comment box on the RHS after editing a message on the RHS by removing all of the text in the comment [MM-9771] Cursor focus doesn't return to comment box on the RHS after editing a message on the RHS by removing all of the text in the comment Mar 10, 2018
@jwilander jwilander added the 2: Dev Review Requires review by a core commiter label Mar 10, 2018
saturninoabril
saturninoabril approved these changes Mar 10, 2018
View reviewed changes
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @letsila!

@letsila
Copy link
Contributor Author

letsila commented Mar 11, 2018

np

@saturninoabril saturninoabril added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Mar 13, 2018
@saturninoabril saturninoabril merged commit 591e449 into mattermost:master Mar 13, 2018
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Mar 16, 2018
@lindalumitchell lindalumitchell added the Tests/Done Release tests have been written label Mar 29, 2018
hmhealey pushed a commit that referenced this pull request Aug 28, 2020
@jwilander @hmhealey
Add support for options in get profiles in and without team (#925)
da3c5d7
hmhealey pushed a commit that referenced this pull request Mar 17, 2021
@jwilander
Add support for options in get profiles in and without team (#925)
90de809
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkraft mkraft mkraft approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Milestone
No milestone
6 participants
@letsila @mkraft @saturninoabril @jwilander @lindalumitchell @amyblais