This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-39346] - Make scrollbar visible in all themes #9215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmhealey
approved these changes
Oct 20, 2021
correct. As of now there isn't a requirement for the scrollbar to have it's own field, instead, it should take the value that you see in the other small-ish elements around the sidebar like the channel navigator button. |
jgilliam17
approved these changes
Oct 22, 2021
There was a problem hiding this comment.
Thanks @nevyangelova
Tested, looks good to merge.
- Verified scrollbar is visible in all themes.
|
Test server destroyed |
|
/cherry-pick cloud |
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
to mattermost-build/mattermost-webapp
that referenced
this pull request
Oct 22, 2021
Co-authored-by: Nevyana Angelova <[email protected]> (cherry picked from commit 832acae)
mattermod
added a commit
to mattermost-build/mattermost-webapp
that referenced
this pull request
Oct 22, 2021
amyblais
pushed a commit
that referenced
this pull request
Oct 22, 2021
Co-authored-by: Nevyana Angelova <[email protected]> (cherry picked from commit 832acae) Co-authored-by: Nev Angelova <[email protected]> Co-authored-by: Mattermod <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR omits the 'ChangeCSS' application for the scrollbar background and uses a CSS variable instead, which solves the visibility issues.
Ticket Link
https://mattermost.atlassian.net/browse/MM-39346
Release Note