This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-37934: UI for channel override on CRT notifications #9031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users with CRT 'ON' now have controls to override global CRT notification settings per channel basis.
…override-crt-notifications
devinbinnie
approved these changes
Oct 12, 2021
hmhealey
reviewed
Oct 12, 2021
| @@ -169,6 +177,84 @@ export default function ExpandView({ | |||
| </div> | |||
| </fieldset> | |||
| } | |||
| <div className='mt-5'> | |||
| <ExtraInfo section={section}/> | |||
There was a problem hiding this comment.
What's this change for? won't it cause this to display differently for different sections since it'll be below most sections or above the newly added ones?
There was a problem hiding this comment.
this should be below the added ones, since the added ones are like an extra depending on the settings directly above them.
There was a problem hiding this comment.
That works for me. It's been a while since I've looked at this code, so I wasn't sure how it was structured.
|
Test server destroyed |
|
/update-branch |
hmhealey
approved these changes
Oct 19, 2021
…override-crt-notifications
jgilliam17
approved these changes
Oct 27, 2021
There was a problem hiding this comment.
Thanks @koox00
Tested on a related server PR, looks good to merge.
|
/update-branch |
iOSGeekster
pushed a commit
to iOSGeekster/mattermost-webapp
that referenced
this pull request
Nov 2, 2021
* MM-37934: UI for channel override on CRT notifications Users with CRT 'ON' now have controls to override global CRT notification settings per channel basis. * Fixes tests * Fixes desktop notifications for CRT * Fixes tests * Fixes tests * Minor styling for CRT notify setting Co-authored-by: Mattermod <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Users with CRT 'ON' now have controls to override global CRT notification
settings per channel basis.
Ticket Link
https://mattermost.atlassian.net/browse/MM-37934
Related Pull Requests
Screenshots
Release Note