This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-9711: Fix post attachment collapsing #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwilander
approved these changes
Mar 7, 2018
|
@ccbrown should this be against the release-4.8 branch? |
hmhealey
approved these changes
Mar 7, 2018
hmhealey
pushed a commit
that referenced
this pull request
Aug 28, 2020
#901) * Channel loading state is determined by the chunks length * Dont filter or remove chunks if it is recent
hmhealey
pushed a commit
that referenced
this pull request
Mar 17, 2021
#901) * Channel loading state is determined by the chunks length * Dont filter or remove chunks if it is recent
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Broken by #842. Fixed that, renamed the state variables to make it more apparent that their value is HTML, and verified that emojis still work as expected in attachments.
Ticket Link
https://mattermost.atlassian.net/browse/MM-9711
Checklist
make check-styleto check for style errors (required for all pull requests)