[MM-22800]_add keyboard shortcuts to tooltips #8896

AshishDhama · 2021-09-20T11:50:24Z

Summary

Add keyboard shortcuts to the following tooltips:

Switch to a specific team
History arrows (Desktop app only) (for global headers as well)
- Back in history
- Forward in history
Write a Direct message - '+' plus icon in the LHS next to the Direct Message category header
Recent Mentions (for global headers as well)
Upload file - show tooltip on hover of the paperclip icon in the message input

Ticket Link

Fixes https://mattermost.atlassian.net/browse/MM-22800
Fixes mattermost/mattermost#15024

Related Pull Requests

NONE

Screenshots

before	after




No Tooltip
No Tooltip
No Tooltip

Release Note

* adding keyboard shortcuts to tooltips
* Use shortcut key component for displaying keys

mm-cloud-bot · 2021-09-20T11:50:26Z

@AshishDhama: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

matthewbirtch

This is awesome work @AshishDhama!

components/global/history_buttons/history_buttons.tsx

components/keyboard_shortcuts/keyboard_shortcuts.ts

components/keyboard_shortcuts/keyboard_shortcuts_sequence/keyboard_shortcuts_sequence.tsx

michelengelen · 2021-09-20T14:42:14Z

components/keyboard_shortcuts/keyboard_shortcuts_sequence/keyboard_shortcuts_sequence.tsx

+ let description: string | undefined;
+ let keys: string | undefined;


there is no need to define types for those variables

typescript will start complaining about type being implicitly any, So i guess it make sense to keep

why is it complaining? I just tried it myself and it is not complaining for me when I remove the types

since we removed the undefined assignment below we can just immediately initiate a empty string as value

let description = ''; let keys = '';

empty strings are falsey values, so nothing will break in the return value. that way tsc can infer the type and it will not complain about it.

components/keyboard_shortcuts/keyboard_shortcuts_sequence/keyboard_shortcuts_sequence.tsx

components/shortcut_key/shortcut_key.tsx

components/sidebar/sidebar_category/sidebar_category.tsx

michelengelen

still some changes needed, but looking good so far!

components/keyboard_shortcuts/keyboard_shortcuts_sequence/keyboard_shortcuts.ts

components/keyboard_shortcuts/keyboard_shortcuts_modal/keyboard_shortcuts_modal.tsx

components/keyboard_shortcuts/keyboard_shortcuts_sequence/index.ts

components/keyboard_shortcuts/keyboard_shortcuts_sequence/keyboard_shortcuts_sequence.tsx

…e snippet

AshishDhama · 2021-09-21T13:32:35Z

Thanks @michelengelen for such a detailed review

michelengelen

LGTM ... nice work! 🙇🏼‍♂️

nevyangelova · 2021-09-22T08:53:21Z

components/keyboard_shortcuts/keyboard_shortcuts_sequence/keyboard_shortcuts_sequence.test.tsx

+
+import KeyboardShortcutsSequence from './keyboard_shortcuts_sequence';
+
+describe('components/shortcuts/KeyboardShortcutsSequence', () => {


can we add some tests for the hoisting logic etc? We are trying to get as much coverage in unit tests as possible :)

nevyangelova · 2021-09-22T08:59:55Z

I don't wanna hold off any work done here and its a great feature, however is there a reason behind having a modal with all the shortcuts rendered there? As far as I see in the ticket it was intended to show separate shortcuts in tooltips only?

AshishDhama · 2021-09-22T09:06:23Z

I don't wanna hold off any work done here and its a great feature, however is there a reason behind having a modal with all the shortcuts rendered there? As far as I see in the ticket it was intended to show separate shortcuts in tooltips only?

@nevyangelova it’s not a new component I have just converted it to functional component, as we needed shortcuts and some other functions defined inside the original shortcut modal. So we broke it down to small components.
For reference #6138 (review)

nevyangelova · 2021-09-22T09:12:44Z

I don't wanna hold off any work done here and its a great feature, however is there a reason behind having a modal with all the shortcuts rendered there? As far as I see in the ticket it was intended to show separate shortcuts in tooltips only?

@nevyangelova it’s not a new component I have just converted it to functional component, as we needed shortcuts and some other functions defined inside the original shortcut modal. So we broke it down to small components.
For reference #6138 (review)

I see it used to be the shortcutsModal but I wonder if we even need to have that component at all? We can define the shortcuts like you have now and render the tooltips when necessary. I think this modal existed to be shown to new users to display all possible shortcuts but if this is not the case anymore we can probably get rid of it. @esethna WDYT?

AshishDhama · 2021-09-22T09:17:44Z

@nevyangelova I think UX team have some other plans for that I guess moving Keyboard Shortcuts to RHS @matthewbirtch Could you please share.
But IMO having all the shortcuts at a single place is useful

michelengelen · 2021-09-22T12:43:07Z

@nevyangelova @AshishDhama it would probably a good candidate for the tips button next to the search field! WDYT?

/cc @matthewbirtch

matthewbirtch · 2021-09-22T13:42:35Z

@nevyangelova @AshishDhama it would probably a good candidate for the tips button next to the search field! WDYT?

/cc @matthewbirtch

@michelengelen we have the keyboard shortcuts item in the help menu already. Is that what you mean?

matthewbirtch · 2021-09-22T13:43:41Z

@nevyangelova I think UX team have some other plans for that I guess moving Keyboard Shortcuts to RHS @matthewbirtch Could you please share.
But IMO having all the shortcuts at a single place is useful

Yes, this ticket is one that was in the productivity sprint and it doesn't look like it got picked up by a developer: https://mattermost.atlassian.net/browse/MM-22550

jgilliam17

Thanks @AshishDhama
Tested, looks good to merge.

Verified Keyboard shortcuts on tooltips for Team icon, History arrows on Desktop, Write a Direct message +, Recent Mentions and Upload file.
When open, RHS is blocking mentions tooltip from surfacing, repros on daily, filed separately
https://mattermost.atlassian.net/browse/MM-38772

mm-cloud-bot · 2021-09-22T14:51:37Z

Test server destroyed

esethna · 2021-09-22T16:30:24Z

I think this modal existed to be shown to new users to display all possible shortcuts but if this is not the case anymore we can probably get rid of it. @esethna WDYT?

@nevyangelova, in my mind there's a place for both shortcuts on tooltips AND a modal summarizing all tooltips. the tooltips just help with instant discovery, rather than the keyboard shortcut modal is likely only found by power users

michelengelen · 2021-09-23T06:53:11Z

@matthewbirtch exactly ... I did not know it was there (and my local instance broke it obviously :D )

nevyangelova

Thanks LGTM :)

…9176) * Revert "MM-37916: close product switcher on item click (#8594)" (#8677) This reverts commit fc8f1f4d * fix failed tests (#8688) * MM-37821 - remove global header option from user settings (#8645) * removed preferences from global header selector * added all changes from #8583 * updated snapshot * [MM-38042] Change file preview modal animation to fade in and out (#8675) * change file preview modal animation to fade in and out Co-authored-by: Mattermod <[email protected]> * [MM-38119] Fix class name typo (#8691) * fix class name typo dnd sub menu too far from parent menu to mouse to as a result of margins not being overridden due to a classname typo * also fix reversed conditional for dnd feature flag * update snapshots * Cypress/E2E: Fix failed tests (#8681) * fix failed tests * update inbucket port to 9001 * update per recent revert that affects menu * Update interactive_dialog.jsx (#8505) * Ensure quick channel switcher mentions obey collapsed threads (#8690) * [MM-38130] Rename channel preferences tooltip and modal to settings (#8703) * rename channel preferences tooltip to settings * change from "channel preferences" to "settings" includes change of variable name for consistency * remove unused i18n key & string * update snapshots * fix test * Multiselect for commands (#8142) * Multiselect for commands * Fix i18n extract * Address feedback * Fix case where different components have to be used. Co-authored-by: Mattermod <[email protected]> * [MM-37462] add channel split (#8643) * Add A/B treatments for add channel button. * Adapt tutorial tip placement for add channel button A/B test * send tracking event when opening dropdown menu * Mm 34899 fix dark theme in purchase modal (#8603) Co-authored-by: Pablo Velez Vidal <[email protected]> * Translations update from Weblate (#8738) * Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ * Translated using Weblate (German) Currently translated at 100.0% (4748 of 4748 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 100.0% (4741 of 4741 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 100.0% (4745 of 4745 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ * Translated using Weblate (Hungarian) Currently translated at 100.0% (4748 of 4748 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 99.9% (4745 of 4748 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 100.0% (4741 of 4741 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 100.0% (4741 of 4741 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 100.0% (4745 of 4745 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ * Translated using Weblate (Turkish) Currently translated at 100.0% (4748 of 4748 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/tr/ Translated using Weblate (Turkish) Currently translated at 100.0% (4741 of 4741 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/tr/ Translated using Weblate (Turkish) Currently translated at 100.0% (4745 of 4745 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/tr/ * Translated using Weblate (English (Australia)) Currently translated at 100.0% (4748 of 4748 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/en_AU/ Translated using Weblate (English (Australia)) Currently translated at 100.0% (4741 of 4741 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/en_AU/ Translated using Weblate (English (Australia)) Currently translated at 100.0% (4745 of 4745 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/en_AU/ * Translated using Weblate (Swedish) Currently translated at 99.9% (4745 of 4748 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/sv/ Translated using Weblate (Swedish) Currently translated at 100.0% (4741 of 4741 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/sv/ Translated using Weblate (Swedish) Currently translated at 100.0% (4745 of 4745 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/sv/ * Translated using Weblate (French) Currently translated at 90.2% (4281 of 4741 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/fr/ * Translated using Weblate (German) Currently translated at 100.0% (4748 of 4748 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ * Translated using Weblate (French) Currently translated at 90.1% (4281 of 4748 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/fr/ * Translated using Weblate (Dutch) Currently translated at 100.0% (4748 of 4748 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/nl/ * Translated using Weblate (Hungarian) Currently translated at 100.0% (4748 of 4748 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Co-authored-by: JtheBAB <[email protected]> Co-authored-by: Tóth Csaba // Online ERP Hungary Kft <[email protected]> Co-authored-by: Kaya Zeren <[email protected]> Co-authored-by: Matthew Williams <[email protected]> Co-authored-by: MArtin Johnson <[email protected]> Co-authored-by: Nathanaël <[email protected]> Co-authored-by: jprusch <[email protected]> Co-authored-by: wget <[email protected]> Co-authored-by: Tom De Moor <[email protected]> Co-authored-by: Zsolt Godó <[email protected]> * security: add dependency track configuration (#8741) * CRT: Main channel view root post timestamp adds a horizontal scrollbar on hover (#8680) Co-authored-by: Mattermod <[email protected]> * MM-38121 Do not overwrite current team's thread mention count on websocket reconnect (#8702) * Do not overwrite current team's thread mention count on websocket reconnect * Fix types * Remove debug code * [MM-37859] Fix product switcher menu items (#8695) * extenal link menu items missing markup added * move about and downoads menu items out of gate * update snapshot * lint updates * fix bad merge * [MM-37053] Billing history test scripts for system console (#8567) * Billing testscript for mock screens * Amending the Billing testscript for mock screens * Eslint Fix and cypress.json changes * MM-37054 - Modified Subscription test cases * Changes done as per feeback given for PR-8361 * modified group for @cloud_only tag * modified as per PR-8361 feedback * test script for billing history * Changes required for PR-8567 * removed the apiInitSetup function from before hook * modification as per PR-8567 feedback * updated suite name * updated the comment * updated the comments in cloud.d.ts file * [MM-37365] Reposition the RHS when Global Header is enabled (#8671) * don't remove GH using `isMobile` `isMobile` removes GH for tablets as well as mobile phones, we only want to remove it for devices below 769px, so for now media queries need to be used * fix search bar not rendering in mobile if the screen width changes from desktop to mobile without triggering a React render, mobile view is broken because it requires the search bar to be present * resize/reposition RHS when GH is active * lint fixes * added a guard to check for the currentUser in `status_dropdown.tsx` Co-authored-by: Michel Engelen <[email protected]> * removed `Open...` from the product switcher menu (#8742) * Promoting hungarian and english australian (#8709) * npm run update snapshots * promoting English Australian and Hungarian * ran update snaphot * oops no files? * forgot to modify i18n.jsx * changed to more consistent English (Australian) * English (US) changes 12 snapshots * did run npm update snapshots again * added (US) to English Co-authored-by: Tom De Moor <[email protected]> * MM-38018 - Fix guest accounts license check in System Console (#8639) Co-authored-by: Mattermod <[email protected]> * [MM-37054] Subscription test script for system console (#8361) * Billing testscript for mock screens * Amending the Billing testscript for mock screens * Eslint Fix and cypress.json changes * MM-37054 - Modified Subscription test cases * Changes done as per feeback given for PR-8361 * modified group for @cloud_only tag * modified as per PR-8361 feedback * latest changes need as PR-8361 * updated the test caseID * merged testcase as per feedback * update test ID Co-authored-by: Saturnino Abril <[email protected]> * [MM-37985] Fix config names (#8646) * Fix config names * Rename cwsUrl in cypress e2e tests * Revert naming change back to CustomURLchemes * Fix naming between client and server config Co-authored-by: Mattermod <[email protected]> * MM-35017: ordering and inclusion of participants (#8664) * MM-35017: ordering and inclusion of participants Participants' avatart in threads should be shown in reverse reply order, the one who replied last should be shown first and so forth. Root poster's avatar should not be shown, except in the case of global threads, where it is shown always as the first avatar. * Fixes tests * [MM-37707] - Move next steps menu item to help dropdown and adjust mo… (#8631) * [MM-37707] - Move next steps menu item to help dropdown and adjust modals * PR feedback * linter * Add react node array to types for generic modal container * fix modal in all screens * renamed the occurences of `globalHeader` variables to `globalHeaderEnabled` * changed the helptext styling to use white instead of a variable * make linter happy :D * Remove check for multi teams Co-authored-by: Nevyana Angelova <[email protected]> Co-authored-by: Michel Engelen <[email protected]> * [MM-38085] - fixing focussed search field background color (#8730) * fixing focussed search field background color * fixed wrong opacity on placeholder pseudo element * update compass-icons to get new product icons (#8736) * [MM-36792] Consistent query param names (#8700) Summary Be consistent with query parameter names: use `per_page` instead of `pageSize` for the Thread API Ticket Link https://mattermost.atlassian.net/browse/MM-36792 Related Pull Requests Has server changes: [MM-36792] limit number of threads returned from SQL store mattermost-server#18260 Has mobile changes: [MM-36792] Consistent query param names mattermost-mobile#5643 * [MM-38049] Fix permalink preview username spacing (#8705) * [MM-36432] Pass through browser history changes to the desktop app for desktop v5.0+ (#8522) * [MM-36432] Pass through browser history changes to the desktop app for desktop v5.0+ * Blank commit * blank Co-authored-by: Mattermod <[email protected]> * [MM-38138] Fix safari "bug" with SVG sizing (#8737) * fix safari bug with SVG sizing * update cloud bg pill arrangment to match designs * remove gradient background * tweak cloud background * fix gradient for Safari * center, top align and scale background * MM-37603: click on code should not open the thread (#8754) * MM-37603: click on code should not open the thread Removes the click to open thread functionality when clicking or trying to select text in a code block or in-line code. * Updates comment for clarity * Cursor on code set to auto * [MM-38241] Use DOMParser to parse tables from clipboard (#8760) * Use DOMParser to parse from clipboard * Add E2E test * ApplyTheme Updates – convert older changeCSS JS to CSS variables part 2 (#8443) * change centerChannelBg to css vars 1 Changes: - RHS post additional info card bakcground colour used on plugins (I couldn’t find it in the UI) - system notice background colour - content area background colour - markdown table background colour - modal footer background colour (not sure these are used anymore, but maintained in case) - status icon background colour (shows as border) - transparent alert background colour (couldn’t find in the UI) Notes: - `channel-header__description:before` does not seem to be in use anymore * change centerChannelBg to css vars 2 Changes: - post list background colour - post menu item background colour Notes: - `.post .dropdown-menu a` not used # Conflicts: # sass/components/_post.scss * change centerChannelBg to css vars 3 Changes: - post create container background colour - emoji preview container background colour Notes: - `.date-separator .separator__text` doesn’t seem to be used anymore - `.new-separator .separator__text` background overide is redundent, so removing # Conflicts: # utils/utils.jsx * change centerChannelBg to css vars 4 Changed: - default dropdown menu background colour - default popover background colour - top overlay background * change centerChannelBg to css vars 5 Changes: - popover top/right arrow colours - tip overlay sidebar & header arrow colour - tip overlay chat arrow colour * change centerChannelBg to css vars 5 Changes: - bot message attachment and message attachment button background colours - keyboard shortcuts shortcut key text colour - emoji picker and search input background colours - nav tabs background colour (marketplace tabs, emoji picker tabs etc.) - collapsed post fade-out gradient background Notes: - `.post-list__new-messages-below` does not seem to exist anymore # Conflicts: # components/shortcut_key/shortcut_key.scss # sass/layout/_webhooks.scss * lint updates * fix master merge fail Co-authored-by: Mattermod <[email protected]> * make `ProductBranding` component clickable (#8648) * re-arranged elements in left portion of the global header to make the procutbranding clickable as well * updated global header selector * added `cursor: pointer;` to the `ProductBranding` component * PR review remarks * removed badly merged code * PR review remarks * removed propagation stop on handler function (#8759) * [MM-37708] - changed font-family to Open Sans on popover title (#8756) * changed font-family to Open Sans on popover title * added a more precise definition to prevent specificity issues * moved class definition up one level * make linter happy! :D * Feature/mm 37916 close product switcher on item click (#8678) * re-added onClick menu closing functionality to menu items * added function return type to clickHandler in Menu-Group divider * removed TODO * PR review remarks * chore/MM-17293 : Migrate 'components/invitation_modal/invitation_modal_guest_step' and associated tests to TypeScript (#8590) * ts files * test update * to ts * MM-37957: fixes overlapping separators in thread (#8755) Timestamps and or new messages line was overlapping the text message making it impossible to read, this commit fixes that. * MM-38147 - validate guest users cannot invite (#8757) * MM-38147 - validate guest users cannot invite * do not show the invite button to guest users * add the getCurrentUser import statement * remove the unnecessary validation for isGuest * fix the invite members button test Co-authored-by: Pablo Velez Vidal <[email protected]> * [MM-37814] - Handle quick switch shortcut in channel navigator (#8749) * [MM-37814] - Handle quick switch shortcut in sidebar * move functionality to channel navigator Co-authored-by: Nevyana Angelova <[email protected]> * Distinguish between RHS and main channel for Apps Commands. (#8386) * Migrate Create Post and Create Comment to typescript * Fix lint * Fix snapshots * Instantiate command provider on create post and create comment component, and pass it as a prop * Use redux to store app command parser state * Address feedback * Fix thread fetch on websocket refresh * Address feedback * Fix tests Co-authored-by: Mattermod <[email protected]> * Translations update from Weblate (#8786) * Translated using Weblate (Russian) Currently translated at 96.5% (4584 of 4748 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ru/ * Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ * Translated using Weblate (German) Currently translated at 100.0% (4747 of 4747 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ * Translated using Weblate (Hungarian) Currently translated at 99.8% (4740 of 4747 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ * Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ * Translated using Weblate (German) Currently translated at 100.0% (4747 of 4747 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 100.0% (4747 of 4747 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 100.0% (4747 of 4747 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ * Translated using Weblate (Hungarian) Currently translated at 100.0% (4747 of 4747 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 100.0% (4747 of 4747 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 100.0% (4747 of 4747 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ * Translated using Weblate (English (Australia)) Currently translated at 100.0% (4747 of 4747 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/en_AU/ Translated using Weblate (English (Australia)) Currently translated at 100.0% (4747 of 4747 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/en_AU/ * Translated using Weblate (Turkish) Currently translated at 100.0% (4747 of 4747 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/tr/ Translated using Weblate (Turkish) Currently translated at 100.0% (4747 of 4747 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/tr/ * Translated using Weblate (Dutch) Currently translated at 100.0% (4747 of 4747 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/nl/ * Translated using Weblate (Swedish) Currently translated at 100.0% (4747 of 4747 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/sv/ * Translated using Weblate (French) Currently translated at 90.0% (4273 of 4747 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/fr/ * Translated using Weblate (French) Currently translated at 90.0% (4277 of 4747 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/fr/ Co-authored-by: Vladislav Moiseev <[email protected]> Co-authored-by: JtheBAB <[email protected]> Co-authored-by: Tóth Csaba // Online ERP Hungary Kft <[email protected]> Co-authored-by: jprusch <[email protected]> Co-authored-by: Matthew Williams <[email protected]> Co-authored-by: Kaya Zeren <[email protected]> Co-authored-by: Tom De Moor <[email protected]> Co-authored-by: MArtin Johnson <[email protected]> Co-authored-by: Nathanaël <[email protected]> Co-authored-by: Yunbao <[email protected]> * [MM-37897] - added fading to the "new channel category dropzone box" (#8781) * added fading to the "new channel category dropzone box" * updated snapshot * removed hard coded animating class * reverted updated snapshot * fixing "roles" error Co-authored-by: Mattermod <[email protected]> * Fixes "property.roles" of undefined (#8791) A logged out user with global header enabled would crash for the root URL. This was happening because we assumed current user exists when querying on whether to show or not the tutorials or getting started page. This commit fixes that by defaulting those values to false and guarding on current user. * bumped version of compass-icons and compass-components (#8774) Co-authored-by: Mattermod <[email protected]> * [MM-37978] - Start Trial CTA in Main Menu (#8684) * [MM-37978] - Start Trial CTA in Main Menu * fix translation * update * feedback impl * fix * fix tests * fix style lint issues * fix test * some fixes * add agreement link * fix disclaimer * feedback impl * fix useEffect * add test cases * fix translations * Updates .editorconfig to handle typescript files (#8788) * MM-37021 Track message count outside of Channel object (#8658) * Update channel reducer tests to not fail with new fields added * MM-37021 Add messageCounts state * MM-37021 Remove message counts from channels.channels * Add comments to various msg_count and mention_count fields * Change comments to TSDoc style Co-authored-by: Mattermod <[email protected]> * [MM-36789] Thread Root Post (#8708) * Security: Post is not removed from the Threads view when post is deleted * update message delete variable name * MM-38159 - Fix license checks in System Console for Starter License (#8768) * [MM-37814] - Adjust status dropdown according to design (#8667) * [MM-37814] - Adjust status dropdown according to design * applying check icon to the selected status in the status-dropdown * fixed alignment of icons and added correct checkmark placement to DND option * fixed some warnings in the file * make linter happy :D * updated tests and snapshots * bumped version of compass-components and added correct component for rendering statusicons * updated snapshot * fixed styling overrides for timedDnD menu * fixed styling for timed DnD menus * make linter happy :D * make linter happy ... again :/ * make linter happy ... again :/ * adjusted status icon styles slightly * make linter happy * removes unintended opacity from status icon * Adjust custom status container line height * fix pulsating dot * fix lint * Add theme colours for the badge * Update components/global/global_header.scss Co-authored-by: Dean Whillier <[email protected]> * Update components/global/global_header.scss Co-authored-by: Dean Whillier <[email protected]> * Update components/global/global_header.scss Co-authored-by: Dean Whillier <[email protected]> Co-authored-by: Nevyana Angelova <[email protected]> Co-authored-by: Michel Engelen <[email protected]> Co-authored-by: Dean Whillier <[email protected]> * Cypress/E2E: Fix failed tests on header info due to global header (#8789) * fix failed tests on header info due to global header * added more fixes * fix root message being equal (#8803) * Make invite members button always show as lhs button and remove featu… (#8800) * Make invite members button always show as lhs button and remove feature flag code * MM-38060 - Fix license check for Themes and others in System Console (#8780) Co-authored-by: Mattermod <[email protected]> * Bugfix - roles error with global header enabled (#8796) * Revert "Fixes "property.roles" of undefined (#8791)" This reverts commit fe824e250741caef002fb4c1f115cfc76a71288b. * Revert "fixing "roles" error" This reverts commit adb9b982b53f6621620bb3b6ffba33e624b6639a. * added a new hook (`useIsLoggedIn`) to check if there is a user logged in * added usage of hook `useIsLoggedIn` to prevent rendering of the global header when no user is logged in * fixed linter error * Added support to exclude specific emoji by short name (#8656) * Added support to exclude specific emoji by short name * log to WARN and improve emoji name search * Log line uses warn * Added documentation for using the new excluded-emoji-file CLI parameter * Fix JS error on joining missing channel as sysadmin (#8739) * Add missing check on channel * Update components/channel_layout/channel_identifier_router/actions.ts Co-authored-by: Anurag Shivarathri <[email protected]> Co-authored-by: Anurag Shivarathri <[email protected]> * fixing doc link (#8817) Co-authored-by: Benjamin Cooke <[email protected]> * fix e2e related to global header (#8819) * downgrading Italian and Polish to Alpha (#8818) Co-authored-by: Tom De Moor <[email protected]> * [MM-34870] - fixing post-highlighting (#8797) * re-added styling and fixed styles for "show more" element * make linter happy :D * changed color value to generated css variable to be consistent * PR review remarks Co-authored-by: Mattermod <[email protected]> * MM-38193 Add missing i18n strings from MoreChannels modal (#8765) * extends the `Screenshots` section in the PR template (#8807) * extends the `Screenshots` section in the PR template * wording improvement * MM-38093: updates notifications copy on CRT replies (#8778) MM-38093: updates notifications copy on CRT replies Desktop notifications title for replies when users have with CRT "on" should include "Reply in " before the channel name. e.g: - Reply in Off-Topic - Reply in Direct Message Co-authored-by: Mattermod <[email protected]> * Translations update from Weblate (#8833) * Translated using Weblate (Japanese) Currently translated at 100.0% (4757 of 4757 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ja/ Translated using Weblate (Japanese) Currently translated at 99.7% (4747 of 4757 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ja/ Translated using Weblate (Japanese) Currently translated at 100.0% (4747 of 4747 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ja/ * Translated using Weblate (German) Currently translated at 100.0% (4759 of 4759 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 100.0% (4757 of 4757 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ Translated using Weblate (German) Currently translated at 100.0% (4757 of 4757 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ * Translated using Weblate (Turkish) Currently translated at 100.0% (4760 of 4760 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/tr/ Translated using Weblate (Turkish) Currently translated at 100.0% (4757 of 4757 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/tr/ Translated using Weblate (Turkish) Currently translated at 100.0% (4757 of 4757 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/tr/ * Translated using Weblate (Hungarian) Currently translated at 100.0% (4760 of 4760 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 100.0% (4759 of 4759 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 100.0% (4757 of 4757 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 100.0% (4757 of 4757 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 99.9% (4756 of 4757 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ * Translated using Weblate (English (Australia)) Currently translated at 100.0% (4760 of 4760 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/en_AU/ Translated using Weblate (English (Australia)) Currently translated at 100.0% (4759 of 4759 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/en_AU/ Translated using Weblate (English (Australia)) Currently translated at 100.0% (4757 of 4757 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/en_AU/ * Translated using Weblate (Swedish) Currently translated at 100.0% (4760 of 4760 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/sv/ Translated using Weblate (Swedish) Currently translated at 100.0% (4757 of 4757 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/sv/ * Translated using Weblate (German) Currently translated at 100.0% (4760 of 4760 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ * Translated using Weblate (Chinese (Simplified)) Currently translated at 98.2% (4679 of 4760 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/zh_Hans/ * Translated using Weblate (Bulgarian) Currently translated at 98.2% (4679 of 4760 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/bg/ Co-authored-by: kaakaa <[email protected]> Co-authored-by: JtheBAB <[email protected]> Co-authored-by: Kaya Zeren <[email protected]> Co-authored-by: Tóth Csaba // Online ERP Hungary Kft <[email protected]> Co-authored-by: Matthew Williams <[email protected]> Co-authored-by: MArtin Johnson <[email protected]> Co-authored-by: jprusch <[email protected]> Co-authored-by: aeomin <[email protected]> Co-authored-by: Nikolai Zahariev <[email protected]> * [MM-37694] - fixing getting started colors (#8805) * match invite members button space with other lhs spacing (#8832) * [MM-38427] - Start Trial option showing in Daily (#8827) * [MM-38427] - Start Trial option showing in Daily * simplify expressions * remove bodyOnly prop (#8836) Fixes matermost/mattermost-server#18360 * fix failed tests related to recent UI changes (#8830) * fix tests related to global header changes (#8847) * [MM-36444] Manage 6.0 deprecations (#8541) * removing feature flag * removing some configs * partially remove ExperimentalChannelOrganization * removing ExperimentalChannelOrganization * removing configs from tests * MM-32342 Remove LegacySidebar component * MM-32342 Remove deprecated settings from UserSettingsSidebar * MM-32342 Remove references to old sidebar from ChannelHeader * MM-32342 Remove references to old sidebar from DataPrefetch * MM-32342 Remove references to old sidebar from mattermost-redux * MM-32342 Remove references to old sidebar from web app redux * MM-32342 Remove EnableLegacySidebar from client config * MM-32342 Remove code for old sidebar analytics * MM-32342 Remove old sidebar selectors from LeaveTeamModal * MM-32342 Remove channel selectors only used by old sidebar * MM-32342 Remove unused selectors * MM-32342 Remove legacyMakeFilterAutoclosedDMs * MM-32342 Remove code for favourites preferences * MM-32342 Remove unneded code for making DMs visible * MM-32342 Remove old autoclosing DMs code * Remove getSidebarPreferences * removing experimentaltownsquare * Remove leftover comment and unused selector * adding some stuff back in to avoid conflicts * fixing translations * Update E2E tests relying on old sidebar * Remove System Console settings and type definitions for deprecated settings * Fix bad merge * removing old configs * fixing lint * fixing translations * fixing lint * test commit * lint * Remove a few more instances of deprecated settings * Fix i18n * removing old function * fixing snapshot * fixing tests maybe * fixing lint * removing deprecated function * removing old tests for old roles * removing test with old server version * fixing lint * Remove lingering reference to getAllRecentChannels * MM-36444: Removed unnecessary 'isreadonly' functions. * MM-36444: Lint fix. * missing import Co-authored-by: Benjamin Cooke <[email protected]> Co-authored-by: Harrison Healey <[email protected]> Co-authored-by: Martin Kraft <[email protected]> * [MM-37052] Payment information test scripts for system console (#8792) * payment information test script * corrected caption of subscribe button * updated the script as per PR - 8792 feedback * updated the script as per PR - 8792 feedback * Fixes bot username override issue with incoming webhooks (#8815) * Fixes bot username override issue with incoming webhooks * use default operator Co-authored-by: Mattermod <[email protected]> * fix tests due to global header changes (#8850) * fixing show more button for message previews (#8776) Automatic Merge * Cypress/E2E: Test fixes/updates for v6 (#8858) * fix tests due to global header changes * fix tests for v6 * Cypress/e2e/Fixed main menu test case (#8864) * fixed post_header and main menu test cases * Revert "fixed post_header and main menu test cases" This reverts commit 7b8bcc63eab487be89eda2e4c07a7ec4f4486050. * fixed post_header and main menu test cases * Mm 38361 pre written messages (#8840) * Add A/B test for first time user prewritten message helps. * Define box shadow elevations as CSS variables.. * Track users closing of tutorial tips. * Track users usage of prefilled messages. * MM-37187 Update react-intl and update localized icons to support that (#8860) * MM-37187 Update react-intl * MM-37187 Add aria-label support to LocalizedIcon * MM-37187 Update components to fix react-intl type checking * Address feedback * [MM-38158] Allowing username and profile pic overrides for bots (#8785) Automatic Merge * fix snapshots (#8875) * Add initial whitespace characters in /code rendering (#8802) * MM-38260: Show teams pages in E0. (#8873) * don't error if there is no pathName defined on the message (#8878) * fix for failed tests (#8868) * Cypress/E2E: fix failed tests for v6 (#8879) * fix for failed tests * fix e2e tests * add types and remove commented step * Translations update from Weblate (#8883) * Translated using Weblate (French) Currently translated at 90.1% (4289 of 4760 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/fr/ * Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ * Translated using Weblate (Spanish) Currently translated at 97.1% (4619 of 4756 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/es/ * Translated using Weblate (Dutch) Currently translated at 99.8% (4766 of 4771 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/nl/ Translated using Weblate (Dutch) Currently translated at 99.4% (4746 of 4771 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/nl/ Translated using Weblate (Dutch) Currently translated at 99.7% (4746 of 4756 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/nl/ * Translated using Weblate (German) Currently translated at 100.0% (4771 of 4771 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ * Translated using Weblate (Hungarian) Currently translated at 100.0% (4771 of 4771 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ Translated using Weblate (Hungarian) Currently translated at 99.9% (4768 of 4771 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/hu/ * Translated using Weblate (English (Australia)) Currently translated at 99.9% (4768 of 4771 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/en_AU/ * Translated using Weblate (Polish) Currently translated at 74.2% (3542 of 4771 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/pl/ Co-authored-by: Pierre JENICOT <[email protected]> Co-authored-by: Elias Nahum <[email protected]> Co-authored-by: Tom De Moor <[email protected]> Co-authored-by: jprusch <[email protected]> Co-authored-by: Tóth Csaba // Online ERP Hungary Kft <[email protected]> Co-authored-by: Matthew Williams <[email protected]> Co-authored-by: master7 <[email protected]> * Mm 38364 download apps (#8876) * Add A/B test for download section * Add missing translations. * Make button text for invite members step conditional. * Last 4 credit card digits as a string (#8463) * fixed messageing test cases (#8890) * MM-24370 Remove manual focus change from cancel button (#8844) * MM-24370 Remove manual focus change from cancel button * Remove unused prop * MM-37969 Cypress/E2E: fix tests related to file preview (#8894) * fix tests related to file preview * fix file upload intercept * Update e2e/cypress/support/ui/file_preview.d.ts Co-authored-by: Joseph Baylon <[email protected]> Co-authored-by: Joseph Baylon <[email protected]> * fix input background (#8867) * Improve memoization of makeCombineUserActivityPosts (#8899) * [MM-38468] - Webapp/System Console: Check if help text about customized Support Email is still accurate with the removal of tutorial screen (#8892) * [MM-38468] - Webapp/System Console: Check if help text about customized Support Email is still accurate with the removal of tutorial screen * revert change * fix e2e tests (#8902) * [MM-38214] Added Inline Latex support (#8644) * Add link to forked marked repo * Upgraded to marked version with options * Typo fix and newer marked version * Added menu option to enable or disable inline latex * Added new marked repo. Characters are not escaped anymore * Temporarily hardcoding inline latex to true to enable testing * Upgraded to new marked version that only renders inline latex if the last $ is not followed by a word character * stripped down marked version * Added test files and hardcoded inline latex for testing * Update to newer marked version * Updated help text and inline latex option is now dissabled if latex is turned off * Support for new custom attribute data-inline-latex * Added lazyloading for katex library * Katexoptions are not exported anymore * Fixed test suite by manually importing katex * removed harcoded option * Lazy loading types now come from the katex library itself * Deleted unneeded wrapper.update in tests * Updated to newer marked package with updated regex rules * New marked package that does not use negative lookbehind anymore * Changed marked back to mattermost repo Co-authored-by: Kobe Bergmans <[email protected]> Co-authored-by: Mattermod <[email protected]> * MM-38579: fix town-square being always read-only (#8886) * MM-38579: fix town-square being always read-only * linting issues * drop unused readOnlyChannel from create_comment * drop unused readOnlyChannel from create_post * updated snapshots * [MM-38414] fixes Unable to set custom status with Don't clear option (#8918) * fixed messaging test case (#8914) * fixed messageing test case * Update e2e/cypress/integration/auth_sso/authentication_4_spec.js Co-authored-by: Saturnino Abril <[email protected]> * fixed variable name Co-authored-by: Saturnino Abril <[email protected]> * Update NOTICE.txt (#8906) Automatic Merge * [MM-38263] - Add channel category menu to channel header (#8839) * [MM-38263] - Add channel category menu to channel header * Fixup styles * PR feedback * Fix lint * Add divider to the bottom of the menu item Co-authored-by: Nevyana Angelova <[email protected]> * MM-37971 Refactor MoreDirectChannels into smaller components (#8821) * Refactor MoreDirectChannels into smaller components * Stop showing archived users without DMs * Clean up commented out code and a few errors * Add some memoization to makeGetOptions * Add tests to makeGetOptions * Remove empty file * Update tests * Revert behaviour change * fix tests for v6.0 (#8916) * Refactor isMobile to use redux and change name to isMobileView for better clarity (alternative) (#8870) * track window width ranges using redux * GlobalHeader: use getIsMobileView selector * Sidebar: use getIsMobileView selector * Global header test updates make hook for isMobileView for easier testing * update sidebar tests * update tests * use switch's default case * remove test code * revert global header test code * Cypress/e2e/fixed cypress test cases (#8930) * fixed cypress test cases * fixed Invite People command * [MM-22800]_add keyboard shortcuts to tooltips (#8896) * add keyboard shortcuts to tooltips * fix imports and some code touch ups * fix import order * change normalize func name and keyboard shortcut type rename * refining code * fix test breaking code block * PR review remarks ### components/shortcut_key/index.ts - improved index exports ### components/shortcut_key/shortcut_key.tsx - fixed a typo in `ShortcutKeyVariant` enum ### components/keyboard_shortcuts/keyboard_shortcuts_sequence/keyboard_shortcuts_sequence.tsx - shortened components import - improved `normalizeShortcutDescriptor` function * minor code clean up and reverting the normalizeShortcutDescriptor code snippet * update test for keyboard shortcut sequence component Co-authored-by: Michel Engelen <[email protected]> * always show playbooks card (#8903) * always show playbooks card * fix notifications translations (#8904) * fix notifications, prewritten messages, and onboarding title translations * Cypress/E2E: fix tests for v6 (#8933) * fix tests for v6 * clarify in comment than assigning a variable * Get options for post options based on the post channel (#8439) * Get options for post options based on the post channel * Only fetch when the menu is actually opened, and fix type error * Address feedback and prepare for RHS state * Add redux RHS bindings related code * Extract get bindings from the component * Address feedback * Fix tests * Add more logic into a selector Co-authored-by: Mattermod <[email protected]> * MM-36697: global threads infinite scrolling (#8793) * MM-36697: global threads infinite scrolling Adds "infinite" scrolling pagination to global threads list. * Fixes tests * Fixes linter * Uses "cursor" based pagination Changes the pagination method and instead of asking for pages, ask for items before "threadId". Also adds a new key in redux to keep references to unread threads. This is done to avoid inconsistencies on the all threads list. These inconsistencies where happening when you arrived at unread threads and then switched to all threads. * Fixes marking threads as read * Fixes types * Changes THREADS_PAGE_SIZE to 25 * Fixes tests * Minor refactor Co-authored-by: Mattermod <[email protected]> * MM-38678 - fix theme colour bug (#8928) white was being applied and overriding the theme colour * [MM-38469] - fixed several console errors regarding propTypes (#8921) * fixed several console errors regarding propTypes * updated snapshots * fix for rhs bottom spacing issue (#8917) * MM-37951: follow thread on reply (#8828) Co-authored-by: Mattermod <[email protected]> * [MM-36551] - improvements to post edit indicator (#8851) * improvements to post edit indicator - created new component `PostEditIndicator` - added a pencil icon to the indicator - removed "old" usages - adjusted styling of PostEditIndicator - adjusted `formatText` function to insert a empty span if the post-id is present - extended the `messageToHtmlComponent` function to render a `PostEditIndicator` when this empty span is found - adjusted translation file * make linter happy * PR review remarks * updated snapshots * fixed typing errors * added overlay to the edited indicator - wrapped the edited indicator in `OverlayTrigger` component - did some date calculations to find the correct time and wording - used react-intl functions to get locale-correct times and dates - added a new function to datetime.ts `isWithinLastWeek` - added 2 new language properties: `datetime.today` and `datetime.yesterday` unrelated work: - added return types to functions in datetime.ts - re-structured some of the return values * PR review remarks * PR review remarks * updated snapshots * make hour numeric (no leading zero) * remove direction property from icon style * adjusted spacings * make the post editor span blocky * [MM-38442] - add product switcher menu unit tests (#8826) * [MM-38442] - add product switcher menu unit tests * Fixup tests * Fix type error * Fix type error for real Co-authored-by: Nevyana Angelova <[email protected]> * [MM-38283] - fixed `SUGGESTION.UNDEFINED` in quick-switch modal (#8806) Automatic Merge * Highlight invite_members_button until user interacts with it (#8939) * Highlight invite_members_button until user interacts with it * MM-38446 - theme color fix for tips next steps page plugins image (#8932) * MM-38446 - theme color tips next steps * hardcode the color values so the svg looks the same in all themes Co-authored-by: Pablo Velez Vidal <[email protected]> * MM-38311 - invite people button to bottom of menu (#8927) Co-authored-by: Pablo Velez Vidal <[email protected]> * Mm 38326 getting started position (#8900) * fix team sidebar and sidebar container height * [MM-T603] - Place a string when a date is expected (#18180) (#8877) * [MM-T603] - place a string when a date is expected (#18180) * add header * move the test * MM-38747 Fixed crash caused by incorrect prop (#8967) * MM-38140 - show only enterprise for professional upgrade (#8848) * MM-38140 - show only enterprise for professional upgrade * fix linter problems * fix check types * use the initial options filter to show/hide the compare plans section * fix return type by adding null to the possible returned options Co-authored-by: Pablo Velez Vidal <[email protected]> * Cypress/E2E: fix SAML/Keycloak and other tests for v6 (#8955) * fix saml/keycloak and other tests for v6 * handle folder creation at fixtures folder * [MM-38430] - Onboarding invite shows limits that no longer apply (#8944) * [MM-38430] - Onboarding invite shows limits that no longer apply * remove invite limitations from invitation steps * fix translations * fix tests * Revert "[MM-38430] - Onboarding invite shows limits that no longer apply" This reverts commit 64bac9f912752a8072459e4d5612124c76ca5aeb. * fix PR * fix ts type check * This allows the emoji picker to be shown outside the context of a team (#8901) * MM-38006 Fix collapsed post contents sometimes scrolling (#8929) * MM-38006 Fix collapsed post contents sometimes scrolling * Fix React warning in FilePreviewModal * Rename misnamed method * Fix test * Update snapshot * [MM 38105] Bug fix: apply theme in root component instead of needs team component (#8926) * MM-38105 move theme application to root component * update tests * [MM-38854] - remove extra space from message when no edit indicator is present (#8964) * remove extra space from message when no edit indicator is present * fixed the extra whitespace bug in cypress tests * return null from component replacement when no postId is present or post has not been edited before * [MM-38457] - Subscribe now CTA missing from Global header menus (#8857) * [MM-38457] - Subscribe now CTA missing from Global header menus * refactor CTA * rm added code * rm unused imports from main menu * refactor tests * fix test description * feedback impl-1 * change namings * fix snapshots * fix storybook import error Co-authored-by: Mattermod <[email protected]> * Open forms in bindings on all locations (#8784) * Open directly form when Binding has a form * Fix tests * Fix snapshots * Fix lint after merge Co-authored-by: Mattermod <[email protected]> * icon size increase for product switcher button (#8934) given the prominence of the product switcher button and challenges with rendering the 9 square grid icon at such a small size, we are increasing the icon size for this single use case * [MM-38274] Implement registerMessageWillBeUpdatedHook (#8849) * Implement registerMessageWillBeUpdatedHook * Update plugins/registry.js Co-authored-by: Aaron Rothschild <[email protected]> Co-authored-by: Aaron Rothschild <[email protected]> * only renders a single divider ("recent") in suggestion_list.jsx for the quick switch modal (#8976) * Fixes fetching threads upon ws reconnection (#8985) When a websocket reconnect occurs and the reconnectCallback gets called, we should only fetch user threads if CRT is enabled for the user. * Add type definitions for utils.jsx (#8970) * Remove unused functions from utils.jsx * Properly use Team type in SystemUserDetail * Add missing scheme_guest field to TeamMembership * Fix incorrect state for public links * Fix incorrectly typed UserProfile objects * Add type defition for utils.jsx and fix other type errors * Add missing translation string * Update type definition * Only rehydrate drafts from localStorage on first load (#8980) * MM-36932: always call reconnect callback (#8956) Upon websocket reconnect we are missing messages, this commit attempts to fix that by always calling reconnectCallback regardless on whether reliableWebSockets is enabled or not. * MM-38539 Make rehydrateDrafts idempotent (#8978) * Make rehydrateDrafts idempotent * Switch areObjectsEqual to fast-deep-equal * Fix merge Co-authored-by: Joram Wilander <[email protected]> * MM-38540 - set consistent hover state for invite members button (#9005) * MM-38540 - set consistent hover state for invite members button * fix linter problem * remove lighning on hover for invite button Co-authored-by: Pablo Velez Vidal <[email protected]> * fixed test cases (#9007) * [MM-38836] - Try Enterprise for free option missing spacing in mobile webview (#8986) * [MM-38836] - Try Enterprise for free option missing spacing in mobile webview * change to link color * [MM-38833] - Font within CC field is not consistent with other fields in payment form (#8983) * update tests related to edit indicator (#9006) * Handle /:team/_playbooks/:playbookId/run (#9012) Navigating to that URL will switch to the last viewed channel in the team, defaulting to Town Square, and then will execute the /playbook run-playbook command, effectively rendering an interactive dialog to run the playbook specified in the path. This is needed to support the Run button in the Playbooks product, fixing a bug in the desktop, so the app can successfully change the tab to Channels but still renders the interactive dialog in the Playbooks tab. * [MM-38536] Stop needs_team from trying to join a team with a reserved name (#8981) * Cypress/E2E: fixed tests and demoted other tests (#9011) * fixed and demoted other tests * demote other tests * MM-38212: remove read channel from unreads when navigating to threads (#8829) * MM-38212: remove unread channel when navigating to threads We include the current channel id in the unreads even if it's read, I see no reason to include the lastUnreadChannel as well. Removing it fixes the case when you navigate from an unread channel to global threads and it didn't remove the channel from the sidebar. * Clears lastUnreadChannel when visiting threads * [MM-38430] - Onboarding invite shows limits that no longer apply-2 (#8990) * [MM-37054] Refactored trial subscription test scripts for system console (#8801) * payment information test script * refactored by adding cy commands and removed duplicate code * Revert "payment information test script" This reverts commit 0a53a33277f181f6b4d6d98d53b50d5c7e1bf209. * updated the script as per PR-8792 * MM-38780 - Do not show Oauth 2.0 for Starter (#8972) * [MM-38868] Fixes do not disturb submenu item not taking full width (#8996) * [MM-38868] Fixes do not disturb submenu item not taking full width * [MM-26478] Add one click reactions (#8866) * initial impl * add one-click reactions preference * complement recent emojis with defaults if recently used ones are < 3 * tests * reflect review comments * minor alignment issue fixed * 3 dot menu on right hand side if one-click reactions are enabled * Apply suggestions from code review Co-authored-by: Kyriakos Z. <[email protected]> * reflect revivew comments * do not mutate props of the component * reflect review comments * soften some rough edges * disable setting when emoji picker is disabled * fix e2e tests Co-authored-by: Kyriakos Z. <[email protected]> Co-authored-by: Mattermod <[email protected]> * Enable require setting are enabled before installing demo plugin (#9014) * Cypress/E2E: Fix some prod messaging tests (#9033) * Cypress/E2E: Fix some unstable messaging tests (#9041) * fixing image name (#8971) Automatic Merge * docker/build: push image to the testing repository and refactor the fetches of the dockerfile (#8987) Signed-off-by: Carlos Panato <[email protected]> * [MM-38344] + [MM-38347] - Clean up: apply style adjustments to component styles and remove all temporary non-global header code (#8940) * moved global header hiding to _mobile.scss and specific CSS variables to _css_variables.scss * moved .dropdown-menu style adjustments to _dropdown.scss * moved global header sibling positioning to _tablet.scss * moved .team-sidebar style adjustments to _team-sidebar.scss * moved #SidebarContainer style adjustments to _sidebar-left.scss * moved .SidebarChannelNavigator style adjustments to _sidebar-left.scss * moved .channel__wrap style adjustments to _tablet.scss * moved #sidebar-right style adjustments to _sidebar-right.scss * removed .product-switcher-icon, since it is not used anywhere * moved .backstage style adjustments to _backstage.scss (fixed one error along the way) * moved .channel__wrap style adjustments to _desktop.scss * moved .Menu style adjustments to menu.scss * moved .status-dropdown-menu-global-header style adjustments to status_dropdown.scss * moved .search-bar-container--global and .search__form style adjustments to _search…

mm-cloud-bot added the do-not-merge/release-note-label-needed label Sep 20, 2021

AshishDhama added the 1: UX Review Requires review by a UX Designer label Sep 20, 2021

AshishDhama requested a review from matthewbirtch September 20, 2021 12:20

AshishDhama added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Sep 20, 2021

mm-cloud-bot added release-note and removed do-not-merge/release-note-label-needed labels Sep 20, 2021

AshishDhama force-pushed the MM-22800_Keyboard-shortcuts-on-tooltip branch 2 times, most recently from ab95536 to 9500968 Compare September 20, 2021 12:50

add keyboard shortcuts to tooltips

158bf21

AshishDhama force-pushed the MM-22800_Keyboard-shortcuts-on-tooltip branch from 9500968 to 158bf21 Compare September 20, 2021 12:58

AshishDhama requested review from nevyangelova, michelengelen and jgilliam17 September 20, 2021 13:11

AshishDhama added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Sep 20, 2021

AshishDhama marked this pull request as ready for review September 20, 2021 13:12

matthewbirtch approved these changes Sep 20, 2021

View reviewed changes

matthewbirtch removed the 1: UX Review Requires review by a UX Designer label Sep 20, 2021

michelengelen suggested changes Sep 20, 2021

View reviewed changes

AshishDhama added 2 commits September 20, 2021 22:45

fix imports and some code touch ups

4fbc9c8

fix import order

3c3fbad

AshishDhama added Setup Cloud Test Server Setup a test server using Mattermost Cloud and removed Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Sep 20, 2021

mm-cloud-bot removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Sep 20, 2021

AshishDhama added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Sep 21, 2021

AshishDhama requested a review from michelengelen September 21, 2021 04:37

michelengelen suggested changes Sep 21, 2021

View reviewed changes

change normalize func name and keyboard shortcut type rename

425ee22

AshishDhama requested a review from michelengelen September 21, 2021 08:07

minor code clean up and reverting the normalizeShortcutDescriptor cod…

7407d49

…e snippet

michelengelen approved these changes Sep 21, 2021

View reviewed changes

nevyangelova reviewed Sep 22, 2021

View reviewed changes

jgilliam17 approved these changes Sep 22, 2021

View reviewed changes

jgilliam17 removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Sep 22, 2021

esethna added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Sep 22, 2021

esethna added this to the v6.1.0 milestone Sep 22, 2021

update test for keyboard shortcut sequence component

305e885

AshishDhama requested a review from nevyangelova September 23, 2021 09:12

nevyangelova approved these changes Sep 23, 2021

View reviewed changes

AshishDhama merged commit 242a18c into master Sep 23, 2021

AshishDhama deleted the MM-22800_Keyboard-shortcuts-on-tooltip branch September 23, 2021 09:44

amyblais added Changelog/Done Required changelog entry has been written Docs/Needed Requires documentation labels Sep 23, 2021

cwarnermm added Docs/Not Needed Does not require documentation and removed Docs/Needed Requires documentation labels Nov 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MM-22800]_add keyboard shortcuts to tooltips #8896

[MM-22800]_add keyboard shortcuts to tooltips #8896

AshishDhama commented Sep 20, 2021 •

edited

Loading

mm-cloud-bot commented Sep 20, 2021

matthewbirtch left a comment

michelengelen Sep 20, 2021

AshishDhama Sep 20, 2021

michelengelen Sep 21, 2021

michelengelen Sep 21, 2021

michelengelen left a comment

AshishDhama commented Sep 21, 2021

michelengelen left a comment

nevyangelova Sep 22, 2021

nevyangelova commented Sep 22, 2021

AshishDhama commented Sep 22, 2021

nevyangelova commented Sep 22, 2021

AshishDhama commented Sep 22, 2021 •

edited

Loading

michelengelen commented Sep 22, 2021 •

edited

Loading

matthewbirtch commented Sep 22, 2021

matthewbirtch commented Sep 22, 2021

jgilliam17 left a comment

mm-cloud-bot commented Sep 22, 2021

esethna commented Sep 22, 2021

michelengelen commented Sep 23, 2021

nevyangelova left a comment

		let description: string \| undefined;
		let keys: string \| undefined;


		import KeyboardShortcutsSequence from './keyboard_shortcuts_sequence';

		describe('components/shortcuts/KeyboardShortcutsSequence', () => {

[MM-22800]_add keyboard shortcuts to tooltips #8896

[MM-22800]_add keyboard shortcuts to tooltips #8896

Conversation

AshishDhama commented Sep 20, 2021 • edited Loading

Summary

Ticket Link

Related Pull Requests

Screenshots

Release Note

mm-cloud-bot commented Sep 20, 2021

matthewbirtch left a comment

Choose a reason for hiding this comment

michelengelen Sep 20, 2021

Choose a reason for hiding this comment

AshishDhama Sep 20, 2021

Choose a reason for hiding this comment

michelengelen Sep 21, 2021

Choose a reason for hiding this comment

michelengelen Sep 21, 2021

Choose a reason for hiding this comment

michelengelen left a comment

Choose a reason for hiding this comment

AshishDhama commented Sep 21, 2021

michelengelen left a comment

Choose a reason for hiding this comment

nevyangelova Sep 22, 2021

Choose a reason for hiding this comment

nevyangelova commented Sep 22, 2021

AshishDhama commented Sep 22, 2021

nevyangelova commented Sep 22, 2021

AshishDhama commented Sep 22, 2021 • edited Loading

michelengelen commented Sep 22, 2021 • edited Loading

matthewbirtch commented Sep 22, 2021

matthewbirtch commented Sep 22, 2021

jgilliam17 left a comment

Choose a reason for hiding this comment

mm-cloud-bot commented Sep 22, 2021

esethna commented Sep 22, 2021

michelengelen commented Sep 23, 2021

nevyangelova left a comment

Choose a reason for hiding this comment

AshishDhama commented Sep 20, 2021 •

edited

Loading

AshishDhama commented Sep 22, 2021 •

edited

Loading

michelengelen commented Sep 22, 2021 •

edited

Loading