Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-8534: Fix insecure image loading by post author #873

Merged
merged 2 commits into from
Feb 23, 2018
Merged

MM-8534: Fix insecure image loading by post author #873

merged 2 commits into from
Feb 23, 2018

Conversation

ccbrown
Copy link
Contributor

@ccbrown ccbrown commented Feb 23, 2018

Summary

This ensures that post previews and predictive posts proxy images.

Ticket Link

https://mattermost.atlassian.net/browse/MM-8534

Checklist

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit and component tests passed

@ccbrown ccbrown added the 2: Dev Review Requires review by a core commiter label Feb 23, 2018
@ccbrown ccbrown added this to the v4.8.0 milestone Feb 23, 2018
@ccbrown ccbrown requested review from hmhealey, saturninoabril and jwilander and removed request for saturninoabril February 23, 2018 20:04
hmhealey
hmhealey approved these changes Feb 23, 2018
View reviewed changes
Copy link
Member

@hmhealey hmhealey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could probably just be done in the MarkdownImage component if we wanted to keep this a bit more contained, but I'm 0/5 if we actually change that

@jwilander jwilander added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Feb 23, 2018
@jwilander jwilander merged commit 70d712c into mattermost:master Feb 23, 2018
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Feb 24, 2018
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label Mar 1, 2018
hmhealey pushed a commit that referenced this pull request Aug 28, 2020
@sudheerDev @hmhealey
MM-11504: Add unread API actions and selectors for bi-directional scr…
c57b4c6 
…olling (#873)

* Add getUnreadPosts (#574)
* Add getUnreadPostsAction
* Add getUnreadPosts API to client4
* Add selector makeGetPostsChunkAroundPost
* Add util func getPostsChunkInChannelAroundTime
* Mark recent true for chunks when dispatching based on post.next_post_id
  for unread API, posts after API
* Keep empty blocks if there will be no blocks after merging
* Change limit for onload unreads
* Add a new util func getUnreadPostsChunk
hmhealey pushed a commit that referenced this pull request Mar 17, 2021
@sudheerDev
MM-11504: Add unread API actions and selectors for bi-directional scr…
e04d312 
…olling (#873)

* Add getUnreadPosts (#574)
* Add getUnreadPostsAction
* Add getUnreadPosts API to client4
* Add selector makeGetPostsChunkAroundPost
* Add util func getPostsChunkInChannelAroundTime
* Mark recent true for chunks when dispatching based on post.next_post_id
  for unread API, posts after API
* Keep empty blocks if there will be no blocks after merging
* Change limit for onload unreads
* Add a new util func getUnreadPostsChunk
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jwilander jwilander jwilander approved these changes

@hmhealey hmhealey hmhealey approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
v4.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ccbrown @jwilander @hmhealey @lindalumitchell @amyblais