Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-8593 Add announcement bar for sysadmins when APIv3 is enabled, other minor clean-up #864

Merged
merged 2 commits into from
Feb 23, 2018
Merged

MM-8593 Add announcement bar for sysadmins when APIv3 is enabled, other minor clean-up #864

merged 2 commits into from
Feb 23, 2018

Conversation

jwilander
Copy link
Member

Summary

Add announcement bar for sysadmins when APIv3 is enabled. Removed any last references to v3 from the webapp.

Ticket Link

https://mattermost.atlassian.net/browse/MM-8593

Checklist

@jwilander jwilander added the 1: PM Review Requires review by a product manager label Feb 22, 2018
@jwilander jwilander added this to the v4.8.0 milestone Feb 22, 2018
@jwilander
Copy link
Member Author

@jasonblais just needs a text review. Testing won't work until the server PR goes in

@jasonblais jasonblais self-assigned this Feb 22, 2018
jasonblais
jasonblais suggested changes Feb 23, 2018
View reviewed changes
Copy link
Contributor

@jasonblais jasonblais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Propose changing the text to

API version 3 is deprecated and scheduled for removal. <a href="https://api.mattermost.com/#tag/APIv3-Deprecation" target="_blank">Learn more</a> how to migrate to APIv4.

@jwilander
Copy link
Member Author

@jasonblais change made with a slight fix to the grammar

@jwilander jwilander added 2: Dev Review Requires review by a core commiter and removed 1: PM Review Requires review by a product manager labels Feb 23, 2018
jespino
jespino approved these changes Feb 23, 2018
View reviewed changes
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jasonblais
jasonblais approved these changes Feb 23, 2018
View reviewed changes
Copy link
Contributor

@jasonblais jasonblais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved text. I assume the functionality works as expected

@jasonblais jasonblais added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Feb 23, 2018
@jasonblais jasonblais removed their assignment Feb 23, 2018
@jwilander jwilander merged commit b954af5 into master Feb 23, 2018
@jwilander jwilander deleted the mm-8593 branch February 23, 2018 16:05
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Feb 23, 2018
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label Mar 7, 2018
jwilander added a commit that referenced this pull request Mar 9, 2018
@jwilander
Revert "MM-8593 Add announcement bar for sysadmins when APIv3 is enab…
f0afa00 
…led, other minor clean-up (#864)"

This reverts commit b954af5.
hmhealey pushed a commit that referenced this pull request Aug 28, 2020
@crspeller @hmhealey
Adding automatic CSRFFromCookie (#864)
d1199f5
hmhealey pushed a commit that referenced this pull request Mar 17, 2021
@crspeller
Adding automatic CSRFFromCookie (#864)
d10b727
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jespino jespino jespino approved these changes

@enahum enahum enahum approved these changes

@jasonblais jasonblais jasonblais approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
v4.8.0
6 participants
@jwilander @jespino @enahum @jasonblais @lindalumitchell @amyblais