This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-8042: Accepts ⌘+enter to comment (et al) #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkraft
changed the title
jespino
suggested changes
Feb 23, 2018
…ed utility function. Adds command support to some missing places.
|
@jespino Great idea. I have refactored to use |
hmhealey
approved these changes
Feb 23, 2018
mkraft
changed the title
mkraft
changed the title
|
@jwilander Can you confirm that is the expected behavior? Ctrl == Meta in mac in all cases, or are there exceptions? |
mkraft
changed the title
jespino
approved these changes
Feb 23, 2018
|
@jespino I manually tested each instance that was changed. I see no reason to not accept ⌘ key in all cases where the key combo uses control on windows. As a macOS user I expect that behaviour. |
|
You are right, actually, the shortcuts help modal, use Ctrl for windows and linux and Meta for mac in all documented cases. So, Is enough for me :) |
jespino
added
4: Reviews Complete
|
Yep, @mkraft is correct |
amyblais
added
Changelog/Done
mkraft
pushed a commit
that referenced
this pull request
Mar 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds ability to post comments with ⌘+enter (the original ticket). Also adds support for using ⌘ key in all places that control is supported in key combinations.
Ticket Link
MM-8042
Checklist
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed