This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Update Compass icon font #7965
Merged
Update Compass icon font #7965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agarciamontoro
approved these changes
Apr 21, 2021
There was a problem hiding this comment.
Thank you for the thorough description, @deanwhillier, I know now how to do it :)
jgilliam17
approved these changes
Apr 21, 2021
There was a problem hiding this comment.
Thanks @deanwhillier
Tested, looks good to merge.
- Verified new added icons are loaded as expected and one icon that has been removed - no longer loads.
michaelgamble
approved these changes
Apr 23, 2021
There was a problem hiding this comment.
Was able to confirm that icon-check-circle-outline from @deanwhillier was a duplicate being removed. Everything looks good to go for me.
|
To clarify, it was actually a rename. I updated the description and tested the icon myself so we don't have to hold this up. @jgilliam17, please feel free to double check the rename regardless! :) |
|
Test server destroyed |
|
Thanks @deanwhillier There's an issue with the test server - I think if you have already tested it, no need to hold this up. 🙂 |
chetanyakan
added a commit
to brightscout-alpha/mattermost-webapp
that referenced
this pull request
Apr 27, 2021
… MM-34128 * 'master' of github.com:mattermost/mattermost-webapp: (46 commits) Mm 27913 search channel tip (mattermost#6896) MM-35053 - cloud trial banner fixes (mattermost#7971) Fixing Zephyr keys for existing tests (mattermost#7977) Update NOTICE.txt (mattermost#7978) [MM-31934] Global policy form (mattermost#7816) MM-32591: Reliable Websockets: Client side changes (mattermost#7921) Translations update from Weblate (mattermost#7988) fix cloud onboarding tests (mattermost#7961) [MM-33428] remove check for Verify Signature (mattermost#7805) update compass icon font (mattermost#7965) [MM-35039] - Send trial ended email (mattermost#7967) Cypress/E2E: Fix tests related to email verification (mattermost#7960) Adding/fixing missing Zephyr keys and polishing tests (mattermost#7935) Mm 20425 migrate youtubevideo to typescript (mattermost#7786) MM-35074: short circuit slash command hooks (mattermost#7969) MM-34910 New messages toast should only count root posts (mattermost#7946) MM-31339: add e2e test for only one auto response per day (mattermost#7938) Cypress/E2E: Fix compliance export test (mattermost#7964) fix test related to channel switcher and bot display name (mattermost#7962) MM-34286: Adds missing authz checks. (mattermost#7891) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current process for updating the icon font:
{package}/font) to the webapp ({webapp}/font/compass-icons/*){package}/css/compass-icons.cssfile against the{webapp}/sass/base/_compass-icons.scssand copy across the changes.Updated icon names for QA:
Added:
Renamed:
Release Note