Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Mm 23120/picking conflicting changes #7958

Merged
merged 4 commits into from
Apr 20, 2021

Conversation

michelengelen
Copy link
Contributor

@michelengelen michelengelen commented Apr 20, 2021

Summary

Cherry-picking changes from the PRs #7932 and #7843 and resolving resulting conflicts.

Related Pull Requests

manojmalik20 and others added 4 commits April 20, 2021 15:28
* Fixed the MM-34095 issue

* Solved several issues from the MM-23120 epic
Solved the MM-33149 issue
Solved the MM-33195 issue
Solved the MM-33214 issue
Solved the MM-33220 issue
Solved the MM-33246 issue
Solved the MM-33433 issue
Solved the MM-34571 issue
Solved the MM-33431 issue

* Updated snapshots

* Fixed some UI issues
Removed the dot in channel header after custom status
Changed the marginLeft for the custom status emoji in switch channel modal
Changed opacity of custom status emoji on hover

* Update components/custom_status/custom_status_modal.tsx

Co-authored-by: Michel Engelen <[email protected]>

* Fixed lint error

* Fixed the styling in switch channel modal

Co-authored-by: Manoj <[email protected]>
Co-authored-by: Michel Engelen <[email protected]>

(cherry picked from commit c2c4725)
* MM-34670 - moved status indicator to the avatar

* MM-33837 - added channel slug info to displayname

* make linter happy :P

* PR review remarks

* visually centered the avatar

* pulled status icon 2px up and 1px left

Co-authored-by: Mattermod <[email protected]>

(cherry picked from commit d12ce41)
@michelengelen michelengelen added the 2: Dev Review Requires review by a core commiter label Apr 20, 2021
@michelengelen michelengelen self-assigned this Apr 20, 2021
Copy link
Contributor

@Willyfrog Willyfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for fixing the conflict :D

@amyblais amyblais added 4: Reviews Complete All reviewers have approved the pull request AutoMerge used by Mattermod to merge PR automatically and removed 2: Dev Review Requires review by a core commiter labels Apr 20, 2021
@mattermod
Copy link
Contributor

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

@amyblais amyblais added this to the v5.35 milestone Apr 20, 2021
@mattermod
Copy link
Contributor

Trying to auto merge this PR.

@mattermod mattermod merged commit ccacddc into cloud Apr 20, 2021
@mattermod mattermod deleted the MM-23120/picking-conflicting-changes branch April 20, 2021 14:06
@mattermod
Copy link
Contributor

Pull Request successfully merged
SHA: ccacddc

@mattermod mattermod removed the AutoMerge used by Mattermod to merge PR automatically label Apr 20, 2021
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
5 participants