Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Cypress/E2E: Save code body, error details and screenshots to dashboard when test failed #7945

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Cypress/E2E: Save code body, error details and screenshots to dashboard when test failed #7945

merged 2 commits into from
Apr 20, 2021

Conversation

saturninoabril
Copy link
Member

@saturninoabril saturninoabril commented Apr 19, 2021 •
edited
Loading

Summary

Save code body, error details (if available) and screenshots to Automation Dashboard when test failed.

Screenshots

Screen Shot 2021-04-19 at 5 16 49 PM

@saturninoabril saturninoabril added the 3: QA Review Requires review by a QA tester label Apr 19, 2021
josephbaylon
josephbaylon approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@josephbaylon josephbaylon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @saturninoabril !!

furqanmlk
furqanmlk approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@furqanmlk furqanmlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@prapti
Copy link
Contributor

prapti commented Apr 20, 2021

/update-branch

prapti
prapti approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@prapti prapti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! Thanks @saturninoabril!

One minor suggestion is to have the date of the result also published next to the screenshot or in the same section with the repo, branch and build id. That will perhaps be helpful in eliminating confusion when comparing failing tests etc of two or more days. How do you feel about that?

@prapti prapti added 4: Reviews Complete All reviewers have approved the pull request AutoMerge used by Mattermod to merge PR automatically and removed 3: QA Review Requires review by a QA tester labels Apr 20, 2021
@mattermod
Copy link
Contributor

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

@mattermod
Copy link
Contributor

Trying to auto merge this PR.

@mattermod
Copy link
Contributor

Pull Request successfully merged
SHA: 018d1d0

@mattermod mattermod merged commit 018d1d0 into mattermost:master Apr 20, 2021
@mattermod mattermod removed the AutoMerge used by Mattermod to merge PR automatically label Apr 20, 2021
@saturninoabril saturninoabril deleted the e2e-improve-report-collection branch April 20, 2021 23:30
@saturninoabril
Copy link
Member Author

Thanks Prapti and thanks for the feedback. We can discuss and consolidate all the feedbacks during our meeting.

chetanyakan added a commit to brightscout-alpha/mattermost-webapp that referenced this pull request Apr 21, 2021
@chetanyakan
Merge branch 'master' of github.com:mattermost/mattermost-webapp into…
e6499ac 
… cs-fix

* 'master' of github.com:mattermost/mattermost-webapp: (125 commits)
  MM-31717: Remove HTTP clustering (mattermost#7924)
  MM-35021: Only display overflow names in Avatars tooltip (mattermost#7955)
  Cypress/E2E: Fix E2E from recent Cloud test run (mattermost#7957)
  save code body, error details and screenshots if available when e2e failed (mattermost#7945)
  MM-32962/MM-32930 Dependency updates (mattermost#7929)
  take into account  menu permissions (mattermost#7792)
  Fix accesibility problems in files/message selectors in hint and RHS (mattermost#7925)
  MM-23120 Custom status issues (mattermost#7843)
  [MM-34742][MM-34743][MM-34745] - Hard coded values fixes (mattermost#7926)
  [MM-34763][MM-34744][MM-34767] - Fix UX issues with channel navigator and navbar (mattermost#7934)
  Feature/mm 34670 (mattermost#7932)
  Cypress/E2E: Fix clock, timezone, local date time specs (mattermost#7949)
  MM-35016 - Update payment screen info text (mattermost#7953)
  MM-34975 - hide payment information to free trial customers (mattermost#7950)
  Translations update from Weblate (mattermost#7943)
  Fix basedn typo (mattermost#7927)
  [MM-34551] Make button disabled for Read Only Admin (mattermost#7904)
  MM-34978 - fix contact support link in the error payment screen (mattermost#7940)
  Upgrading tests to prod (mattermost#7936)
  MM-33748 Support for new mention_count_root and msg_count_root (mattermost#7733)
  ...
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Apr 21, 2021
@mm-cloud-bot
Copy link

@saturninoabril: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

1 similar comment
@mm-cloud-bot
Copy link

@saturninoabril: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

@saturninoabril
Copy link
Member Author

/release-note-none

prapti pushed a commit that referenced this pull request Apr 22, 2021
@saturninoabril @prapti
save code body, error details and screenshots if available when e2e f…
114f8bd 
…ailed (#7945)

Automatic Merge
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephbaylon josephbaylon josephbaylon approved these changes

@prapti prapti prapti approved these changes

@furqanmlk furqanmlk furqanmlk approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation release-note-none
Projects
None yet
Milestone
No milestone
7 participants
@saturninoabril @prapti @mattermod @mm-cloud-bot @josephbaylon @furqanmlk @amyblais