Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Cypress/E2E: Fix test on LDAP groups, code theme and incoming webhook #7919

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

saturninoabril
Copy link
Member

Summary

a. LDAP Groups

  • changed the LDAP sync via API since LDAP config is already set
  • created new Zephyr test cases - MM-T4003
  • added existing test key - MM-T2668

b. Code theme

  • used cy.uiClose() to close the Account Settings

c. Incoming webhook

  • failed due to timeout error during reindex. Add @elasticsearch metadata so it will test first where data is not yet huge.

Ticket Link

none, failing on daily Cypress prod

Screenshots

Screen Shot 2021-04-15 at 8 42 23 AM

Screen Shot 2021-04-15 at 8 43 22 AM

Screen Shot 2021-04-15 at 8 44 42 AM

Screen Shot 2021-04-15 at 8 45 56 AM

@saturninoabril saturninoabril added the 3: QA Review Requires review by a QA tester label Apr 15, 2021
Copy link
Contributor

@josephbaylon josephbaylon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All tests passed locally.

Copy link
Contributor

@furqanmlk furqanmlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

image

image

LGTM

Copy link
Contributor

@prapti prapti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prapti prapti merged commit 8d7fc85 into mattermost:master Apr 16, 2021
@prapti prapti added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Apr 16, 2021
@saturninoabril saturninoabril deleted the fix-prod-test branch April 16, 2021 01:00
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Apr 16, 2021
chetanyakan added a commit to brightscout-alpha/mattermost-webapp that referenced this pull request Apr 27, 2021
…bapp into MM-34128

* 'MM-34128' of github.com:brightscout-alpha/mattermost-webapp: (104 commits)
  Mm 34578 add subscribe now button (mattermost#7894)
  fix subcription typo in the code (mattermost#7930)
  Fixing keys in Cypress (mattermost#7931)
  fix test on LDAP groups, code theme and incoming webhook (mattermost#7919)
  upgrade cypress to v7.1.0 (mattermost#7923)
  Adding missing Zephyr keys to existing E2E tests (mattermost#7920)
  Prod test fixes (mattermost#7918)
  [MM-11264] Added statuses to channel invite modal (mattermost#7787)
  [MM_20388/ GH_16718] Migrate 'components/signup/signup_email' module and associated tests to TypeScript (mattermost#7699)
  MM-34569 - remove step 3 to guests (mattermost#7838)
  add mfa metadata to specs accordingly (mattermost#7896)
  fix test for forgot password based on new email template (mattermost#7892)
  fix CI run of Cypress and add flag to sort specs to first (mattermost#7913)
  cast to lowercase before comparing (mattermost#7769)
  Migrating a few stragglers from the TS migration (mattermost#7770)
  update tests and keys of search date filters (mattermost#7893)
  [MM-34523] New trial card for license page (mattermost#7826)
  Feature: In-product support for Cloud Trial (mattermost#7907)
  Cypress/E2E: Update tests and keys of search date filters (remaining) (mattermost#7895)
  Mm 29656 (mattermost#7820)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
5 participants