Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-34663] System Console > Guest Access (Beta) - System User Manager role now sees Integrations > CORS #7890

Merged
merged 2 commits into from
Apr 13, 2021
Merged

[MM-34663] System Console > Guest Access (Beta) - System User Manager role now sees Integrations > CORS #7890

merged 2 commits into from
Apr 13, 2021

Conversation

hahmadia
Copy link
Contributor

Summary

Accidently using all when it should be any which is why cors was showing up when it shouldn't have.

Ticket Link

https://mattermost.atlassian.net/browse/MM-34663

@hahmadia hahmadia added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Apr 12, 2021
@hahmadia hahmadia removed the 2: Dev Review Requires review by a core commiter label Apr 13, 2021
@hahmadia hahmadia requested review from furqanmlk and josephbaylon and removed request for furqanmlk April 13, 2021 15:38
@josephbaylon josephbaylon added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Apr 13, 2021
josephbaylon
josephbaylon approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@josephbaylon josephbaylon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified fixed using local server and also ran limited_console_access_spec against this PR and tests passed.

@josephbaylon josephbaylon added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Apr 13, 2021
@hahmadia hahmadia merged commit 8e8285d into mattermost:master Apr 13, 2021
@mm-cloud-bot
Copy link

Test server destroyed

@hahmadia hahmadia deleted the MM-34663-MissingCors branch April 13, 2021 16:20
@amyblais
Copy link
Member

/cherry-pick cloud

@mattermod
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit to mattermost-build/mattermost-webapp that referenced this pull request Apr 13, 2021
@hahmadia @mattermost-build
[MM-34663] System Console > Guest Access (Beta) - System User Manager…
e3aa25b 
… role now sees Integrations > CORS (mattermost#7890)

* all to any

* update snpashot

(cherry picked from commit 8e8285d)
@mattermost-build mattermost-build mentioned this pull request Apr 13, 2021
Merged
@mattermod mattermod added the CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone label Apr 13, 2021
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Apr 13, 2021
mattermod pushed a commit that referenced this pull request Apr 13, 2021
@mattermost-build
[MM-34663] System Console > Guest Access (Beta) - System User Manager…
80c419a 
… role now sees Integrations > CORS (#7890) (#7901)

Automatic Merge
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephbaylon josephbaylon josephbaylon approved these changes

@sbishel sbishel sbishel approved these changes

@BenCookie95 BenCookie95 BenCookie95 approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
No milestone
7 participants
@hahmadia @mm-cloud-bot @amyblais @mattermod @josephbaylon @sbishel @BenCookie95