[MM-33462] Extend manifest type #7883
Conversation
Co-authored-by: Michael Kochell <[email protected]>
|
/update-branch |
|
@jfrerich Gentle reminder to take a look when you have the time. |
|
/update-branch |
|
@jfrerich @catalintomai Kind reminder for PR review. |
| Builtin = 'builtin', | ||
| } | ||
|
|
||
| export enum Permission { |
There was a problem hiding this comment.
Suggest that we use the plural to match the Locations enum
| export enum Permission { | |
| export enum Permissions { |
There was a problem hiding this comment.
https://www.typescriptlang.org/docs/handbook/enums.html is using singular names for enums. https://docs.microsoft.com/en-us/previous-versions/dotnet/netframework-1.1/4x252001(v=vs.71)?redirectedfrom=MSDN also states
Use a singular name for most Enum types, but use a plural name for Enum types that are bit fields.
Hence, I'm leaving it as singular.
|
/update-branch |
|
@hanzei: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. I understand the commands that are listed here |
|
/release-note-none |
Summary
AppManifestwas missing a couple of fields are are both useful for the webapp and for app developers.I intentionally leave the fields out that are purely for the backend like callbacks and the AWS information.
Ticket Link
https://mattermost.atlassian.net/browse/MM-33462