Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-18818 Prompt admins to set the Support Email #7774

Merged
merged 10 commits into from
May 3, 2021
Merged

MM-18818 Prompt admins to set the Support Email #7774

merged 10 commits into from
May 3, 2021

Conversation

harshilsharma63
Copy link
Member

@harshilsharma63 harshilsharma63 commented Mar 29, 2021 •
edited by cpanato
Loading

Summary

Admin Advisor now prompts system admins if support email is not configured.

Ticket Link

https://mattermost.atlassian.net/browse/MM-18818

Related Pull Requests

Screenshots

Screenshot 2021-03-30 at 10 59 10 AM

Release Notes

Prompt admins to set support email

@mattermod
Copy link
Contributor

Hello @harshilsharma63,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@harshilsharma63 harshilsharma63 mentioned this pull request Mar 29, 2021
Merged
BenCookie95
BenCookie95 reviewed Apr 1, 2021
View reviewed changes
Copy link
Contributor

@BenCookie95 BenCookie95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a test that actually checks if admin advisor sends the SupportEmail prompt?

@harshilsharma63
Copy link
Member Author

Do we have a test that actually checks if admin advisor sends the SupportEmail prompt?

@BenCookie95 the logic for sending the notification is on the server so no tests are required here.

@BenCookie95
Copy link
Contributor

/update-branch

@sbishel sbishel added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Apr 12, 2021
@sbishel sbishel requested a review from furqanmlk April 12, 2021 14:53
@sbishel sbishel removed the 2: Dev Review Requires review by a core commiter label Apr 12, 2021
furqanmlk
furqanmlk approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@furqanmlk furqanmlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected, Test plan has been updated

image

@hahmadia
Copy link
Contributor

/update-branch

@hahmadia hahmadia added 4: Reviews Complete All reviewers have approved the pull request AutoMerge used by Mattermod to merge PR automatically and removed 3: QA Review Requires review by a QA tester labels Apr 15, 2021
@mattermod
Copy link
Contributor

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

@hahmadia hahmadia removed the AutoMerge used by Mattermod to merge PR automatically label Apr 15, 2021
@harshilsharma63
Copy link
Member Author

/update-branch

@harshilsharma63
Copy link
Member Author

Do not merge this yet. I'll be making a change in this to sync with the disabled Admin Advisor.

@hahmadia hahmadia added the Do Not Merge Should not be merged until this label is removed label Apr 22, 2021
@mm-cloud-bot
Copy link

@harshilsharma63: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

@harshilsharma63 harshilsharma63 added 3: QA Review Requires review by a QA tester and removed Do Not Merge Should not be merged until this label is removed 4: Reviews Complete All reviewers have approved the pull request labels Apr 26, 2021
@cpanato
Copy link
Contributor

cpanato commented Apr 30, 2021

and we are on rate limit again

@harshilsharma63
Copy link
Member Author

and we are on rate limit again

I can just for a while. This is nothing urgent or critical.

@cpanato
Copy link
Contributor

cpanato commented Apr 30, 2021

/check-cla

@cpanato cpanato closed this Apr 30, 2021
@cpanato cpanato reopened this Apr 30, 2021
@harshilsharma63 harshilsharma63 added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels May 3, 2021
@harshilsharma63 harshilsharma63 merged commit 5bdbf72 into mattermost:master May 3, 2021
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@furqanmlk furqanmlk furqanmlk approved these changes

@sbishel sbishel sbishel approved these changes

@BenCookie95 BenCookie95 BenCookie95 approved these changes

@hahmadia hahmadia hahmadia approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation release-note
Projects
None yet
Milestone
No milestone
9 participants
@harshilsharma63 @mattermod @BenCookie95 @hahmadia @mm-cloud-bot @cpanato @furqanmlk @sbishel @amyblais