Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-32201] Job table changes for data retention #7743

Merged
merged 8 commits into from
Apr 14, 2021
Merged

[MM-32201] Job table changes for data retention #7743

merged 8 commits into from
Apr 14, 2021

Conversation

BenCookie95
Copy link
Contributor

@BenCookie95 BenCookie95 commented Mar 23, 2021 •
edited
Loading

Summary

This update is for data retention. I needed a prop to hide the create job button because I need to call the create job endpoint from outside this component.

Design: https://www.figma.com/file/PdZPkf36lNU6ZO41JlEjKd/Team-%26-Channel-Data-Retention?node-id=20%3A181

Ticket Link

https://mattermost.atlassian.net/browse/MM-32201

Screenshot

Screen Shot 2021-03-31 at 10 45 08 AM

This adds 2 new optional props to the job table, className and hideJobCreateButton. This allow you to hide the jobCreatebutton and put the create job button outside this existing component. className is used to add your own custom styles to the job table.

@BenCookie95 BenCookie95 marked this pull request as ready for review March 31, 2021 14:47
@BenCookie95
Copy link
Contributor Author

/update-branch

anurag6713
anurag6713 approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@anurag6713 anurag6713 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BenCookie95 BenCookie95 added the 3: QA Review Requires review by a QA tester label Apr 8, 2021
@BenCookie95 BenCookie95 mentioned this pull request Apr 9, 2021
Merged
@furqanmlk furqanmlk added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Apr 10, 2021
@BenCookie95
Copy link
Contributor Author

/update-branch

furqanmlk
furqanmlk approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@furqanmlk furqanmlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@BenCookie95 BenCookie95 merged commit 843ab09 into mattermost:master Apr 14, 2021
@mattermod mattermod removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Apr 14, 2021
@mm-cloud-bot
Copy link

Test server destroyed

1 similar comment
@mm-cloud-bot
Copy link

Test server destroyed

@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Apr 22, 2021
@mm-cloud-bot
Copy link

@BenCookie95: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

1 similar comment
@mm-cloud-bot
Copy link

@BenCookie95: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anurag6713 anurag6713 anurag6713 approved these changes

@furqanmlk furqanmlk furqanmlk approved these changes

@maxerenberg maxerenberg maxerenberg approved these changes

Assignees
No one assigned
Labels
3: QA Review Requires review by a QA tester Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BenCookie95 @mm-cloud-bot @anurag6713 @furqanmlk @maxerenberg @mattermod @amyblais