This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Scrolling the logout button into view so that it is visible #7719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prapti
added
2: Dev Review
Requires review by a core commiter
3: QA Review
Requires review by a QA tester
labels
Mar 17, 2021
furqanmlk
approved these changes
Mar 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
josephbaylon
approved these changes
Mar 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
josephbaylon
added
4: Reviews Complete
All reviewers have approved the pull request
and removed
2: Dev Review
Requires review by a core commiter
3: QA Review
Requires review by a QA tester
labels
Mar 18, 2021
amyblais
added
Changelog/Not Needed
Does not require a changelog entry
Docs/Not Needed
Does not require documentation
labels
Mar 18, 2021
jwilander
added a commit
that referenced
this pull request
Mar 30, 2021
* Translations update from Weblate (#7701) * Translated using Weblate (Dutch) Currently translated at 100.0% (4483 of 4483 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/nl/ * Translated using Weblate (Romanian) Currently translated at 100.0% (4483 of 4483 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ro/ * Translated using Weblate (Chinese (Simplified)) Currently translated at 98.2% (4405 of 4483 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/zh_Hans/ * Translated using Weblate (Korean) Currently translated at 79.3% (3559 of 4483 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ko/ * Translated using Weblate (Turkish) Currently translated at 100.0% (4483 of 4483 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/tr/ * Translated using Weblate (Bulgarian) Currently translated at 100.0% (4484 of 4484 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/bg/ Co-authored-by: Tom De Moor <[email protected]> Co-authored-by: Viorel-Cosmin Miron <[email protected]> Co-authored-by: aeomin <[email protected]> Co-authored-by: Ji-Hyeon Gim <[email protected]> Co-authored-by: Kaya Zeren <[email protected]> Co-authored-by: Nikolai Zahariev <[email protected]> * [MM-20373/GH-16733] - Migrate 'components/should_verify_email' module and associated tests to TypeScript (#7433) * Migrate components/should_verify_email module and associated test file to TypeScript * Rename components/should_verify_email test snapshot file to tsx * Move type declaration of title to follow func param in components/should_verify_email Co-authored-by: Mattermod <[email protected]> * MM-19925-remove role from user card (#7520) * remove role from user card * Update system_user_detail.tsx Remove commented out code. * remove unused variable Co-authored-by: Mattermod <[email protected]> * MM32642 - increase invite others visibility (#7645) * MM-32642 - increase invite others visibility * make changes based on PR comments * Modify the svg to use the theme vars * use the right variable names * change icons and use theme variables in svg * fix linter issues * fix the mm-redux hash commit * fix linter issues * fix ts weird problems * add PR comments ux suggestions * fix button styles * revert my fix for delete-channel Co-authored-by: Pablo Velez Vidal <[email protected]> * fixed background-color on hover to use theme color correctly (#7680) * Promoting regularly passing tests from 03/08 to 03/15 (#7709) * Clarify that System & Team admins can delete posts (#7544) * [MM-32429] Content Cards (#7469) * adding new card component Co-authored-by: Benjamin Cooke <[email protected]> Co-authored-by: Mattermod <[email protected]> * [MM-33796][MM-33780] Updating channel switcher css system console (#7696) Automatic Merge * MM32771 - improve tips and next steps cards (#7686) * MM32771 - improve tips and next steps cards * apply changes based on PR comments * fix i18n file * fix the hover state for the system console back button Co-authored-by: Pablo Velez Vidal <[email protected]> * Only use fake timers for tests that need them (#7714) * fix E2E for cloud (#7710) * MM-33907 - fix admin console heigh and show save buttons (#7715) Co-authored-by: Pablo Velez Vidal <[email protected]> * [MM-32831] Change show-more background to be highlighted on permanlink views (#7636) * change show-more background to be highlighted on permanlink views * remove changeCSS usage as per review recommendation * address CR comments * fix animation timer, fix pinned post colors * changing alpha to work correctly Co-authored-by: = <=> Co-authored-by: Mattermod <[email protected]> * remove legacy open-sans fonts, upgrade to v18 (#7661) * remove legacy open-sans fonts, upgrade to v18 Adopt the "Practical Level of Browser Support" for our Open Sans font, as outlined on https://css-tricks.com/snippets/css/using-font-face/, and effected via the [google-webfonts-helper](https://google-webfonts-helper.herokuapp.com/fonts/open-sans?subsets=cyrillic,cyrillic-ext,greek,greek-ext,latin,latin-ext,vietnamese), along with documentation on how to do this in the future. As part of this, upgrade open sans from `v13` to `v18` (not the embedded version number, but the one reported by google-webfonts-helper), and eliminating an issue with the kerning table that generated errors on Firefox. Fixes: https://mattermost.atlassian.net/browse/MM-33632 * remove unneeded zip file * MM-24009: remove redux-offline (#7648) * remove remote-redux-devtools * remove network detection * actually enable frozen stores in development * npm install --save github:mattermost/mattermost-redux#d54b2f6dbe57376ad1efe25bfabb84c1a5b6bbf6 * npm install --save github:mattermost/mattermost-redux#10a53b09bbba6b7708e97ada073b6d3be727d405 * remove redux-offline references in tests * npm install --save github:mattermost/mattermost-redux#0eb28bd2c6796bed843f829125fb18b941b8e43d * fix completely unrelated delete channel modal * npm install --save github:mattermost/mattermost-redux#a9a44d557582a5b048c72d4eb2600d7d9032b3fd Co-authored-by: Mattermod <[email protected]> * Fixing site_statistics_spec (#7716) * Fixing site_statistics_spec * lint fix * Cleaning up the fixed file * [MM-33648] - Remove possible confusion point after a member notifies the admin about inviting more users the "Not right now" button remains (#7711) * [MM-33648] - Possible confusion point: After a member notifies the admin about inviting more users the 'Not right now' button remains * Change svg * Update snap * Feedback impl * Fix lint rule collisions Co-authored-by: Mattermod <[email protected]> * MM-29726 Allow disabling link previews from certain domains (#7479) * Add a field for restricted link preview * Add english localization for preview restriction * Add disable condition to link preview field * Change example domains text Co-authored-by: Mattermod <[email protected]> Co-authored-by: Harrison Healey <[email protected]> * Scrolling the logout button into view so that it is visible (#7719) * [MM-20603] Migrate components/team_settings to TypeScript (#7653) * Migrated index.js --> index.ts * Migrated team_settings.jsx --> team_settings.tsx * Removed undefined from component return type * Removed isRequired for a few props in team_general_tab.jsx * Changed updateSection function signature Co-authored-by: Mattermod <[email protected]> * MM-30407: improve slow typing (#7685) * Add channel_icon for email notification redesign. (#7707) * Fix status dropdown (#7725) * Fixing status dropdown test for custom status * Forcing click to avoid unexpected failure while saving * Demoting consistently failing tests from prod to unstable (#7728) * Translations update from Weblate (#7732) * Translated using Weblate (German) Currently translated at 88.2% (3955 of 4484 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ * Translated using Weblate (Dutch) Currently translated at 100.0% (4484 of 4484 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/nl/ * Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ Update translation files Updated by "Cleanup translation files" hook in Weblate. Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ * Translated using Weblate (Polish) Currently translated at 82.4% (3699 of 4485 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/pl/ * Translated using Weblate (Turkish) Currently translated at 100.0% (4490 of 4490 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/tr/ Translated using Weblate (Turkish) Currently translated at 100.0% (4484 of 4484 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/tr/ Translated using Weblate (Turkish) Currently translated at 100.0% (4488 of 4488 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/tr/ Translated using Weblate (Turkish) Currently translated at 100.0% (4485 of 4485 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/tr/ * Translated using Weblate (Swedish) Currently translated at 100.0% (4490 of 4490 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/sv/ Translated using Weblate (Swedish) Currently translated at 99.8% (4480 of 4485 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/sv/ * Translated using Weblate (Bulgarian) Currently translated at 100.0% (4485 of 4485 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/bg/ * Translated using Weblate (Dutch) Currently translated at 100.0% (4490 of 4490 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/nl/ Translated using Weblate (Dutch) Currently translated at 100.0% (4484 of 4484 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/nl/ Translated using Weblate (Dutch) Currently translated at 100.0% (4488 of 4488 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/nl/ * Translated using Weblate (Japanese) Currently translated at 99.5% (4462 of 4484 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ja/ * Translated using Weblate (French) Currently translated at 90.3% (4057 of 4490 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/fr/ * Translated using Weblate (French) Currently translated at 90.4% (4060 of 4490 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/fr/ * Translated using Weblate (German) Currently translated at 87.9% (3947 of 4490 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/de/ * Translated using Weblate (Spanish) Currently translated at 97.3% (4371 of 4490 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/es/ * Translated using Weblate (French) Currently translated at 90.4% (4060 of 4490 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/fr/ Co-authored-by: Elisabeth Kulzer <[email protected]> Co-authored-by: Tom De Moor <[email protected]> Co-authored-by: Michał Sobkiewicz <[email protected]> Co-authored-by: Kaya Zeren <[email protected]> Co-authored-by: MArtin Johnson <[email protected]> Co-authored-by: Nikolai Zahariev <[email protected]> Co-authored-by: kaakaa <[email protected]> Co-authored-by: Pierre JENICOT <[email protected]> Co-authored-by: Cyril LD <[email protected]> Co-authored-by: Markus Marcinek <[email protected]> Co-authored-by: jesus.espino <[email protected]> Co-authored-by: Nathanaël <[email protected]> * [MM-31411][MM-32164] - Add profile picture to Direct Channels link (#7516) * [MM-31411] - Add profile picture to Direct Channels link * Resolve PR comments * Update according to new design * adjust paddings * Fix padding * Update mobile view * remove padding for webview * remove mobile check in component * Fix group icon padding * Adjust padding Co-authored-by: Nevyana Angelova <[email protected]> Co-authored-by: Mattermod <[email protected]> Co-authored-by: Nevyana Angelova <[email protected]> * Move mattermost-redux into mattermost-webapp (#7723) * Add changes to existing files from migration script * Add mattermost-redux files * Update CI scripts * Of course i18n-extract picked up something in the mattermost-redux tests :p * Update build Docker image to Node 14 (#7742) * [MM-33609] - Fix team icon coverage on firefox (#7734) Co-authored-by: Nevyana Angelova <[email protected]> * Updating status_dropdown_spec with missing test cases (#7727) * Updating status_dropdown_spec with missing test cases * Enabling custom status by default and cleaning up the spec file * Admin guide link should be different for cloud or on-premise instances (#7752) Signed-off-by: Mario de Frutos <[email protected]> * [MM-22840/GH-14198] DMs (More dialog): show recent 20 with relative timestamp (#6913) * [MM-34183] - Getting Started Step 3 (Invite members to team) for new users on paid Workspace above 10 users are unable to invite members via email (#7745) * [MM-34183] - Getting Started Step 3 (Invite members to team) for new users on paid Workspace above 10 users are unable to invite members via email * Add some tests * Feedback impl-1 * [MM-29959] restrict 'Manage Roles' button to system admins (#7695) Automatic Merge * Remove Custom statuses feature flag (#7641) Co-authored-by: Mattermod <[email protected]> * fix E2E for file previews (#7754) * upgrade Cypress to v6.8.0 (#7761) * MM-34235 - remove trailing slash causing nav bar to hide (#7760) Co-authored-by: Pablo Velez Vidal <[email protected]> * [GH-15906][MM-22844] Change channel_icon for email notification redesign. (#7762) * Change channel_icon * Rename channel_icon * [MM-33102] Don't show warning and Fix support Link on Cloud (#7756) * Dont show banner and fix link * fix extra name * fix linting * fix test * change type * update snapshot * update snapshot * MM-25140 Fix unit tests which are broken on Node 14 (#7741) * Fix async handleSubmit methods returning early * Mock PQueue in DataPrefetch tests * MM-34114 - grab users stats on demand to fix invite buttons logic (#7766) * MM-34114 - grab users stats on demand to fix invite buttons logic * Add MR suggestions changes * improve JS validation Co-authored-by: Maria A Nunez <[email protected]> Co-authored-by: Pablo Velez Vidal <[email protected]> Co-authored-by: Maria A Nunez <[email protected]> * MM-18107: Precursory refactoring and supporting code (#7744) * support fallback loading content * refactor: no results indicator * refactor: explicit channel id * refactor: rhs_search_nav * remove old no_results_indicator css * fix icon color * refactor: profile_popover action * comment line * use readily accessible channel id * dedupe * support explicit channelId in more places * update snapshots * graceful channel-less profile popover * Translations update from Weblate (#7776) * Translated using Weblate (Spanish) Currently translated at 98.7% (4436 of 4491 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/es/ Translated using Weblate (Spanish) Currently translated at 98.0% (4404 of 4490 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/es/ * Translated using Weblate (Spanish) Currently translated at 98.7% (4436 of 4491 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/es/ Translated using Weblate (Spanish) Currently translated at 98.0% (4404 of 4490 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/es/ * Translated using Weblate (French) Currently translated at 90.8% (4080 of 4491 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/fr/ Translated using Weblate (French) Currently translated at 90.5% (4066 of 4491 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/fr/ * Translated using Weblate (Dutch) Currently translated at 100.0% (4491 of 4491 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/nl/ * Translated using Weblate (Turkish) Currently translated at 100.0% (4491 of 4491 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/tr/ * Translated using Weblate (Russian) Currently translated at 91.9% (4129 of 4491 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ru/ Translated using Weblate (Russian) Currently translated at 90.9% (4084 of 4491 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ru/ * Added translation using Weblate (English (Australia)) * Translated using Weblate (English (Australia)) Currently translated at 100.0% (4491 of 4491 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/en_AU/ * Translated using Weblate (Chinese (Simplified)) Currently translated at 97.7% (4389 of 4491 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/zh_Hans/ * Translated using Weblate (Chinese (Traditional)) Currently translated at 90.5% (4066 of 4491 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/zh_Hant/ * Translated using Weblate (Korean) Currently translated at 79.2% (3560 of 4491 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ko/ * Deleted translation using Weblate (English (Australia)) * Translated using Weblate (French) Currently translated at 90.7% (4077 of 4491 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/fr/ * Translated using Weblate (Japanese) Currently translated at 99.5% (4472 of 4491 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/ja/ * Translated using Weblate (Swedish) Currently translated at 100.0% (4491 of 4491 strings) Translation: mattermost-languages-shipped/mattermost-webapp Translate-URL: https://translate.mattermost.com/projects/mattermost/mattermost-webapp_master/sv/ Co-authored-by: jesus.espino <[email protected]> Co-authored-by: Guillermo Vayá <[email protected]> Co-authored-by: Nathanaël <[email protected]> Co-authored-by: Tom De Moor <[email protected]> Co-authored-by: Kaya Zeren <[email protected]> Co-authored-by: Edward Smirnov <[email protected]> Co-authored-by: Matthew Williams <[email protected]> Co-authored-by: aeomin <[email protected]> Co-authored-by: Yao Xie <[email protected]> Co-authored-by: teamzamong <[email protected]> Co-authored-by: Pierre JENICOT <[email protected]> Co-authored-by: YorimiMochida <[email protected]> Co-authored-by: MArtin Johnson <[email protected]> * Make webapp build faster. (#7779) * Removing Beta from sv and bg (#7764) * Removing Beta from sv and bg * Updated the snapshots Co-authored-by: Tom De Moor <[email protected]> Co-authored-by: Mattermod <[email protected]> * MM-34055 Re-add border to Markdown preview (#7747) * MM-32882: Add an unread badge/marker to the Main Menu icon and the ‘Plugin Marketplace’ Menu Item (#7563) * [MM-34163][MM-34165] - UI fixes to direct channel profile pics (#7777) * [MM-34163] - UI fixes to direct channel profile pics * Update snapshot * increase status icon bg by 1px Co-authored-by: Nevyana Angelova <[email protected]> Co-authored-by: Weblate (bot) <[email protected]> Co-authored-by: Tom De Moor <[email protected]> Co-authored-by: Viorel-Cosmin Miron <[email protected]> Co-authored-by: aeomin <[email protected]> Co-authored-by: Ji-Hyeon Gim <[email protected]> Co-authored-by: Kaya Zeren <[email protected]> Co-authored-by: Nikolai Zahariev <[email protected]> Co-authored-by: Lucie Vrsovska <[email protected]> Co-authored-by: Mattermod <[email protected]> Co-authored-by: Scott Bishel <[email protected]> Co-authored-by: Pablo Andrés Vélez Vidal <[email protected]> Co-authored-by: Pablo Velez Vidal <[email protected]> Co-authored-by: Michel Engelen <[email protected]> Co-authored-by: Prapti <[email protected]> Co-authored-by: Ben Bodenmiller <[email protected]> Co-authored-by: Ben Cooke <[email protected]> Co-authored-by: Benjamin Cooke <[email protected]> Co-authored-by: Asaad Mahmood <[email protected]> Co-authored-by: Harrison Healey <[email protected]> Co-authored-by: Saturnino Abril <[email protected]> Co-authored-by: Guillermo Vayá <[email protected]> Co-authored-by: Jesse Hallam <[email protected]> Co-authored-by: Allan Guwatudde <[email protected]> Co-authored-by: Berke Kalkan <[email protected]> Co-authored-by: David Janda <[email protected]> Co-authored-by: Jyoti Patel <[email protected]> Co-authored-by: Elisabeth Kulzer <[email protected]> Co-authored-by: Michał Sobkiewicz <[email protected]> Co-authored-by: MArtin Johnson <[email protected]> Co-authored-by: kaakaa <[email protected]> Co-authored-by: Pierre JENICOT <[email protected]> Co-authored-by: Cyril LD <[email protected]> Co-authored-by: Markus Marcinek <[email protected]> Co-authored-by: jesus.espino <[email protected]> Co-authored-by: Nathanaël <[email protected]> Co-authored-by: Nev Angelova <[email protected]> Co-authored-by: Nevyana Angelova <[email protected]> Co-authored-by: Nevyana Angelova <[email protected]> Co-authored-by: Mario de Frutos Dieguez <[email protected]> Co-authored-by: Caleb Roseland <[email protected]> Co-authored-by: Max Erenberg <[email protected]> Co-authored-by: Jesús Espino <[email protected]> Co-authored-by: Hossein <[email protected]> Co-authored-by: Maria A Nunez <[email protected]> Co-authored-by: Guillermo Vayá <[email protected]> Co-authored-by: Edward Smirnov <[email protected]> Co-authored-by: Matthew Williams <[email protected]> Co-authored-by: Yao Xie <[email protected]> Co-authored-by: teamzamong <[email protected]> Co-authored-by: YorimiMochida <[email protected]> Co-authored-by: Elisabeth Kulzer <[email protected]> Co-authored-by: ctlaltdieliet <[email protected]> Co-authored-by: catalintomai <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
4: Reviews Complete
All reviewers have approved the pull request
Changelog/Not Needed
Does not require a changelog entry
Docs/Not Needed
Does not require documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
T3306_8 was failing because the logout button was not visible. Fixing this by scrolling the button into view.