This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-33397] revert lhs ID for backward compatibility #7617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 2, 2021 11:51
Willyfrog
added
2: Dev Review
amyblais
added
the
CherryPick/Approved
|
To be cherry-pick to |
nevyangelova
approved these changes
Mar 3, 2021
saturninoabril
approved these changes
Mar 3, 2021
There was a problem hiding this comment.
Thanks @Willyfrog and sorry for the hassle! Tested and passed. The mentioned failing spec is known issue and will be addressed separately.
saturninoabril
added
4: Reviews Complete
|
/cherry-pick cloud |
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
to mattermost-build/mattermost-webapp
that referenced
this pull request
Mar 3, 2021
* [MM-33397] revert name change * update snapshots Co-authored-by: = <=> (cherry picked from commit cb2c30d)
mattermod
added
CherryPick/Done
Willyfrog
added a commit
that referenced
this pull request
Mar 3, 2021
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
while the new name might fit better, the current and previous desktop app version use the id for detecting if the user is logged into Mattermost. Since we can't change current installations, we need to revert back to the previous ID and plan the change for future versions.
Ticket Link
MM-33397
Additional notes
@saturninoabril one of the e2e tests failed for me (browser_tab_notification_spec) but I don't think it was due to this change, can you take a look at it?