Custom Status E2E tests #7564

chetanyakan · 2021-02-22T09:47:10Z

Summary

Added cypress tests for status dropdown and custom status modal
Added two support functions in cypress with documentation
Added e2e tests for Custom Status modal and status dropdown according to spec.
Added documentation above the custom status modal file and moved it to match the group
Added CSS classes in custom status modal

Related Pull Requests

Has redux changes: Added EnableCustomStatuses in AdminConfig for cypress testing in webapp mattermost-redux#1369

Screenshots

cypress/integration/custom_status/custom_status_1_spec.js
cypress/integration/custom_status/custom_status_2_spec.js
cypress/integration/custom_status/custom_status_3_spec.js
cypress/integration/custom_status/custom_status_4_spec.js
cypress/integration/custom_status/custom_status_5_spec.js
cypress/integration/custom_status/custom_status_6_spec.js

mattermod · 2021-02-22T09:47:13Z

Hello @chetanyakan,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

devinbinnie

Thanks for the PR @chetanyakan!
I've added some comments for you to review.

components/custom_status/custom_status_modal.tsx

e2e/cypress/integration/menus/status_dropdown_spec.js

package-lock.json

e2e/cypress/integration/modals/custom_status_modal_spec.js

e2e/cypress/integration/menus/status_dropdown_spec.js

Added cypress tests for status dropdown and custom status modal Added two support functions in cypress with documentation Added some more tests in status dropdown Added some more tests in custom status modal Added documentation above the custom status modal file and moved it to match the group Refactored and added 3 major tests for the custom status tests Added some classes in custom status modal Refactored and removed some tests from the status dropdown spec

Co-authored-by: Harrison Healey <[email protected]>

- MM-T3851 Custom status CTAs for new users - MM-T3850 Verifying where the custom status appears - MM-T3852 Custom Status slash commands - Reverted changes of package-lock.json - Changed className to id in custom status modal and profile popover

chetanyakan · 2021-03-01T04:54:13Z

Rebased to HEAD of master.

devinbinnie

Thanks again @chetanyakan, this is looking good.
Just one more comment before I approve.

package-lock.json

devinbinnie

Looks good now, thanks @chetanyakan!

josephbaylon

Hi @chetanyakan ! Thanks for your contribution !! Here are some initial change requests.

The test file is huge and we want to try to minimize the number of tests in a file. Please break up the tests into several files as suggested below and don't include the // Stage: @prod into the new files.

Also, I'm getting several failures locally. Not sure which is causing which. Please make sure to run each separated test locally, grab a snapshot of each successful run and please include the snapshots in the PR description.

Here's a sample snapshot of a successful run you can take:

Thanks! I'll re-review once the above changes are committed.

e2e/cypress/integration/custom_status/custom_status_spec.js

Co-authored-by: Joseph Baylon <[email protected]>

chetanyakan · 2021-03-03T11:35:06Z

@josephbaylon Test case 4 has a weird behaviour.

It runs fine from the terminal, but fails when running from the cypress desktop app.

into cs-e2e

chetanyakan · 2021-03-04T08:25:35Z

Strangely, I get different results using different version of Cypress.

@josephbaylon Can you verify on your end if any of the custom status E2E tests are failing?

Fixed post header CSS which does not work in Electron Fixed issue with the recent custom statuses tests

josephbaylon

Hi @chetanyakan I retested locally and all tests pass for me locally! Thanks.

However, given that this is behind a feature flag, we cannot merge this until we set the value to true by default.

@ogi-m I'll approve the PR but I'll set the DO NOT MERGE label for now. We can revisit once the feature flag is enabled by default.

ogi-m

@josephbaylon The feature flag is now enabled on master by default, can it be merged now?

josephbaylon · 2021-03-13T22:34:39Z

/update-branch

mattermod · 2021-03-13T22:34:40Z

We don't have permissions to update this PR, please contact the submitter to apply the update.

josephbaylon · 2021-03-13T22:35:45Z

@hmhealey It seems like I lost rights to sync and merge. Please sync and merge. Thanks!

josephbaylon · 2021-03-13T22:36:15Z

/update-branch

mattermod · 2021-03-13T22:36:16Z

We don't have permissions to update this PR, please contact the submitter to apply the update.

saturninoabril · 2021-03-14T00:34:13Z

/update-branch

mattermod · 2021-03-14T00:34:14Z

We don't have permissions to update this PR, please contact the submitter to apply the update.

saturninoabril · 2021-03-14T04:47:44Z

@chetanyakan Reviews complete. Please update so we can merge. Thank you for your contribution!

… cs-e2e * 'master' of github.com:mattermost/mattermost-webapp: (26 commits) MM-33791 - add openId to check for account types (mattermost#7693) use theme variable for disabled select background (mattermost#7684) Fixed prod test cases (mattermost#7676) The pdf zoom level is store independently per file preview (mattermost#7635) fix broken test (mattermost#7694) Feature/MM 25430 show online status in channel switcher (mattermost#6609) [MM-31132] components/admin_console: enable metrics settings for TE (mattermost#7659) Added Guest account test cases (mattermost#7677) [MM-20397] Migrated the ChannelSelect component to TypeScript (mattermost#7436) [MM-33374] - Adding cloud license to dev environment causes sidebar menu to break (mattermost#7665) fixing group to channel modal (mattermost#7669) MM-33581 Fix off-by-one error in wrapEmojis (mattermost#7647) only apply theme variable in context of main app (mattermost#7649) MM-33661 Spurious "join private channel" warning fix (mattermost#7672) Translations update from Weblate (mattermost#7655) MM-23040: remove teamType prop from ChannelController (mattermost#7601) MM-3295 - remove no longer necessary validation (mattermost#7646) Disable check-deps ci step (mattermost#7657) fix group modal tests (mattermost#7513) [MM-33033] Use box-shadow for create post border instead of border (mattermost#7627) ...

chetanyakan · 2021-03-15T07:54:44Z

@saturninoabril @josephbaylon Updated the branch.

esethna requested a review from ogi-m February 22, 2021 15:37

michelengelen requested review from hmhealey and devinbinnie February 22, 2021 18:34

michelengelen added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Feb 22, 2021

devinbinnie suggested changes Feb 22, 2021

View reviewed changes

hmhealey reviewed Feb 22, 2021

View reviewed changes

e2e/cypress/integration/menus/status_dropdown_spec.js Outdated Show resolved Hide resolved

e2e/cypress/integration/menus/status_dropdown_spec.js Outdated Show resolved Hide resolved

e2e/cypress/integration/menus/status_dropdown_spec.js Outdated Show resolved Hide resolved

manojmalik20 and others added 3 commits March 1, 2021 10:19

Update e2e/cypress/integration/menus/status_dropdown_spec.js

421ecca

Co-authored-by: Harrison Healey <[email protected]>

Custom Status e2e tests (#38)

e9b74c9

- MM-T3851 Custom status CTAs for new users - MM-T3850 Verifying where the custom status appears - MM-T3852 Custom Status slash commands - Reverted changes of package-lock.json - Changed className to id in custom status modal and profile popover

chetanyakan force-pushed the cs-e2e branch from 66a5f5a to e9b74c9 Compare March 1, 2021 04:53

chetanyakan requested review from devinbinnie and hmhealey March 1, 2021 04:54

devinbinnie suggested changes Mar 1, 2021

View reviewed changes

package-lock.json Outdated Show resolved Hide resolved

Revert changes to package-lock.json

62ec5e7

chetanyakan requested a review from devinbinnie March 1, 2021 13:35

devinbinnie approved these changes Mar 1, 2021

View reviewed changes

hmhealey approved these changes Mar 2, 2021

View reviewed changes

hmhealey removed the 2: Dev Review Requires review by a core commiter label Mar 2, 2021

josephbaylon self-requested a review March 2, 2021 18:50

josephbaylon suggested changes Mar 2, 2021

View reviewed changes

chetanyakan and others added 3 commits March 3, 2021 00:54

Update e2e/cypress/integration/custom_status/custom_status_spec.js

2c6c8e8

Co-authored-by: Joseph Baylon <[email protected]>

Apply suggestions from code review

a107ab3

Co-authored-by: Joseph Baylon <[email protected]>

Refactor to multiple spec files

c26b6a6

Merge branch 'master' of https://github.com/mattermost/mattermost-webapp

f981886

into cs-e2e

chetanyakan requested a review from josephbaylon March 4, 2021 08:25

Fixed the E2E tests

3f68ea9

Fixed post header CSS which does not work in Electron Fixed issue with the recent custom statuses tests

josephbaylon approved these changes Mar 4, 2021

View reviewed changes

hahmadia added Work in Progress Not yet ready for review and removed Work in Progress Not yet ready for review labels Mar 4, 2021

ogi-m approved these changes Mar 9, 2021

View reviewed changes

ogi-m added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Mar 9, 2021

josephbaylon removed the Do Not Merge Should not be merged until this label is removed label Mar 13, 2021

Joseph Baylon and others added 2 commits March 15, 2021 13:07

Cypress/E2E: Fix channel name tooltips (mattermost#7633)

399975b

saturninoabril merged commit 0918d78 into mattermost:master Mar 15, 2021

chetanyakan deleted the cs-e2e branch March 15, 2021 07:58

amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Mar 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom Status E2E tests #7564

Custom Status E2E tests #7564

chetanyakan commented Feb 22, 2021 •

edited

Loading

mattermod commented Feb 22, 2021

devinbinnie left a comment

chetanyakan commented Mar 1, 2021

devinbinnie left a comment

devinbinnie left a comment

josephbaylon left a comment •

edited

Loading

chetanyakan commented Mar 3, 2021

chetanyakan commented Mar 4, 2021

josephbaylon left a comment

ogi-m left a comment

josephbaylon commented Mar 13, 2021

mattermod commented Mar 13, 2021

josephbaylon commented Mar 13, 2021

josephbaylon commented Mar 13, 2021

mattermod commented Mar 13, 2021

saturninoabril commented Mar 14, 2021

mattermod commented Mar 14, 2021

saturninoabril commented Mar 14, 2021

chetanyakan commented Mar 15, 2021

Custom Status E2E tests #7564

Custom Status E2E tests #7564

Conversation

chetanyakan commented Feb 22, 2021 • edited Loading

Summary

Related Links

Related Pull Requests

Screenshots

mattermod commented Feb 22, 2021

devinbinnie left a comment

Choose a reason for hiding this comment

chetanyakan commented Mar 1, 2021

devinbinnie left a comment

Choose a reason for hiding this comment

devinbinnie left a comment

Choose a reason for hiding this comment

josephbaylon left a comment • edited Loading

Choose a reason for hiding this comment

chetanyakan commented Mar 3, 2021

chetanyakan commented Mar 4, 2021

josephbaylon left a comment

Choose a reason for hiding this comment

ogi-m left a comment

Choose a reason for hiding this comment

josephbaylon commented Mar 13, 2021

mattermod commented Mar 13, 2021

josephbaylon commented Mar 13, 2021

josephbaylon commented Mar 13, 2021

mattermod commented Mar 13, 2021

saturninoabril commented Mar 14, 2021

mattermod commented Mar 14, 2021

saturninoabril commented Mar 14, 2021

chetanyakan commented Mar 15, 2021

chetanyakan commented Feb 22, 2021 •

edited

Loading

josephbaylon left a comment •

edited

Loading