-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Conversation
/update-branch |
* implement experimental sub sections * update admin definition * update experimental features * fix lint and translations * add s to feature flags * fix snapshots * update redux * update snpashot * fix linting * fix cypress tests * update package json and package lock * update e2e * Update package.json
/update-branch |
Error trying to update the PR. |
/update-branch |
Error trying to update the PR. |
/update-branch |
/update-branch |
/update-branch |
Error trying to update the PR. |
…Backend (#7628) * Remove Ancillary Permissions on FrontEnd * update updatedRolePermisisons Co-authored-by: Mattermod <[email protected]>
* Add about section * add tests * update snapshots * lint fix * update packagelock * update mattermost-redux * Update en.json * update tests Co-authored-by: Mattermod <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, nice job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issued #1 has been tested, working as expected.
I have created different tickets for other two issues.
Everything else looks good
/update-branch |
/cherry-pick cloud |
Cherry pick is scheduled. |
* Initial Commit * clear slate * [MM-32352] Add Experiment Sub Section FRONTEND (mattermost#7475) * implement experimental sub sections * update admin definition * update experimental features * fix lint and translations * add s to feature flags * fix snapshots * update redux * update snpashot * fix linting * fix cypress tests * update package json and package lock * update e2e * Update package.json * [MM-35501] Remove Determining Ancillary Permissions from Frontend to Backend (mattermost#7628) * Remove Ancillary Permissions on FrontEnd * update updatedRolePermisisons Co-authored-by: Mattermod <[email protected]> * update package json * remove props * [MM-32799] Add About SubSections (mattermost#7593) * Add about section * add tests * update snapshots * lint fix * update packagelock * update mattermost-redux * Update en.json * update tests Co-authored-by: Mattermod <[email protected]> * update package json * fix snapshot * [MM-32794] Reporting Sub Section (mattermost#7615) * frontend changes * add tests * update snpashots * linting fix * update package and package lock * update redux * fix snapshot * [MM-32343] Environment SubSection (mattermost#7622) * add environment permissions * pre-merge commit * add Cypress tests * add suggestions from BenCookie95 * add suggestions from hahmadia * update test snapshots * remove TEST_* permissions from read-only manager * add Redux PR commit hash * fix incorrect permissions in admin_definition.jsx * update redux * update redux for merged Co-authored-by: Mattermod <[email protected]> Co-authored-by: Scott Bishel <[email protected]> * MM-32351: Add Compliance Subsections (mattermost#7596) * add subsections for compliance section * update redux * fix package.json * update redux * fix test, update constants * add _policy to data_retention * update redux * update redux * update package json Co-authored-by: Mattermod <[email protected]> Co-authored-by: Hossein Ahmadian-Yazdi <[email protected]> * MM-32347 Site Subsections (mattermost#7666) * Site Subsection changes * Fixed file and download link * Update components/admin_console/admin_definition.jsx Co-authored-by: Scott Bishel <[email protected]> * update redux hash * Reverted code format change * update redux * update redux * remove deprecated permissions, fix tests * update redux * update redux Co-authored-by: Scott Bishel <[email protected]> Co-authored-by: Hossein <[email protected]> Co-authored-by: Hossein Ahmadian-Yazdi <[email protected]> * MM-32350 - Integrations (mattermost#7671) * fix snapshot tests * Adding subsection permissions for Authentication (mattermost#7660) * new permissions for authentication * adding tests * translations * removing unused permissions * spelling mistake * adding redux changes * updating snapshots * updating redux sha * updating snapshot * fixing PR comments * fixing PR comments * removing additional permission check when using it.isSystemAdmin * updating sha * removing duplicate translation * fixing test * updating snapshot and redux * Update package.json * fix snapshot * change order back to what it was * update package json * fix a couple bugs * fix lint * fix unit test Co-authored-by: Benjamin Cooke <[email protected]> Co-authored-by: Hossein Ahmadian-Yazdi <[email protected]> Co-authored-by: Mattermod <[email protected]> Co-authored-by: Scott Bishel <[email protected]> * Undo package stuff * migrate redux-changes * fix linting * fix bugs * use props.isDisabled * address comments * update snapshot * fix logic * fix spelling Co-authored-by: Mattermod <[email protected]> Co-authored-by: Max Erenberg <[email protected]> Co-authored-by: Scott Bishel <[email protected]> Co-authored-by: Anurag Shivarathri <[email protected]> Co-authored-by: Ben Cooke <[email protected]> Co-authored-by: Benjamin Cooke <[email protected]> (cherry picked from commit 723ead1)
* Initial Commit * clear slate * [MM-32352] Add Experiment Sub Section FRONTEND (#7475) * implement experimental sub sections * update admin definition * update experimental features * fix lint and translations * add s to feature flags * fix snapshots * update redux * update snpashot * fix linting * fix cypress tests * update package json and package lock * update e2e * Update package.json * [MM-35501] Remove Determining Ancillary Permissions from Frontend to Backend (#7628) * Remove Ancillary Permissions on FrontEnd * update updatedRolePermisisons Co-authored-by: Mattermod <[email protected]> * update package json * remove props * [MM-32799] Add About SubSections (#7593) * Add about section * add tests * update snapshots * lint fix * update packagelock * update mattermost-redux * Update en.json * update tests Co-authored-by: Mattermod <[email protected]> * update package json * fix snapshot * [MM-32794] Reporting Sub Section (#7615) * frontend changes * add tests * update snpashots * linting fix * update package and package lock * update redux * fix snapshot * [MM-32343] Environment SubSection (#7622) * add environment permissions * pre-merge commit * add Cypress tests * add suggestions from BenCookie95 * add suggestions from hahmadia * update test snapshots * remove TEST_* permissions from read-only manager * add Redux PR commit hash * fix incorrect permissions in admin_definition.jsx * update redux * update redux for merged Co-authored-by: Mattermod <[email protected]> Co-authored-by: Scott Bishel <[email protected]> * MM-32351: Add Compliance Subsections (#7596) * add subsections for compliance section * update redux * fix package.json * update redux * fix test, update constants * add _policy to data_retention * update redux * update redux * update package json Co-authored-by: Mattermod <[email protected]> Co-authored-by: Hossein Ahmadian-Yazdi <[email protected]> * MM-32347 Site Subsections (#7666) * Site Subsection changes * Fixed file and download link * Update components/admin_console/admin_definition.jsx Co-authored-by: Scott Bishel <[email protected]> * update redux hash * Reverted code format change * update redux * update redux * remove deprecated permissions, fix tests * update redux * update redux Co-authored-by: Scott Bishel <[email protected]> Co-authored-by: Hossein <[email protected]> Co-authored-by: Hossein Ahmadian-Yazdi <[email protected]> * MM-32350 - Integrations (#7671) * fix snapshot tests * Adding subsection permissions for Authentication (#7660) * new permissions for authentication * adding tests * translations * removing unused permissions * spelling mistake * adding redux changes * updating snapshots * updating redux sha * updating snapshot * fixing PR comments * fixing PR comments * removing additional permission check when using it.isSystemAdmin * updating sha * removing duplicate translation * fixing test * updating snapshot and redux * Update package.json * fix snapshot * change order back to what it was * update package json * fix a couple bugs * fix lint * fix unit test Co-authored-by: Benjamin Cooke <[email protected]> Co-authored-by: Hossein Ahmadian-Yazdi <[email protected]> Co-authored-by: Mattermod <[email protected]> Co-authored-by: Scott Bishel <[email protected]> * Undo package stuff * migrate redux-changes * fix linting * fix bugs * use props.isDisabled * address comments * update snapshot * fix logic * fix spelling Co-authored-by: Mattermod <[email protected]> Co-authored-by: Max Erenberg <[email protected]> Co-authored-by: Scott Bishel <[email protected]> Co-authored-by: Anurag Shivarathri <[email protected]> Co-authored-by: Ben Cooke <[email protected]> Co-authored-by: Benjamin Cooke <[email protected]> (cherry picked from commit 723ead1) Co-authored-by: Hossein <[email protected]>
Documentation for: - mattermost/mattermost#16917 - mattermost/mattermost-webapp#7518 Updated: - Self-Managed Admin Guide > Onboard Users > Additional System Roles (Beta) - Replaced existing bulleted list of permissions with table listing more granular permission per subsection
Documentation for: - mattermost/mattermost#16917 - mattermost/mattermost-webapp#7518 Updated: - Self-Managed Admin Guide > Onboard Users > Additional System Roles (Beta) - Replaced existing bulleted list of permissions with table listing more granular permission per subsection Co-authored-by: Hossein <[email protected]>
@hahmadia: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. I understand the commands that are listed here |
Summary
Ultimate PR to merge all Sections-To-SubSection PR's.
The goal of this PR is to merge all of the section-to-subsection migrations at once into master.
We do not want to merge each PR one at time into master (due to cloud release and it hence it will seem incomplete), we've created this branch which all the individual PR's can be merged into and then this PR can be merged in at once into master.
This branch includes all the following:
Experimental:
About:
Reporting:
Environment:
Site Configuration:
Authentication:
Integrations:
Compliance:
Other PR's required
Determining Ancillary Permissions on Backend rather than Frontend:
PR's required to be merged before this