Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

All Sections to SubSections #7518

Merged
merged 44 commits into from
Apr 6, 2021
Merged

All Sections to SubSections #7518

merged 44 commits into from
Apr 6, 2021

Conversation

hahmadia
Copy link
Contributor

@hahmadia hahmadia commented Feb 11, 2021

Summary

Ultimate PR to merge all Sections-To-SubSection PR's.
The goal of this PR is to merge all of the section-to-subsection migrations at once into master.
We do not want to merge each PR one at time into master (due to cloud release and it hence it will seem incomplete), we've created this branch which all the individual PR's can be merged into and then this PR can be merged in at once into master.

This branch includes all the following:

Experimental:

About:

Reporting:

Environment:

Site Configuration:

Authentication:

Integrations:

Compliance:

Other PR's required

Determining Ancillary Permissions on Backend rather than Frontend:

PR's required to be merged before this

@hahmadia hahmadia added the Work in Progress Not yet ready for review label Feb 11, 2021
@hahmadia hahmadia changed the title Initial Commit All Sections to SubSections Feb 11, 2021
@hahmadia
Copy link
Contributor Author

/update-branch

mattermod and others added 2 commits February 16, 2021 15:02
* implement experimental sub sections

* update admin definition

* update experimental features

* fix lint and translations

* add s to feature flags

* fix snapshots

* update redux

* update snpashot

* fix linting

* fix cypress tests

* update package json and package lock

* update e2e

* Update package.json
@hahmadia
Copy link
Contributor Author

/update-branch

@mattermod
Copy link
Contributor

Error trying to update the PR.
Please do it manually.

@hahmadia
Copy link
Contributor Author

/update-branch

@mattermod
Copy link
Contributor

Error trying to update the PR.
Please do it manually.

@hahmadia
Copy link
Contributor Author

hahmadia commented Mar 3, 2021

/update-branch

@hahmadia hahmadia added the Docs/Needed Requires documentation label Mar 3, 2021
@hahmadia
Copy link
Contributor Author

hahmadia commented Mar 4, 2021

/update-branch

@hahmadia
Copy link
Contributor Author

hahmadia commented Mar 5, 2021

/update-branch

@mattermod
Copy link
Contributor

Error trying to update the PR.
Please do it manually.

hahmadia and others added 8 commits March 8, 2021 09:21
…Backend (#7628)

* Remove Ancillary Permissions on FrontEnd

* update updatedRolePermisisons

Co-authored-by: Mattermod <[email protected]>
* Add about section

* add tests

* update snapshots

* lint fix

* update packagelock

* update mattermost-redux

* Update en.json

* update tests

Co-authored-by: Mattermod <[email protected]>
Copy link
Contributor

@BenCookie95 BenCookie95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, nice job!

Copy link
Contributor

@furqanmlk furqanmlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issued #1 has been tested, working as expected.
I have created different tickets for other two issues.
Everything else looks good

@sbishel
Copy link
Member

sbishel commented Mar 31, 2021

/update-branch

@hahmadia hahmadia added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) labels Mar 31, 2021
@hahmadia hahmadia merged commit 723ead1 into master Apr 6, 2021
@hahmadia hahmadia deleted the SectionsToSubSections branch April 6, 2021 14:40
@amyblais amyblais added the Changelog/Done Required changelog entry has been written label Apr 7, 2021
@amyblais amyblais added this to the v5.35 milestone Apr 7, 2021
@ethervoid
Copy link
Contributor

/cherry-pick cloud

@mattermod
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit to mattermost-build/mattermost-webapp that referenced this pull request Apr 12, 2021
* Initial Commit

* clear slate

* [MM-32352] Add Experiment Sub Section FRONTEND (mattermost#7475)

* implement experimental sub sections

* update admin definition

* update experimental features

* fix lint and translations

* add s to feature flags

* fix snapshots

* update redux

* update snpashot

* fix linting

* fix cypress tests

* update package json and package lock

* update e2e

* Update package.json

* [MM-35501] Remove Determining Ancillary Permissions from Frontend to Backend (mattermost#7628)

* Remove Ancillary Permissions on FrontEnd

* update updatedRolePermisisons

Co-authored-by: Mattermod <[email protected]>

* update package json

* remove props

* [MM-32799] Add About SubSections (mattermost#7593)

* Add about section

* add tests

* update snapshots

* lint fix

* update packagelock

* update mattermost-redux

* Update en.json

* update tests

Co-authored-by: Mattermod <[email protected]>

* update package json

* fix snapshot

* [MM-32794] Reporting Sub Section (mattermost#7615)

* frontend changes

* add tests

* update snpashots

* linting fix

* update package and package lock

* update redux

* fix snapshot

* [MM-32343] Environment SubSection (mattermost#7622)

* add environment permissions

* pre-merge commit

* add Cypress tests

* add suggestions from BenCookie95

* add suggestions from hahmadia

* update test snapshots

* remove TEST_* permissions from read-only manager

* add Redux PR commit hash

* fix incorrect permissions in admin_definition.jsx

* update redux

* update redux for merged

Co-authored-by: Mattermod <[email protected]>
Co-authored-by: Scott Bishel <[email protected]>

* MM-32351: Add Compliance Subsections (mattermost#7596)

* add subsections for compliance section

* update redux

* fix package.json

* update redux

* fix test, update constants

* add _policy to data_retention

* update redux

* update redux

* update package json

Co-authored-by: Mattermod <[email protected]>
Co-authored-by: Hossein Ahmadian-Yazdi <[email protected]>

* MM-32347 Site Subsections (mattermost#7666)

* Site Subsection changes

* Fixed file and download link

* Update components/admin_console/admin_definition.jsx

Co-authored-by: Scott Bishel <[email protected]>

* update redux hash

* Reverted code format change

* update redux

* update redux

* remove deprecated permissions, fix tests

* update redux

* update redux

Co-authored-by: Scott Bishel <[email protected]>
Co-authored-by: Hossein <[email protected]>
Co-authored-by: Hossein Ahmadian-Yazdi <[email protected]>

* MM-32350 - Integrations (mattermost#7671)

* fix snapshot tests

* Adding subsection permissions for Authentication (mattermost#7660)

* new permissions for authentication

* adding tests

* translations

* removing unused permissions

* spelling mistake

* adding redux changes

* updating snapshots

* updating redux sha

* updating snapshot

* fixing PR comments

* fixing PR comments

* removing additional permission check when using it.isSystemAdmin

* updating sha

* removing duplicate translation

* fixing test

* updating snapshot and redux

* Update package.json

* fix snapshot

* change order back to what it was

* update package json

* fix a couple bugs

* fix lint

* fix unit test

Co-authored-by: Benjamin Cooke <[email protected]>
Co-authored-by: Hossein Ahmadian-Yazdi <[email protected]>
Co-authored-by: Mattermod <[email protected]>
Co-authored-by: Scott Bishel <[email protected]>

* Undo package stuff

* migrate redux-changes

* fix linting

* fix bugs

* use props.isDisabled

* address comments

* update snapshot

* fix logic

* fix spelling

Co-authored-by: Mattermod <[email protected]>
Co-authored-by: Max Erenberg <[email protected]>
Co-authored-by: Scott Bishel <[email protected]>
Co-authored-by: Anurag Shivarathri <[email protected]>
Co-authored-by: Ben Cooke <[email protected]>
Co-authored-by: Benjamin Cooke <[email protected]>
(cherry picked from commit 723ead1)
@mattermod mattermod added the CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone label Apr 12, 2021
ethervoid pushed a commit that referenced this pull request Apr 12, 2021
* Initial Commit

* clear slate

* [MM-32352] Add Experiment Sub Section FRONTEND (#7475)

* implement experimental sub sections

* update admin definition

* update experimental features

* fix lint and translations

* add s to feature flags

* fix snapshots

* update redux

* update snpashot

* fix linting

* fix cypress tests

* update package json and package lock

* update e2e

* Update package.json

* [MM-35501] Remove Determining Ancillary Permissions from Frontend to Backend (#7628)

* Remove Ancillary Permissions on FrontEnd

* update updatedRolePermisisons

Co-authored-by: Mattermod <[email protected]>

* update package json

* remove props

* [MM-32799] Add About SubSections (#7593)

* Add about section

* add tests

* update snapshots

* lint fix

* update packagelock

* update mattermost-redux

* Update en.json

* update tests

Co-authored-by: Mattermod <[email protected]>

* update package json

* fix snapshot

* [MM-32794] Reporting Sub Section (#7615)

* frontend changes

* add tests

* update snpashots

* linting fix

* update package and package lock

* update redux

* fix snapshot

* [MM-32343] Environment SubSection (#7622)

* add environment permissions

* pre-merge commit

* add Cypress tests

* add suggestions from BenCookie95

* add suggestions from hahmadia

* update test snapshots

* remove TEST_* permissions from read-only manager

* add Redux PR commit hash

* fix incorrect permissions in admin_definition.jsx

* update redux

* update redux for merged

Co-authored-by: Mattermod <[email protected]>
Co-authored-by: Scott Bishel <[email protected]>

* MM-32351: Add Compliance Subsections (#7596)

* add subsections for compliance section

* update redux

* fix package.json

* update redux

* fix test, update constants

* add _policy to data_retention

* update redux

* update redux

* update package json

Co-authored-by: Mattermod <[email protected]>
Co-authored-by: Hossein Ahmadian-Yazdi <[email protected]>

* MM-32347 Site Subsections (#7666)

* Site Subsection changes

* Fixed file and download link

* Update components/admin_console/admin_definition.jsx

Co-authored-by: Scott Bishel <[email protected]>

* update redux hash

* Reverted code format change

* update redux

* update redux

* remove deprecated permissions, fix tests

* update redux

* update redux

Co-authored-by: Scott Bishel <[email protected]>
Co-authored-by: Hossein <[email protected]>
Co-authored-by: Hossein Ahmadian-Yazdi <[email protected]>

* MM-32350 - Integrations (#7671)

* fix snapshot tests

* Adding subsection permissions for Authentication (#7660)

* new permissions for authentication

* adding tests

* translations

* removing unused permissions

* spelling mistake

* adding redux changes

* updating snapshots

* updating redux sha

* updating snapshot

* fixing PR comments

* fixing PR comments

* removing additional permission check when using it.isSystemAdmin

* updating sha

* removing duplicate translation

* fixing test

* updating snapshot and redux

* Update package.json

* fix snapshot

* change order back to what it was

* update package json

* fix a couple bugs

* fix lint

* fix unit test

Co-authored-by: Benjamin Cooke <[email protected]>
Co-authored-by: Hossein Ahmadian-Yazdi <[email protected]>
Co-authored-by: Mattermod <[email protected]>
Co-authored-by: Scott Bishel <[email protected]>

* Undo package stuff

* migrate redux-changes

* fix linting

* fix bugs

* use props.isDisabled

* address comments

* update snapshot

* fix logic

* fix spelling

Co-authored-by: Mattermod <[email protected]>
Co-authored-by: Max Erenberg <[email protected]>
Co-authored-by: Scott Bishel <[email protected]>
Co-authored-by: Anurag Shivarathri <[email protected]>
Co-authored-by: Ben Cooke <[email protected]>
Co-authored-by: Benjamin Cooke <[email protected]>
(cherry picked from commit 723ead1)

Co-authored-by: Hossein <[email protected]>
cwarnermm added a commit to mattermost/docs that referenced this pull request Apr 23, 2021
Documentation for: 
- mattermost/mattermost#16917
- mattermost/mattermost-webapp#7518

Updated:
- Self-Managed Admin Guide > Onboard Users > Additional System Roles (Beta)
   - Replaced existing bulleted list of permissions with table listing more granular permission per subsection
justinegeffen pushed a commit to mattermost/docs that referenced this pull request Apr 26, 2021
Documentation for: 
- mattermost/mattermost#16917
- mattermost/mattermost-webapp#7518

Updated:
- Self-Managed Admin Guide > Onboard Users > Additional System Roles (Beta)
   - Replaced existing bulleted list of permissions with table listing more granular permission per subsection

Co-authored-by: Hossein <[email protected]>
@cwarnermm cwarnermm added Docs/Done Required documentation has been written and removed Docs/Needed Requires documentation labels Apr 26, 2021
@mm-cloud-bot
Copy link

@hahmadia: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone do-not-merge/release-note-label-needed Docs/Done Required documentation has been written
Projects
None yet