This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
ABC-193: Add webapp commit hash to "about" modal #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccbrown
added
1: PM Review
jasonblais
added
Setup Old Test Server
|
@ccbrown Looks like the build failed, |
|
@jasonblais fixed. |
jasonblais
removed
the
Setup Old Test Server
|
Tested at different screen widths and zoom levels. @ccbrown Only question is whether it's obvious the |
crspeller
approved these changes
Feb 8, 2018
|
@jasonblais 🤷♂️ I think it's at least more obvious than it was before now that the webapp hash is also there. Being labeled "webapp", it kinda implies that the others aren't webapp. |
jasonblais
approved these changes
Feb 8, 2018
jasonblais
removed
1: PM Review
hmhealey
approved these changes
Feb 9, 2018
amyblais
added
Changelog/Done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket Link
https://mattermost.atlassian.net/browse/ABC-193
Checklist
make check-styleto check for style errors (required for all pull requests)