Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Cypress/E2E: Separate TM4J keys for team and enterprise of site statistics #7400

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

saturninoabril
Copy link
Member

Summary

Separate TM4J keys for team and enterprise of site statistics

  • remain MM-T904 for enterprise, and
  • add MM-T3804 for team edition

@saturninoabril saturninoabril added the 3: QA Review Requires review by a QA tester label Jan 26, 2021
Copy link
Contributor

@furqanmlk furqanmlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes 👍
All looks good

Copy link
Contributor

@prapti prapti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Should T904 also be moved in TM4J under the "Enterprise" folder?

@prapti prapti added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jan 27, 2021
@prapti prapti merged commit abef5eb into mattermost:master Jan 27, 2021
@saturninoabril saturninoabril deleted the fix-tm4j-key branch January 27, 2021 08:11
@saturninoabril
Copy link
Member Author

@prapti I think we have many cases like this where some test require a license for some TM4J folder. The current convention we have is to remain as is in TM4J and then only organize in Cypress by having the same subfolder structure inside /enterprise folder. Very much open to discussion/changes on how we'd like to organize moving forward and that might be good topic in QA meeting.

@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants