Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Cypress/E2E: Fix time out error on initial Cypress run against remote server #7385

Merged

Conversation

saturninoabril
Copy link
Member

Summary

Fix time out error on initial Cypress run against remote server. Note that the time out error is not related to product changes but most likely related to initial access by newly created admin user against newly created remote server in CI. It might be something to do with DNS propagation but will investigate further. For the meantime, the solution here works 100% of the time.

Ticket Link

none, failing on daily Cypress run

@saturninoabril saturninoabril added the 3: QA Review Requires review by a QA tester label Jan 24, 2021
Copy link
Contributor

@josephbaylon josephbaylon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Code changes look straightforward.

Copy link
Contributor

@furqanmlk furqanmlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @saturninoabril
Changes look good to me !

@saturninoabril saturninoabril added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jan 25, 2021
@saturninoabril saturninoabril merged commit 86561d6 into mattermost:master Jan 25, 2021
@saturninoabril saturninoabril deleted the e2e-fix-timeout-error branch January 25, 2021 17:09
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jan 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants