ICU-672 Fix undefined id error

[stephenkiers]

Summary

This fixes a cannot read 'id' of undefined error in webapp. It seems like the issue was old code was refactored, but old code was left in. So I cleaned out the code rot and everything still seems to work.

Ticket Link

https://mattermost.atlassian.net/browse/ICU-672

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• Ran make check-style to check for style errors (required for all pull requests)

Youtube video of testing feature still works

https://www.youtube.com/watch?v=oVPdOhNjP3E

[saturninoabril]

Does removing updateChannel will not cause any side-effect?
Why not just get the channel name from props.match.params and use it accordingly?

    const {team, identifier} = props.match.params;
    const channelName = identifier.toLowerCase();

[hmhealey]

It looks like it may break the "fake channel" logic, but I don't actually know if that's been used for a long time. We had it in there for when we'd show random users in your DM list on first sign up even if the channels for them didn't exist so that we could create those channels when you did click on them.

I was actually wondering yesterday if we can just remove all that logic since I think that was the only place we used them, and we haven't automatically added DM users for a long time

[stephenkiers]

ok. I will remove fake channel logic and retest.

[hmhealey]

I think we could just make a ticket and go with these changes if they work. The fake channel logic is split across the redux and web app, and it might even be in the mobile app even though that logic was removed probably 2 years ago

[saturninoabril]

Thanks for clearing up!

[crspeller]

Looks good. As Harrison pointed out I don't think we need to fake channel logic any more. Also clearly this case is handed somewhere else, judging by your YouTube video.

[esethna]

@stephenkiers please help rebase to release-4.7 as this will go in RC2

[hmhealey]

We're going to make a ticket to remove the rest of the fake channel logic for 4.8