This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[MM-32173] Hide the experimental settings when the legacy sidebar is disabled #7349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @devinbinnie
|
jgilliam17
approved these changes
Jan 20, 2021
hmhealey
approved these changes
Jan 20, 2021
@amyblais for v5.32 ^ |
deanwhillier
approved these changes
Jan 20, 2021
Cherry pick is scheduled. |
Test server destroyed |
1 similar comment
Test server destroyed |
Error trying doing the automated Cherry picking. Please do this manually
|
/cherry-pick cloud |
Cherry pick is scheduled. |
mattermost-build
pushed a commit
to mattermost-build/mattermost-webapp
that referenced
this pull request
Jan 20, 2021
…disabled (mattermost#7349) * [MM-32173] Hide the experimental settings when the legacy sidebar is disabled * Fix translation (cherry picked from commit dfb8860)
devinbinnie
added a commit
that referenced
this pull request
Jan 21, 2021
…disabled (#7349) (#7358) * [MM-32173] Hide the experimental settings when the legacy sidebar is disabled * Fix translation (cherry picked from commit dfb8860) Co-authored-by: Devin Binnie <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
4: Reviews Complete
All reviewers have approved the pull request
Changelog/Not Needed
Does not require a changelog entry
CherryPick/Done
Successfully cherry-picked to the quality or patch release tracked in the milestone
Docs/Not Needed
Does not require documentation
QA Review Done
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the legacy sidebar was not enabled in the System Console, and then re-enabled afterwards, the existing settings for the experimental channel organization, auto closing DMs, and any other setting dependent on the old sidebar would be blown away and reset to
false
.This PR instead hides those settings so that they aren't blown away when the user updates the config and those settings become re-enabled.
Ticket Link
https://mattermost.atlassian.net/browse/MM-32173