This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Migrate message_attachments folder to Typescript #7339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larkox
added
2: Dev Review
hmhealey
reviewed
Jan 20, 2021
...t_view/message_attachments/message_attachment/__snapshots__/message_attachment.test.tsx.snap
Show resolved
Hide resolved
larkox
commented
Jan 20, 2021
...t_view/message_attachments/message_attachment/__snapshots__/message_attachment.test.tsx.snap
Show resolved
Hide resolved
larkox
commented
Jan 20, 2021
...t_view/message_attachments/message_attachment/__snapshots__/message_attachment.test.tsx.snap
Show resolved
Hide resolved
hmhealey
approved these changes
Jan 20, 2021
mickmister
approved these changes
Jan 26, 2021
jgilliam17
added
the
Setup Cloud Test Server
jgilliam17
approved these changes
Jan 28, 2021
There was a problem hiding this comment.
Thank you @larkox
Tested, looks good to merge.
- Verified post message attachments - aa expected.
jgilliam17
added
4: Reviews Complete
|
Test server destroyed |
amyblais
added
Changelog/Not Needed
chetanyakan
added a commit
to brightscout-alpha/mattermost-webapp
that referenced
this pull request
Feb 2, 2021
… MM-2020 * 'master' of github.com:mattermost/mattermost-webapp: (175 commits) fix/update failed E2E tests (mattermost#7430) [MM-31791] Support Packet Generation FRONTEND (mattermost#7314) [MM-32269] System Console: TeamIcon edge cases (mattermost#7395) update steps for google openid (mattermost#7327) git checkout -b fix-slash-commands-tm4j (mattermost#7397) MM-31646: Update Office instructions (mattermost#7326) Cypress/E2E: Fix tests for archived channels (mattermost#7424) Cypress/E2E: Fix tests for bots in list and in sidebar (mattermost#7421) [MM-29108] Simplifies emoji reaction animation (mattermost#7386) Cypress/E2E: Overwrite cy.visit and cy.reload to have default 3s wait (mattermost#7410) [MM-22369] Filter out ldap group sync teams when adding a team to a user (mattermost#7324) MM 31192 - license renewal telemetry (mattermost#7413) Migrate message_attachments folder to Typescript (mattermost#7339) Cypress/E2E: Fix and reorganize tests for custom emojis (mattermost#7415) promote tests with 23 tm4j test cases (mattermost#7402) fix failed tests due to recent change in add users modal (mattermost#7398) fix for more channels and auth specs (mattermost#7416) fix e2e for sidebar channels (mattermost#7412) remove duplicate MM-T3294, fix MM-T1253 and fix/reorganize other keyboard shortcuts tests (mattermost#7390) MM-31735 - ReDisplay OpenID Connect (mattermost#7325) ...
chetanyakan
added a commit
to brightscout-alpha/mattermost-webapp
that referenced
this pull request
Feb 2, 2021
* custom-status-1: (153 commits) Revert "Custom status base (#19)" Custom status base (#19) fix/update failed E2E tests (mattermost#7430) [MM-31791] Support Packet Generation FRONTEND (mattermost#7314) [MM-32269] System Console: TeamIcon edge cases (mattermost#7395) update steps for google openid (mattermost#7327) git checkout -b fix-slash-commands-tm4j (mattermost#7397) MM-31646: Update Office instructions (mattermost#7326) Cypress/E2E: Fix tests for archived channels (mattermost#7424) Cypress/E2E: Fix tests for bots in list and in sidebar (mattermost#7421) [MM-29108] Simplifies emoji reaction animation (mattermost#7386) Cypress/E2E: Overwrite cy.visit and cy.reload to have default 3s wait (mattermost#7410) [MM-22369] Filter out ldap group sync teams when adding a team to a user (mattermost#7324) MM 31192 - license renewal telemetry (mattermost#7413) Migrate message_attachments folder to Typescript (mattermost#7339) Cypress/E2E: Fix and reorganize tests for custom emojis (mattermost#7415) promote tests with 23 tm4j test cases (mattermost#7402) fix failed tests due to recent change in add users modal (mattermost#7398) fix for more channels and auth specs (mattermost#7416) fix e2e for sidebar channels (mattermost#7412) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate /components/post_view/message_attachments folder to Typescript
Ticket Link
Fix mattermost/mattermost#15457
Related Pull Requests
None
Screenshots
None