This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-31438] Write Unit Tests For System Roles #7338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hahmadia
commented
Jan 18, 2021
| expect(wrapper).toMatchSnapshot(); | ||
| }); | ||
|
|
||
| test('ensure that when you change a prop and component is re-rendered, SystemRolePermission is not being deleted due to isLicensedForCloud being false (test for bug MM-31403)', () => { |
There was a problem hiding this comment.
@sbishel This is unit test for https://mattermost.atlassian.net/browse/MM-31403 which we discussed about writing
hahmadia
added
2: Dev Review
sbishel
suggested changes
Jan 18, 2021
components/admin_console/system_roles/system_role/system_role.test.tsx
Outdated
Show resolved
Hide resolved
|
Looks good apart from the typos that Scott pointed out! |
BenCookie95
approved these changes
Jan 19, 2021
|
/update-branch |
sbishel
approved these changes
Jan 21, 2021
|
No code change @furqanmlk . Just ensure test run fine and we should be ok. Thanks |
hahmadia
added
4: Reviews Complete
|
Since these are purely test additions and no actual code change, there is no need for QA. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Write the start unit test for System Roles and a unit test for https://mattermost.atlassian.net/browse/MM-31403
Ticket Link
https://mattermost.atlassian.net/browse/MM-31438