-
Notifications
You must be signed in to change notification settings - Fork 2.7k
MM-29636 - add the cancel subscription section in subscription screen #7295
Conversation
Hello @pablovelezvidal, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks @pablovelezvidal!
@pablovelezvidal when got to Billing & Account ➜ Subscription on the spinwick it's blank. Is that expected due to the environment here? |
Yes, I am setting up the PR server manually so you can access that. Will keep you posted when is ready |
@stevemudie @matthewbirtch I've updated the test server here and now you should be able to see the Subscription section in the System Console to review the change. |
Looks good but this will only appear when there's a subscription in place though right? Also, would it make sense to have the contact form pre-fill the 'What can sales help with?' section with the relevant 'I want to cancel my Mattermost account' selection as it already pre-selects 'I need to contact sales' now? On that note, since the form lacks a "support" dropdown (there's only technical, billing & sales) should be reworked to include it? I'm just thinking it might be a point of confusion since the customer clicked the "Contact Support" button and the form sets them up with "I need to contact sales" automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! nice work @pablovelezvidal.
Agree with @stevemudie about the possibility of updating the contact form to prefill with 'I want to cancel my subscription' or something along those lines, but that's outside of the scope of this PR.
Agreed, @matthewbirtch thoughts on wording? At the same time it's odd to call it Spec for reference: https://docs.google.com/document/d/1O_2d5cWtH3-8sq2wdHuHpfbSbxjPkfuzNJTdas71dRo/edit#bookmark=id.c7xmi1v4ly1h |
@marianunez shouldn't it preselect the "I want to cancel my Mattermost account" option though? It doesn't seem to be doing that for me. As for the language confusion, one simple way to alleviate some of the confusion would be to simply change the button from 'Contact Support' to 'Contact Us' on system console cancelation section. The resulting page title is 'Contact Us' anyway |
Yes, it should but currently CWS doesn't support the second parameter to be preselected. I will create a follow-up ticket to implement outside of this PR.
+1 on 'Contact Us' wording. @pablovelezvidal could you update the button text to that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work @pablovelezvidal!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
The ticket to follow up this PR is MM-31935 |
/update-branch |
Test server destroyed |
1 similar comment
Test server destroyed |
Summary
This Merge Request adds the cancel subscription section to the subscription page under the System Console > Billing & Account > Subscription
Ticket Link
This MR fixes MM-29636
Screenshots