Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-29636 - add the cancel subscription section in subscription screen #7295

Merged
merged 6 commits into from
Jan 13, 2021

Conversation

pvev
Copy link
Contributor

@pvev pvev commented Jan 8, 2021

Summary

This Merge Request adds the cancel subscription section to the subscription page under the System Console > Billing & Account > Subscription

Ticket Link

This MR fixes MM-29636

Screenshots

Captura de pantalla 2021-01-08 a las 13 52 42

Captura de pantalla 2021-01-08 a las 13 52 32

@mattermod
Copy link
Contributor

Hello @pablovelezvidal,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@pvev pvev added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Jan 8, 2021
@nickmisasi nickmisasi added the 1: UX Review Requires review by a UX Designer label Jan 8, 2021
Copy link
Member

@marianunez marianunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @pablovelezvidal!

@marianunez marianunez added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Jan 8, 2021
@stevemudie
Copy link
Contributor

@pablovelezvidal when got to Billing & Account ➜ Subscription on the spinwick it's blank. Is that expected due to the environment here?

@marianunez
Copy link
Member

@pablovelezvidal when got to Billing & Account ➜ Subscription on the spinwick it's blank. Is that expected due to the environment here?

Yes, I am setting up the PR server manually so you can access that. Will keep you posted when is ready

@marianunez
Copy link
Member

@pablovelezvidal when got to Billing & Account ➜ Subscription on the spinwick it's blank. Is that expected due to the environment here?

@stevemudie @matthewbirtch I've updated the test server here and now you should be able to see the Subscription section in the System Console to review the change.

@stevemudie
Copy link
Contributor

stevemudie commented Jan 8, 2021

Looks good but this will only appear when there's a subscription in place though right?

Also, would it make sense to have the contact form pre-fill the 'What can sales help with?' section with the relevant 'I want to cancel my Mattermost account' selection as it already pre-selects 'I need to contact sales' now?

On that note, since the form lacks a "support" dropdown (there's only technical, billing & sales) should be reworked to include it? I'm just thinking it might be a point of confusion since the customer clicked the "Contact Support" button and the form sets them up with "I need to contact sales" automatically.

Copy link
Contributor

@matthewbirtch matthewbirtch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! nice work @pablovelezvidal.

Agree with @stevemudie about the possibility of updating the contact form to prefill with 'I want to cancel my subscription' or something along those lines, but that's outside of the scope of this PR.

@matthewbirtch matthewbirtch removed the 1: UX Review Requires review by a UX Designer label Jan 8, 2021
@matthewbirtch
Copy link
Contributor

One question I had in the screenshot provided in the description, how did you get a state where there were no subscription details to the left of the 'Need more users' callout?
image

@marianunez
Copy link
Member

I'm just thinking it might be a point of confusion since the customer clicked the "Contact Support" button and the form sets them up with "I need to contact sales" automatically.

Agreed, @matthewbirtch thoughts on wording?

At the same time it's odd to call it Contact Sales when you want to cancel. Maybe we can move the option to cancel your subscription to the technical request in the cloud contact us page instead of under I have a sales request?

Spec for reference: https://docs.google.com/document/d/1O_2d5cWtH3-8sq2wdHuHpfbSbxjPkfuzNJTdas71dRo/edit#bookmark=id.c7xmi1v4ly1h

@matthewbirtch
Copy link
Contributor

@marianunez shouldn't it preselect the "I want to cancel my Mattermost account" option though? It doesn't seem to be doing that for me.
image

As for the language confusion, one simple way to alleviate some of the confusion would be to simply change the button from 'Contact Support' to 'Contact Us' on system console cancelation section. The resulting page title is 'Contact Us' anyway

@marianunez
Copy link
Member

shouldn't it preselect the "I want to cancel my Mattermost account" option though? It doesn't seem to be doing that for me.

Yes, it should but currently CWS doesn't support the second parameter to be preselected. I will create a follow-up ticket to implement outside of this PR.

As for the language confusion, one simple way to alleviate some of the confusion would be to simply change the button from 'Contact Support' to 'Contact Us' on system console cancelation section. The resulting page title is 'Contact Us' anyway

+1 on 'Contact Us' wording. @pablovelezvidal could you update the button text to that?

Copy link
Contributor

@nickmisasi nickmisasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work @pablovelezvidal!

@marianunez marianunez removed the 2: Dev Review Requires review by a core commiter label Jan 11, 2021
Copy link
Contributor

@stevemudie stevemudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@stevemudie stevemudie added QA Review Done and removed 3: QA Review Requires review by a QA tester labels Jan 12, 2021
@marianunez marianunez added the 4: Reviews Complete All reviewers have approved the pull request label Jan 12, 2021
@pvev
Copy link
Contributor Author

pvev commented Jan 12, 2021

@marianunez shouldn't it preselect the "I want to cancel my Mattermost account" option though? It doesn't seem to be doing that for me.
image

As for the language confusion, one simple way to alleviate some of the confusion would be to simply change the button from 'Contact Support' to 'Contact Us' on system console cancelation section. The resulting page title is 'Contact Us' anyway

The ticket to follow up this PR is MM-31935

@marianunez
Copy link
Member

/update-branch

@pvev pvev merged commit 941501d into master Jan 13, 2021
@pvev pvev deleted the MM-29636-cancel-subscription branch January 13, 2021 08:47
@mattermod mattermod removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Jan 13, 2021
@mm-cloud-bot
Copy link

Test server destroyed

1 similar comment
@mm-cloud-bot
Copy link

Test server destroyed

@amyblais amyblais added this to the v5.32.0 milestone Jan 13, 2021
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Jan 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation QA Review Done
Projects
None yet
8 participants