Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[ICU-699] Single view image improvement #727

Merged
merged 1 commit into from
Feb 6, 2018
Merged

[ICU-699] Single view image improvement #727

merged 1 commit into from
Feb 6, 2018

Conversation

saturninoabril
Copy link
Member

@saturninoabril saturninoabril commented Feb 6, 2018

Summary

Fix the following for single view image:

  1. Remove size and image type from title
  2. Title should not upper case (keep case of uploaded file)
  3. Title should be same font size as normal text but bolded
  4. Reduce minimum height and width to 50 pixels
  5. Remove download button on single

[UPDATE - end result]
screen shot 2018-02-06 at 9 38 00 pm

After clicking the single image or its filename, image download is available at image modal, like:
screen shot 2018-02-06 at 9 39 16 pm

Ticket Link

Jira ticket: ICU-699

Checklist

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit and component tests passed
  • Has UI changes

@saturninoabril saturninoabril added the 2: Dev Review Requires review by a core commiter label Feb 6, 2018
@saturninoabril saturninoabril added this to the v4.7.0 milestone Feb 6, 2018
@enahum
Copy link
Contributor

enahum commented Feb 6, 2018

Code looks good, can you post a screenshot to see the end result?

In the case of a single image what shojld I do to download the file?

@saturninoabril
Copy link
Member Author

@enahum I've updated the summary above with end result screenshot.
To download the image, the user may click the image itself or the filename to show ViewImageModal where Download link is available (see screenshot above).

@saturninoabril saturninoabril added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Feb 6, 2018
@GoldUniform GoldUniform merged commit 2bce1cf into mattermost:master Feb 6, 2018
@GoldUniform GoldUniform removed the 4: Reviews Complete All reviewers have approved the pull request label Feb 6, 2018
@saturninoabril saturninoabril deleted the ICU-699 branch February 6, 2018 20:24
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Needed Requires documentation labels Feb 6, 2018
@amyblais amyblais assigned esethna and unassigned GoldUniform Feb 6, 2018
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label Feb 6, 2018
@amyblais amyblais added Docs/Not Needed Does not require documentation and removed Docs/Needed Requires documentation labels Feb 7, 2018
hmhealey pushed a commit that referenced this pull request Aug 28, 2020
hmhealey pushed a commit that referenced this pull request Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants